Skip to content

Create ApplicationPasswordUseCase protocol. #8382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2022
Merged

Create ApplicationPasswordUseCase protocol. #8382

merged 4 commits into from
Dec 12, 2022
+42 −0

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Dec 12, 2022

Closes: #8381

Description

This PR introduces ApplicationPasswordUseCase protocol to act as an interface for application password generation and deletion. A dummy implementation of this protocol will be used in future PR to work parallelly.

Testing instructions

CI passing is enough.

Screenshots

NA

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@selanthiraiyan selanthiraiyan added type: task An internally driven task. feature: login Related to any part of the log in or sign in flow, or authentication. labels Dec 12, 2022
@selanthiraiyan selanthiraiyan added this to the 11.7 milestone Dec 12, 2022
@selanthiraiyan selanthiraiyan marked this pull request as ready for review December 12, 2022 08:37
itsmeichigo
itsmeichigo approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

WooCommerce/Classes/Authentication/Application password/ApplicationPasswordUseCase.swift Outdated
struct ApplicationPassword {
/// WordPress org username that the application password belongs to
///
let wpOrgUername: String
Copy link
Contributor

@itsmeichigo itsmeichigo Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo 😅

Suggested change
let wpOrgUername: String
let wpOrgUsername: String

@itsmeichigo
Copy link
Contributor

itsmeichigo commented Dec 12, 2022

One thing that I missed: I thought ApplicationPasswordUseCase would be in the Networking layer since we planned to let the AlamofireNetwork work with it. Should we move it there and import the use case class on the UI layer later if needed?

@selanthiraiyan
Copy link
Contributor Author

selanthiraiyan commented Dec 12, 2022

One thing that I missed: I thought ApplicationPasswordUseCase would be in the Networking layer since we planned to let the AlamofireNetwork work with it. Should we move it there and import the use case class on the UI layer later if needed?

I didn't think about this. I agree that it should reside in the Networking layer. Moved in 22280d3

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 12, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8382-9a3fc9e on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan merged commit 69be467 into trunk Dec 12, 2022
@selanthiraiyan selanthiraiyan deleted the feat/8381-protocol-for-application-password branch December 12, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@jaclync jaclync Awaiting requested review from jaclync

Assignees

No one assigned

Labels

feature: login Related to any part of the log in or sign in flow, or authentication. type: task An internally driven task.

Projects

None yet

Milestone

11.7

Development

Successfully merging this pull request may close these issues.

Create Application password protocol

4 participants

@selanthiraiyan @itsmeichigo @wpmobilebot