Store creation enhancement: show an alert when it times out waiting for Jetpack site #8406
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed site to become a Jetpack site.
Collaborator
You can test the changes from this Pull Request by:
|
selanthiraiyan
approved these changes
Dec 15, 2022
Contributor
selanthiraiyan
left a comment
selanthiraiyan
left a comment
There was a problem hiding this comment.
I tested this by turning off the internet, and Ii works as expected.
LGTM 🚢
jaclync
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8118
Description
Testing instructions
Right now, after the checkout step, we wait for the newly created site to become a Jetpack site with 10 retries every 5 seconds. However, when the site still hasn't become a Jetpack site after 10 retries, the app currently just hangs on the installation screen and there's nothing to do except for relaunching the app. In this PR, at the end of the retries, if the site is still not a Jetpack site the store creation flow is dismissed and an alert is presented. The alert informs the merchant that the new site should appear in the store picker shortly and they can contact support if any issues.
Screenshots
simulator.mov
RELEASE-NOTES.txtif necessary.