Skip to content

Analytics Hub: Format Ranged Picker dates #8413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2022
Merged

Analytics Hub: Format Ranged Picker dates #8413

merged 1 commit into from
Dec 15, 2022

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Dec 14, 2022

Closes: #8344

Why

This PR makes sure that the subtitle header on the RangedDatePicker is properly formatted like the time range card.

How

  • Extracts the dates formatter responsibility into a protocol, so the date picker can be used elsewhere easily.
  • Creates a private AnalyticsTimeRangeCard.DatesFormatter type to use within the AnalyticsTimeRangeCard domain.

Screenshot

Testing Steps

  • Go to the analytics Hub
  • Select a custom time range
  • See that the dates are properly formatted
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the category: tracks Related to analytics, including Tracks Events. label Dec 14, 2022
@Ecarrion Ecarrion added this to the 11.7 milestone Dec 14, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Dec 14, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@Ecarrion Ecarrion mentioned this pull request Dec 14, 2022
Merged
1 task
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 14, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8413-cda4510 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@rachelmcr rachelmcr self-assigned this Dec 15, 2022
rachelmcr
rachelmcr approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach! 👍

@Ecarrion Ecarrion merged commit 1ed0c4e into trunk Dec 15, 2022
@Ecarrion Ecarrion deleted the issue/8344-subtitles branch December 15, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachelmcr rachelmcr

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Milestone

11.7

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Add range format to custom range selector subtitle

4 participants

@Ecarrion @wpmobilebot @rachelmcr