Skip to content

[REST API] Add unit tests for RequestProcessor #8515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 3, 2023
Merged

[REST API] Add unit tests for RequestProcessor #8515

merged 7 commits into from
Jan 3, 2023
+296 −20

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Jan 2, 2023 •
edited
Loading

Closes: #8507

Description

This PR adds unit tests to test the behaviour of RequestProcessor

  • Make RequestAuthenticator a protocol for testability.
  • Rename RequestAuthenticator into DefaultRequestAuthenticator
  • RequestProcessor: Add unit tests to
    • ensure the requests are authenticated from adapt method.
    • ensure that the requests are scheduled for retry properly.
    • validate that application password is generated when needed.

Testing instructions

CI passing should be enough.

Screenshots

NA

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@selanthiraiyan selanthiraiyan added type: task An internally driven task. feature: login Related to any part of the log in or sign in flow, or authentication. labels Jan 2, 2023
@selanthiraiyan selanthiraiyan added this to the 11.8 milestone Jan 2, 2023
@selanthiraiyan selanthiraiyan marked this pull request as ready for review January 2, 2023 09:21
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 2, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8515-6a822bd on your iPhone

If you need access to App Center, please ask a maintainer to add you.

jaclync
jaclync approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests! 🚢

@selanthiraiyan selanthiraiyan merged commit 0d52c61 into trunk Jan 3, 2023
@selanthiraiyan selanthiraiyan deleted the feat/8507-unit-test-request-processor branch January 3, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync jaclync approved these changes

@itsmeichigo itsmeichigo Awaiting requested review from itsmeichigo

Assignees

No one assigned

Labels

feature: login Related to any part of the log in or sign in flow, or authentication. type: task An internally driven task.

Projects

None yet

Milestone

11.8

Development

Successfully merging this pull request may close these issues.

[REST API] Add unit tests for RequestProcessor

4 participants

@selanthiraiyan @wpmobilebot @jaclync