Skip to content

Bulk Editing: Add feature flag and button #8526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2023
Merged

Bulk Editing: Add feature flag and button #8526

merged 3 commits into from
Jan 4, 2023

Conversation

@ealeksandrov
Copy link
Contributor

@ealeksandrov ealeksandrov commented Jan 2, 2023

Closes: #8516

Description

This PR adds feature flag for the "Bulk Products Editing" and entry point for the feature.

Testing

  1. Build and run the app in debug/alpha mode.
  2. On the products list confirm the "Bulk Edit" button appears in the navbar.

Note: navbar may seem cluttered with icons, but SKU scanner button won't appear in the release build.

Screenshots

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ealeksandrov ealeksandrov added feature: product list Related to the product list. status: feature-flagged Behind a feature flag. Milestone is not strongly held. labels Jan 2, 2023
@ealeksandrov ealeksandrov added this to the 11.8 milestone Jan 2, 2023
@ealeksandrov ealeksandrov requested a review from Ecarrion January 2, 2023 18:13
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 2, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8526-83bebc8 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Ecarrion
Ecarrion approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@Ecarrion Ecarrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ealeksandrov ealeksandrov merged commit 618e1e9 into trunk Jan 4, 2023
@ealeksandrov ealeksandrov deleted the issue/8516-bulk-editing-button branch January 4, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ecarrion Ecarrion Ecarrion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: product list Related to the product list. status: feature-flagged Behind a feature flag. Milestone is not strongly held.

Projects

None yet

Milestone

11.8

Development

Successfully merging this pull request may close these issues.

Bulk Editing: Add toolbar icon hidden behind a feature flag

4 participants

@ealeksandrov @wpmobilebot @Ecarrion