Skip to content

REST API: Migrate inbox note endpoints #8641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 16, 2023
Merged

REST API: Migrate inbox note endpoints #8641

merged 7 commits into from
Jan 16, 2023

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 16, 2023 •
edited
Loading

Closes: #8639

Description

This PR updates the mappers for inbox notes and enable REST API for the related endpoints.

Testing instructions

Pre-requisite: due to a rate-limit issue with Pressable sites, create a JN site to ensure that testing is smooth for now.

  • Enable feature flag applicationPasswordAuthenticationForSiteCredentialLogin and build the app.
  • Log out of the app or skip onboarding if needed.
  • On the prologue screen, select Enter your site address and enter the address of your self-hosted site.
  • Proceed to log in with site credentials.
  • When the login succeeds, you should see the home screen.
  • Navigate to the Menu tab and select Inbox. Notice that a list of notes is loaded.
  • Tap the action button on an item, notice that the item is marked as read without error (there should be no error logged in Xcode console ⛔️ Error on mark inbox note as actioned).
  • Tap the Dismiss button on an item, the item should be dismissed without error.
  • Tap the ellipsis button on the top right of the inbox list and select Dismiss all. All notes should be dismissed without error.
  • Navigate out of the inbox screen and back in. The list should still be empty.

Screenshots

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-01-16.at.12.11.13.mp4
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. labels Jan 16, 2023
@itsmeichigo itsmeichigo added this to the 12.0 milestone Jan 16, 2023
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 16, 2023 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8641-809c371 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@jaclync jaclync self-assigned this Jan 16, 2023
jaclync
jaclync approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Non-blocking note: it'd be nice if the links can be authenticated by default in the webview, like how we do for WPCOM credentials. For example, when opening the action with URL {{site_url}}/wp-admin/admin.php?page=wc-addons&section=helper it shows the login page:

Even though Inbox hasn't been launched, this improvement might benefit some other AuthenticatedWebview use cases as well.

@itsmeichigo itsmeichigo mentioned this pull request Jan 16, 2023
Closed
@itsmeichigo
Copy link
Contributor Author

itsmeichigo commented Jan 16, 2023

it'd be nice if the links can be authenticated by default in the webview, like how we do for WPCOM credentials.

Great point, thanks for the suggestion @jaclync. I've created a separate issue for this enhancement in #8643.

Base automatically changed from feat/8637-site-settings-migration to trunk January 16, 2023 07:53
@itsmeichigo itsmeichigo merged commit 32ecdda into trunk Jan 16, 2023
@itsmeichigo itsmeichigo deleted the feat/8639-inbox-note-migration branch January 16, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync jaclync approved these changes

@selanthiraiyan selanthiraiyan Awaiting requested review from selanthiraiyan

Assignees

@jaclync jaclync

Labels

feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. type: task An internally driven task.

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

REST API: Migrate inbox notes endpoints

4 participants

@itsmeichigo @wpmobilebot @jaclync