Skip to content

REST API: Revert naming to RequestProcessor and RequestAuthenticator #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2023
Merged

REST API: Revert naming to RequestProcessor and RequestAuthenticator #8693

merged 3 commits into from
Jan 19, 2023

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 19, 2023

Closes: #8453

Description

When working on #8569, I renamed RequestProcessor and RequestAuthenticator to have the ApplicationPassword to be more specific and avoid confusion with CookieNonceAuthenticator.

@selanthiraiyan clarified that these handle not only application password but also WPCom token. So this PR aims to revert that naming.

Testing instructions

Login with site credentials and application password should still work as before.

  • Enable the feature flag applicationPasswordAuthenticationForSiteCredentialLogin and build the app.
  • Log out of the app or skip onboarding if needed.
  • On the prologue screen, select Enter your site address and proceed with the address of your test site.
  • Log in with your site credentials. Notice that the login succeeds.

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added the feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. label Jan 19, 2023
@itsmeichigo itsmeichigo added this to the 12.0 milestone Jan 19, 2023
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 19, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8693-6ce8602 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan self-assigned this Jan 19, 2023
selanthiraiyan
selanthiraiyan approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@itsmeichigo itsmeichigo merged commit 56f481d into trunk Jan 19, 2023
@itsmeichigo itsmeichigo deleted the feat/8453-revert-renaming branch January 19, 2023 04:08
@itsmeichigo itsmeichigo mentioned this pull request Jan 19, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@selanthiraiyan selanthiraiyan selanthiraiyan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@selanthiraiyan selanthiraiyan

Labels

feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel.

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

REST API: Support application password with site credential login

4 participants

@itsmeichigo @wpmobilebot @selanthiraiyan