Skip to content

[Privacy Choices] Add Analytics to privacy banner #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2023
Merged

[Privacy Choices] Add Analytics to privacy banner #9810

merged 3 commits into from
May 25, 2023

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented May 24, 2023 •
edited
Loading

Closes: #9647

Why

This PR adds the following analytic events to the privacy choices banner.

Testing Steps

  • Log out from the app (to clean the user defaults database)
  • Log in to a WPCom store in the EU region (Can use a VPN)
  • See the banner being presented & the presented event being tracked
  • Make sure the analytic settings remains enabled
  • Tap the "Go so Settings" | "Save" save button.
  • See the appropriate event being tracked.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 24, 2023 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr9810-6f3cf01 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@Ecarrion Ecarrion changed the title Issue/9647 banner analytics [Privacy Choices] Add Analytics to privacy banner May 24, 2023
@peril-woocommerce
Copy link

peril-woocommerce bot commented May 24, 2023

Messages
📖

This PR contains changes to Tracks-related logic. Please ensure the following are completed:
PR Author

  • The PR must be assigned the Tracks label
    PR Reviewer
  • The tracks events must be validated in the Tracks system.
  • Verify the internal tracks spreadsheet has also been updated.

Generated by 🚫 dangerJS

@Ecarrion Ecarrion marked this pull request as ready for review May 24, 2023 15:04
@Ecarrion Ecarrion requested review from ThomazFB and rachelmcr May 24, 2023 15:04
@Ecarrion Ecarrion added the feature: privacy Related to the privacy choices project label May 24, 2023
@Ecarrion Ecarrion added this to the 13.8 milestone May 24, 2023
@rachelmcr rachelmcr self-assigned this May 25, 2023
rachelmcr
rachelmcr approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and tests well. I'll go ahead and merge this so we can move forward with testing (discussion: p1685017504654089/1684966811.885719-slack-C02KUCFCSFP).

@rachelmcr rachelmcr merged commit 295d1aa into trunk May 25, 2023
@rachelmcr rachelmcr deleted the issue/9647-banner-analytics branch May 25, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachelmcr rachelmcr

Labels

feature: privacy Related to the privacy choices project

Projects

None yet

Milestone

13.8

Development

Successfully merging this pull request may close these issues.

[Privacy Choices] Banner Analytics

4 participants

@Ecarrion @wpmobilebot @rachelmcr