Local backend: setup clone step respects context (#6030)

Author: 6543

pipeline/backend/local/clone.go

@@ -47,7 +47,7 @@ func (e *local) loadClone() {
 }
 
 // setupClone prepare the clone environment before exec.
-func (e *local) setupClone(state *workflowState) error {
+func (e *local) setupClone(ctx context.Context, state *workflowState) error {
 	if e.pluginGitBinary != "" {
 		state.pluginGitBinary = e.pluginGitBinary
 		return nil
@@ -58,7 +58,7 @@ func (e *local) setupClone(state *workflowState) error {
 	if e.os == "windows" {
 		state.pluginGitBinary += ".exe"
 	}
-	return e.downloadLatestGitPluginBinary(state.pluginGitBinary)
+	return e.downloadLatestGitPluginBinary(ctx, state.pluginGitBinary)
 }
 
 // execClone executes a clone-step locally.
@@ -67,7 +67,7 @@ func (e *local) execClone(ctx context.Context, step *types.Step, state *workflow
 		return fmt.Errorf("check for git clone capabilities failed: %w", err)
 	}
 
-	if err := e.setupClone(state); err != nil {
+	if err := e.setupClone(ctx, state); err != nil {
 		return fmt.Errorf("setup clone step failed: %w", err)
 	}
 
@@ -137,7 +137,7 @@ func (e *local) writeNetRC(step *types.Step, state *workflowState) (string, erro
 
 // downloadLatestGitPluginBinary download the latest plugin-git binary based on runtime OS and Arch
 // and saves it to dest.
-func (e *local) downloadLatestGitPluginBinary(dest string) error {
+func (e *local) downloadLatestGitPluginBinary(ctx context.Context, dest string) error {
 	type asset struct {
 		Name               string
 		BrowserDownloadURL string `json:"browser_download_url"`
@@ -148,7 +148,7 @@ func (e *local) downloadLatestGitPluginBinary(dest string) error {
 	}
 
 	// get latest release
-	req, _ := http.NewRequest(http.MethodGet, "https://api.github.com/repos/woodpecker-ci/plugin-git/releases/latest", nil)
+	req, _ := http.NewRequestWithContext(ctx, http.MethodGet, "https://api.github.com/repos/woodpecker-ci/plugin-git/releases/latest", nil)
 	req.Header.Set("Accept", "application/vnd.github+json")
 	req.Header.Set("X-GitHub-Api-Version", "2022-11-28")
 	resp, err := http.DefaultClient.Do(req)
@@ -164,19 +164,23 @@ func (e *local) downloadLatestGitPluginBinary(dest string) error {
 
 	for _, at := range rel.Assets {
 		if strings.Contains(at.Name, e.os) && strings.Contains(at.Name, e.arch) {
-			resp2, err := http.Get(at.BrowserDownloadURL)
+			req, err := http.NewRequestWithContext(ctx, http.MethodGet, at.BrowserDownloadURL, nil)
+			if err != nil {
+				return err
+			}
+			assetResp, err := http.DefaultClient.Do(req)
 			if err != nil {
 				return fmt.Errorf("could not download plugin-git: %w", err)
 			}
-			defer resp2.Body.Close()
+			defer assetResp.Body.Close()
 
 			file, err := os.Create(dest)
 			if err != nil {
 				return fmt.Errorf("could not create plugin-git: %w", err)
 			}
 			defer file.Close()
 
-			if _, err := io.Copy(file, resp2.Body); err != nil {
+			if _, err := io.Copy(file, assetResp.Body); err != nil {
 				return fmt.Errorf("could not download plugin-git: %w", err)
 			}
 			if err := os.Chmod(dest, 0o755); err != nil {