Add "Play this page in MPV" when right clicking current page

[parfait8566]

I like to keep extension icons hidden. It'd be useful to open the link I'm currently on with the extension by add an option to the right click (so without necessarily clicking the icon).

[woodruffw]

I'm not sure I follow -- there's already a right-click context menu item. Do you not see that when right-clicking on a URL?

You can see it in the source code here:

ff2mpv/ff2mpv.js

Lines 157 to 166 in b312d7e

	await profiles.reduce(async (promise, profile) => {
	await promise;
	await chrome.contextMenus.create({
	parentId: "ff2mpv",
	id: profile.id,
	title: profile.name,
	contexts,
	});
	}, Promise.resolve());
	}

[DanSM-5]

I would suggest to assign a keyboard shortcut to the extension. It will act as if you click on the extension icon without the need for it to be visible.

[parfait8566]

I'm not sure I follow -- there's already a right-click context menu item. Do you not see that when right-clicking on a URL?

I'd like to see the context menu item even when not clicking on any link (clicking this item would open in mpv the e.g. YouTube page I'm currently in)

[woodruffw]

Ah, gotcha. I'd have to see whether that's possible with webextensions (adding a context item on a link is easy, not sure about on content clicks), but if it is possible I agree this would be nice for us to support.

[parfait8566]

https://github.com/Baldomo/open-in-mpv has it, so it should be possible

[DanSM-5]

I think it is possible by including a context menu with "page" value for contexts and handle the case in submenuClicked. However I wouldn't like to have the context menu present at all times as I currently know if I clicked on the correct part of the page if I'm able to see the context menu. For me having the context menu always on would increase false positives when launching videos as the current page is more likely to have non playable urls or play something unintentional. Not to mention there will be more clutter in the context menu at all times even when you don't intend to use the extension.

It is not possible to have a separate context menu entry to always play the page because by default multiple context menu entries from the same extension are grouped into a single entry with a dropdown and it has been reported in the past that it is not a desirable behavior to be the default. See #114.

I can only imagine this working by adding a configuration option. There is already an options menu for the profiles. It could potentially have an extra checkbox there and store the value to include "page" or not.