Skip to content

Commit c467c47

Browse files
committed
refactor: 마이페이지 랭킹 응답 DTO를 로컬 정의로 변경
1 parent dfdb63d commit c467c47

12 files changed

Lines changed: 63 additions & 177 deletions

File tree

backend/bom-bom-server/generated/openapi/me/bombom/openapi/mypage/api/MyPageApi.java

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,16 @@
66

77
import io.swagger.v3.oas.annotations.Operation;
88
import io.swagger.v3.oas.annotations.Parameter;
9-
import io.swagger.v3.oas.annotations.enums.ParameterIn;
109
import io.swagger.v3.oas.annotations.media.Content;
1110
import io.swagger.v3.oas.annotations.media.Schema;
1211
import io.swagger.v3.oas.annotations.responses.ApiResponse;
1312
import io.swagger.v3.oas.annotations.security.SecurityRequirement;
1413
import io.swagger.v3.oas.annotations.tags.Tag;
1514
import jakarta.annotation.Generated;
16-
import jakarta.validation.Valid;
1715
import jakarta.validation.constraints.*;
1816
import me.bombom.api.v1.common.resolver.LoginMember;
1917
import me.bombom.api.v1.member.domain.Member;
2018
import me.bombom.openapi.mypage.model.MemberJoinDaysResponse;
21-
import me.bombom.openapi.mypage.model.RankSummaryResponse;
2219
import org.springframework.http.HttpStatus;
2320
import org.springframework.validation.annotation.Validated;
2421
import org.springframework.web.bind.annotation.*;
@@ -56,48 +53,4 @@ public interface MyPageApi {
5653
produces = {"application/json"})
5754
@ResponseStatus(HttpStatus.OK)
5855
MemberJoinDaysResponse getMemberJoinDays(@Parameter(hidden = true) @LoginMember Member member);
59-
60-
/**
61-
* GET /api/v1/members/me/rank : 마이페이지 랭킹 요약 조회 로그인한 회원의 마이페이지 랭킹 카드를 조회합니다. rankHistory와
62-
* currentRank는 현재월을 제외한 이전달까지의 확정 랭킹을 기준으로 합니다. reading 카드의 value는 누적 읽은 아티클 수, streak 카드의 value는
63-
* 현재 연속 읽기 일수입니다.
64-
*
65-
* @param type 랭킹 타입 (streak 또는 reading). 생략하면 모든 랭킹 카드를 반환합니다. (optional)
66-
* @return 마이페이지 랭킹 요약 조회 성공 (status code 200) or 잘못된 랭킹 타입 요청 (status code 400) or 인증 실패 (status
67-
* code 401)
68-
*/
69-
@Operation(
70-
operationId = "getRankSummary",
71-
summary = "마이페이지 랭킹 요약 조회",
72-
description =
73-
"로그인한 회원의 마이페이지 랭킹 카드를 조회합니다. rankHistory와 currentRank는 현재월을 제외한 이전달까지의 확정 랭킹을 기준으로 합니다. reading 카드의 value는 누적 읽은 아티클 수, streak 카드의 value는 현재 연속 읽기 일수입니다.",
74-
tags = {"MyPage"},
75-
responses = {
76-
@ApiResponse(
77-
responseCode = "200",
78-
description = "마이페이지 랭킹 요약 조회 성공",
79-
content = {
80-
@Content(
81-
mediaType = "application/json",
82-
schema = @Schema(implementation = RankSummaryResponse.class))
83-
}),
84-
@ApiResponse(responseCode = "400", description = "잘못된 랭킹 타입 요청"),
85-
@ApiResponse(responseCode = "401", description = "인증 실패")
86-
},
87-
security = {@SecurityRequirement(name = "sessionCookie")})
88-
@RequestMapping(
89-
method = RequestMethod.GET,
90-
value = "/api/v1/members/me/rank",
91-
produces = {"application/json"})
92-
@ResponseStatus(HttpStatus.OK)
93-
RankSummaryResponse getRankSummary(
94-
@Parameter(hidden = true) @LoginMember Member member,
95-
@Parameter(
96-
name = "type",
97-
description = "랭킹 타입 (streak 또는 reading). 생략하면 모든 랭킹 카드를 반환합니다.",
98-
in = ParameterIn.QUERY)
99-
@Valid
100-
@RequestParam(value = "type", required = false)
101-
String type
102-
);
10356
}

backend/bom-bom-server/generated/openapi/me/bombom/openapi/mypage/model/RankCardResponse.java

Lines changed: 0 additions & 48 deletions
This file was deleted.

backend/bom-bom-server/generated/openapi/me/bombom/openapi/mypage/model/RankHistoryResponse.java

Lines changed: 0 additions & 40 deletions
This file was deleted.

backend/bom-bom-server/generated/openapi/me/bombom/openapi/mypage/model/RankSummaryResponse.java

Lines changed: 0 additions & 32 deletions
This file was deleted.

backend/bom-bom-server/gradle/openapi-generator.gradle

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ def openApiDomainGroups = [
3636
apis : "MyPage",
3737
models : [
3838
"MemberJoinDaysResponse",
39-
"RankCardResponse",
40-
"RankHistoryResponse",
41-
"RankSummaryResponse",
4239
].join(","),
4340
],
4441
[

backend/bom-bom-server/src/main/java/me/bombom/api/v1/member/controller/MyPageController.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
import lombok.RequiredArgsConstructor;
44
import me.bombom.api.v1.common.resolver.LoginMember;
55
import me.bombom.api.v1.member.domain.Member;
6+
import me.bombom.api.v1.member.dto.response.RankSummaryResponse;
67
import me.bombom.api.v1.member.service.MemberService;
78
import me.bombom.api.v1.member.service.MyPageService;
89
import me.bombom.openapi.mypage.api.MyPageApi;
910
import me.bombom.openapi.mypage.model.MemberJoinDaysResponse;
10-
import me.bombom.openapi.mypage.model.RankSummaryResponse;
1111
import org.springframework.web.bind.annotation.GetMapping;
1212
import org.springframework.web.bind.annotation.RequestMapping;
1313
import org.springframework.web.bind.annotation.RequestParam;
@@ -27,7 +27,6 @@ public MemberJoinDaysResponse getMemberJoinDays(@LoginMember Member member) {
2727
return memberService.getJoinDays(member);
2828
}
2929

30-
@Override
3130
@GetMapping("/rank")
3231
public RankSummaryResponse getRankSummary(
3332
@LoginMember Member member,
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
package me.bombom.api.v1.member.dto.response;
2+
3+
import java.util.List;
4+
5+
public record RankCardResponse(
6+
String type,
7+
Long currentRank,
8+
List<RankHistoryResponse> rankHistory,
9+
int value
10+
) {
11+
12+
public static RankCardResponse of(
13+
String type,
14+
Long currentRank,
15+
List<RankHistoryResponse> rankHistory,
16+
int value
17+
) {
18+
return new RankCardResponse(
19+
type,
20+
currentRank,
21+
rankHistory,
22+
value
23+
);
24+
}
25+
}
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
package me.bombom.api.v1.member.dto.response;
2+
3+
public record RankHistoryResponse(
4+
String month,
5+
String label,
6+
long rank
7+
) {
8+
9+
public static RankHistoryResponse of(
10+
String month,
11+
String label,
12+
long rank
13+
) {
14+
return new RankHistoryResponse(
15+
month,
16+
label,
17+
rank
18+
);
19+
}
20+
}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package me.bombom.api.v1.member.dto.response;
2+
3+
import java.util.List;
4+
5+
public record RankSummaryResponse(
6+
List<RankCardResponse> cards
7+
) {
8+
9+
public static RankSummaryResponse from(List<RankCardResponse> cards) {
10+
return new RankSummaryResponse(cards);
11+
}
12+
}

0 commit comments

Comments
 (0)