Skip to content

Commit cc7318c

Browse files
Gerardo Pachecoderekblank
andauthored
[Gutenberg] - React Native 0.69.4 Upgrade (#17066)
* Remove hermes-mirror in favor of react-native-mirror having both hermes and react native binaries. It also comments out excluding the hermes debug libraries * Exclude com.facebook.fbjni from Gutenberg Mobile binary * Exclude fabricjni.so * Remove hermes-mirror in favor of react-native-mirror having both hermes and react native binaries. It also comments out excluding the hermes debug libraries * Exclude com.facebook.fbjni from Gutenberg Mobile binary * Fix Soloader version to fix issue with instrumented tests * React Native Upgrade - Avoid duplicated classes * Remove unneeded code * Update gutenberg-mobile tag to 1.86.0-alpha1 * Fix typo in Gutenberg tag reference * Update gutenberg tag Co-authored-by: Derek Blank <[email protected]>
1 parent 69d5252 commit cc7318c

File tree

3 files changed

+29
-18
lines changed

3 files changed

+29
-18
lines changed

WordPress/build.gradle

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ repositories {
2929
includeGroup "com.automattic.tracks"
3030
}
3131
}
32-
maven {
33-
url "https://a8c-libs.s3.amazonaws.com/android/hermes-mirror"
34-
content {
35-
includeGroup "org.wordpress-mobile"
36-
}
37-
}
3832
maven {
3933
url "https://a8c-libs.s3.amazonaws.com/android/react-native-mirror"
4034
content {
@@ -269,10 +263,13 @@ android {
269263
// MPAndroidChart uses androidX - remove this line when we migrate everything to androidX
270264
exclude 'META-INF/proguard/androidx-annotations.pro'
271265

272-
// Exclude React Native's JSC and Hermes debug binaries
266+
// Exclude React Native's JSC and Fabric JNI
273267
exclude '**/libjscexecutor.so'
274-
exclude '**/libhermes-inspector.so'
275-
exclude '**/libhermes-executor-debug.so'
268+
exclude '**/libfabricjni.so'
269+
270+
// Avoid React Native's JNI duplicated classes
271+
pickFirst '**/libc++_shared.so'
272+
pickFirst '**/libfbjni.so'
276273

277274
pickFirst 'META-INF/-no-jdk.kotlin_module'
278275

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ ext {
2020
automatticRestVersion = '1.0.8'
2121
automatticStoriesVersion = '2.0.0'
2222
automatticTracksVersion = '2.2.0'
23-
gutenbergMobileVersion = 'v1.85.1'
23+
gutenbergMobileVersion = 'v1.86.0-alpha1'
2424
wordPressAztecVersion = 'v1.6.2'
2525
wordPressFluxCVersion = '2.6.0'
2626
wordPressLoginVersion = '1.0.0'

libs/editor/build.gradle

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,9 @@ repositories {
2121
includeGroup "com.facebook.react"
2222
}
2323
}
24-
maven {
25-
url "https://a8c-libs.s3.amazonaws.com/android/hermes-mirror"
26-
content {
27-
includeGroup "org.wordpress-mobile"
28-
}
29-
}
3024
google()
3125
mavenCentral()
3226
maven { url "https://www.jitpack.io" }
33-
maven { url "https://a8c-libs.s3.amazonaws.com/android/hermes-mirror" }
3427
}
3528

3629
android {
@@ -74,10 +67,31 @@ dependencies {
7467
strictly wordPressAztecVersion
7568
}
7669
}
70+
71+
// Forcing version due to https://github.com/facebook/SoLoader/issues/94
72+
// To be removed with React Native 0.70+
73+
implementation("com.facebook.soloader:soloader") {
74+
version {
75+
strictly '0.10.4'
76+
}
77+
}
78+
79+
implementation 'com.facebook.fresco:fresco:2.5.0'
80+
implementation 'com.facebook.fresco:imagepipeline-okhttp3:2.5.0'
81+
implementation 'com.facebook.fbjni:fbjni:0.2.2'
82+
implementation 'com.facebook.react:hermes-engine:0.69.4:release@aar'
83+
implementation 'com.facebook.react:react-native:0.69.4:release@aar'
84+
7785
// This dependency will be substituted if the `local-builds.gradle` file contains
7886
// `localGutenbergMobilePath`. Details for this can be found in the `settings.gradle` file.
79-
implementation "$rootProject.gradle.ext.gutenbergMobileBinaryPath:$rootProject.ext.gutenbergMobileVersion"
87+
implementation ("$rootProject.gradle.ext.gutenbergMobileBinaryPath:$rootProject.ext.gutenbergMobileVersion") {
88+
exclude module: 'hermes-engine'
89+
exclude module: 'react-native'
90+
}
8091

92+
// Required Aztec dependencies (they should be included but Jitpack seems to be stripping these out)
93+
implementation "org.jsoup:jsoup:$jsoupVersion"
94+
8195
implementation "org.wordpress:utils:$wordPressUtilsVersion"
8296

8397
implementation "androidx.appcompat:appcompat:$androidxAppcompatVersion"

0 commit comments

Comments
 (0)