Merge pull request #2626 from wordpress-mobile/issue/2624-blogging-prompts-fetch

[Blogging Prompts] Return list of prompts when calling fetchPrompts

Author: Thomas Horta

example/src/test/java/org/wordpress/android/fluxc/store/bloggingprompts/BloggingPromptsStoreTest.kt

@@ -191,7 +191,7 @@ class BloggingPromptsStoreTest {
     }
 
     @Test
-    fun `when fetch prompts triggered, then all prompt model are inserted into db`() = test {
+    fun `when fetch prompts triggered, then all prompt models are inserted into db`() = test {
         val payload = BloggingPromptsPayload(PROMPTS_RESPONSE)
         whenever(
             restClient.fetchPrompts(
@@ -207,7 +207,7 @@ class BloggingPromptsStoreTest {
     }
 
     @Test
-    fun `given cards response, when fetch cards gets triggered, then empty cards model is returned`() =
+    fun `given cards response, when fetch cards gets triggered, then all prompt models are returned in the result`() =
         test {
             val payload = BloggingPromptsPayload(PROMPTS_RESPONSE)
             whenever(
@@ -226,7 +226,7 @@ class BloggingPromptsStoreTest {
                 requestedPromptDate
             )
 
-            assertThat(result.model).isNull()
+            assertThat(result.model).isEqualTo(PROMPT_MODELS)
             assertThat(result.error).isNull()
         }
 

fluxc/src/main/java/org/wordpress/android/fluxc/store/bloggingprompts/BloggingPromptsStore.kt

@@ -84,8 +84,9 @@ class BloggingPromptsStore @Inject constructor(
         site: SiteModel,
         response: BloggingPromptsListResponse
     ): BloggingPromptsResult<List<BloggingPromptModel>> = try {
-        promptsDao.insertForSite(site.id, response.toBloggingPrompts())
-        BloggingPromptsResult()
+        val prompts = response.toBloggingPrompts()
+        promptsDao.insertForSite(site.id, prompts)
+        BloggingPromptsResult(prompts)
     } catch (e: Exception) {
         BloggingPromptsResult(BloggingPromptsError(GENERIC_ERROR))
     }