Translate BlogDetailsViewController to Swift (#24981)

* Extract the table view in Blog Details to Swift

* Fix cards on the blog details

* Remove an unused function

* Fix compilation issues

* Delete irrelevant unit tests

* Translate BlogDetailsViewController to Swift

* Delete an import statement

* Remove an empty line

* Assign cell identifier as accessibly identifier (when not set)

Porting the original Objective-C code

* Update localizable string keys

Author: crazytonyli

Sources/Keystone/WordPress.h

@@ -12,7 +12,6 @@ FOUNDATION_EXPORT const unsigned char WordPressVersionString[];
 
 #import <WordPress/BlogService.h>
 #import <WordPress/BlogSyncFacade.h>
-#import <WordPress/BlogDetailsViewController.h>
 
 #import <WordPress/CommentService.h>
 #import <WordPress/CommentsViewController.h>

Tests/KeystoneTests/Tests/Features/Blog/BlogDetailsSectionIndexTests.swift

@@ -18,7 +18,7 @@ final class ReaderRootViewPresenter: RootViewPresenter {
         // TODO: (reader) optional?
     }
 
-    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsSubsection?, userInfo: [AnyHashable: Any]) {
+    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsRowKind?, userInfo: [String: Any]) {
         // TODO: (reader) optional?
     }
 

Tests/KeystoneTests/Tests/Features/Blog/BlogDetailsSubsectionToSectionCategoryTests.swift

@@ -9,7 +9,7 @@ protocol RootViewPresenter: AnyObject {
 
     func currentlyVisibleBlog() -> Blog?
     func showMySitesTab()
-    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsSubsection?, userInfo: [AnyHashable: Any])
+    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsRowKind?, userInfo: [String: Any])
 
     func showReader(path: ReaderNavigationPath?)
 
@@ -28,7 +28,7 @@ extension RootViewPresenter {
         showBlogDetails(for: blog, then: nil, userInfo: [:])
     }
 
-    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsSubsection) {
+    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsRowKind) {
         showBlogDetails(for: blog, then: subsection, userInfo: [:])
     }
 
@@ -47,7 +47,7 @@ extension RootViewPresenter {
         }
         var userInfo: [AnyHashable: Any] = [:]
         if let source {
-            userInfo[BlogDetailsViewController.userInfoSourceKey()] = NSNumber(value: source.rawValue)
+            userInfo[BlogDetailsUserInfoKeys.source] = NSNumber(value: source.rawValue)
         }
         showBlogDetails(for: blog, then: .stats)
     }

WordPress/Classes/Apps/Reader/ReaderRootViewPresenter.swift

@@ -49,7 +49,7 @@ class SiteSplitViewContent: SiteMenuViewControllerDelegate, SplitViewDisplayable
         }
     }
 
-    func showSubsection(_ subsection: BlogDetailsSubsection, userInfo: [AnyHashable: Any]) {
+    func showSubsection(_ subsection: BlogDetailsRowKind, userInfo: [String: Any]) {
         siteMenuVC.showSubsection(subsection, userInfo: userInfo)
     }
 }

WordPress/Classes/System/Root View/RootViewPresenter.swift

@@ -241,7 +241,7 @@ final class SplitViewRootPresenter: RootViewPresenter {
         return siteContent?.blog
     }
 
-    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsSubsection?, userInfo: [AnyHashable: Any]) {
+    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsRowKind?, userInfo: [String: Any]) {
         if splitVC.isCollapsed {
             tabBarVC.showBlogDetails(for: blog, then: subsection, userInfo: userInfo)
         } else {

WordPress/Classes/System/Root View/SplitViewRootPresenter+Site.swift

@@ -20,7 +20,7 @@ class StaticScreensTabBarWrapper: RootViewPresenter {
         tabBarController.currentlySelectedScreen()
     }
 
-    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsSubsection?, userInfo: [AnyHashable: Any]) {
+    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsRowKind?, userInfo: [String: Any]) {
         tabBarController.showBlogDetails(for: blog, then: subsection, userInfo: userInfo)
     }
 

WordPress/Classes/System/Root View/SplitViewRootPresenter.swift

@@ -12,7 +12,7 @@ extension WPTabBarController: RootViewPresenter {
         return self
     }
 
-    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsSubsection?, userInfo: [AnyHashable: Any]) {
+    func showBlogDetails(for blog: Blog, then subsection: BlogDetailsRowKind?, userInfo: [String: Any]) {
         mySitesCoordinator.showBlogDetails(for: blog, then: subsection, userInfo: userInfo)
     }
 

WordPress/Classes/System/Root View/StaticScreensTabBarWrapper.swift

@@ -7,7 +7,6 @@
 
 #import "BlogService.h"
 #import "BlogSyncFacade.h"
-#import "BlogDetailsViewController.h"
 
 #import "CommentService.h"
 #import "CommentsViewController.h"