Remove unused code from WPTabBarController

Author: kean

WordPress/Classes/ViewRelated/System/WPTabBarController.h

@@ -2,12 +2,9 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
-extern NSString * const WPNewPostURLParamContentKey;
-extern NSString * const WPNewPostURLParamTagsKey;
 extern NSString * const WPTabBarCurrentlySelectedScreenSites;
 extern NSString * const WPTabBarCurrentlySelectedScreenReader;
 extern NSString * const WPTabBarCurrentlySelectedScreenNotifications;
-extern NSNotificationName const WPTabBarHeightChangedNotification;
 
 @class AbstractPost;
 @class Blog;

WordPress/Classes/ViewRelated/System/WPTabBarController.m

@@ -14,21 +14,12 @@
 @import WordPressShared;
 @import WordPressUI;
 
-static NSString * const WPTabBarButtonClassname = @"UITabBarButton";
 static NSString * const WPApplicationIconBadgeNumberKeyPath = @"applicationIconBadgeNumber";
 
-NSString * const WPNewPostURLParamTitleKey = @"title";
-NSString * const WPNewPostURLParamContentKey = @"content";
-NSString * const WPNewPostURLParamTagsKey = @"tags";
-NSString * const WPNewPostURLParamImageKey = @"image";
-
 NSString * const WPTabBarCurrentlySelectedScreenSites = @"Blog List";
 NSString * const WPTabBarCurrentlySelectedScreenReader = @"Reader";
 NSString * const WPTabBarCurrentlySelectedScreenNotifications = @"Notifications";
 
-NSNotificationName const WPTabBarHeightChangedNotification = @"WPTabBarHeightChangedNotification";
-static NSString * const WPTabBarFrameKeyPath = @"frame";
-
 static NSInteger const WPTabBarIconOffsetiPad = 7;
 static NSInteger const WPTabBarIconOffsetiPhone = 5;
 
@@ -53,8 +44,6 @@ @interface WPTabBarController () <UITabBarControllerDelegate>
 @property (nonatomic, strong) UIImage *meTabBarImageUnreadUnselected;
 @property (nonatomic, strong) UIImage *meTabBarImageUnreadSelected;
 
-@property (nonatomic, assign) CGFloat tabBarHeight;
-
 @end
 
 @implementation WPTabBarController
@@ -101,11 +90,6 @@ - (instancetype)initWithStaticScreens:(BOOL)shouldUseStaticScreens
                                                options:NSKeyValueObservingOptionNew
                                                context:nil];
 
-        [self.tabBar addObserver:self
-                      forKeyPath:WPTabBarFrameKeyPath
-                         options:NSKeyValueObservingOptionNew
-                         context:nil];
-
         [self observeGravatarImageUpdate];
     }
     return self;
@@ -118,7 +102,6 @@ - (instancetype)init
 
 - (void)dealloc
 {
-    [self.tabBar removeObserver:self forKeyPath:WPTabBarFrameKeyPath];
     [[UIApplication sharedApplication] removeObserver:self forKeyPath:WPApplicationIconBadgeNumberKeyPath];
 }
 
@@ -403,25 +386,11 @@ - (BOOL)welcomeNotificationSeen
 
 - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context
 {
-    if (object == self.tabBar && [keyPath isEqualToString:WPTabBarFrameKeyPath]) {
-        [self notifyOfTabBarHeightChangedIfNeeded];
-    }
-
     if (object == [UIApplication sharedApplication] && [keyPath isEqualToString:WPApplicationIconBadgeNumberKeyPath]) {
         [self updateNotificationBadgeVisibility];
     }
 }
 
-- (void)notifyOfTabBarHeightChangedIfNeeded
-{
-    CGFloat newTabBarHeight = self.tabBar.frame.size.height;
-    if (newTabBarHeight != self.tabBarHeight) {
-        self.tabBarHeight = newTabBarHeight;
-        [[NSNotificationCenter defaultCenter] postNotificationName:WPTabBarHeightChangedNotification
-                                                            object:nil];
-    }
-}
-
 #pragma mark - UIResponder & Keyboard Helpers
 
 - (BOOL)canBecomeFirstResponder