Skip to content

Commit 3069cb7

Browse files
committed
Remove redundant #available(iOS 14, *) checks
With iOS 14 as the minimum deployment target, they all return `true`.
1 parent a6702e0 commit 3069cb7

17 files changed

+36
-117
lines changed

WordPress/Classes/Extensions/UITextField+WorkaroundContinueIssue.swift

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,10 @@ extension UITextField {
99
/// Once we drop support for iOS 14, we could remove this extension entirely.
1010
///
1111
public class func shouldActivateWorkaroundForBulgarianKeyboardCrash() -> Bool {
12-
if #available(iOS 14.0, *) {
13-
return true
14-
}
15-
16-
return false
12+
// FIXME: Do _all_ versions above iOS 14 require the workaround?
13+
//
14+
// This code was changed to `true` at the time of making iOS 14 the minimum target.
15+
true
1716
}
1817

1918
/// We're swizzling `UITextField.becomeFirstResponder()` so that we can fix an issue with

WordPress/Classes/Services/Stories/WPMediaPicker+MediaPicker.swift

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@ class WPMediaPickerForKanvas: WPNavigationMediaPickerViewController, MediaPicker
6060
photoPicker.dataSource = WPPHAssetDataSource.sharedInstance()
6161
photoPicker.tabBarItem = UITabBarItem(title: Constants.photosTabBarTitle, image: Constants.photosTabBarIcon, tag: 0)
6262

63-
if #available(iOS 14.0, *),
64-
FeatureFlag.mediaPickerPermissionsNotice.enabled {
63+
if FeatureFlag.mediaPickerPermissionsNotice.enabled {
6564
photoPicker.mediaPicker.registerClass(forCustomHeaderView: DeviceMediaPermissionsHeader.self)
6665
}
6766

@@ -182,8 +181,7 @@ class MediaPickerDelegate: NSObject, WPMediaPickerViewControllerDelegate {
182181
}
183182

184183
func mediaPickerControllerShouldShowCustomHeaderView(_ picker: WPMediaPickerViewController) -> Bool {
185-
guard #available(iOS 14.0, *),
186-
FeatureFlag.mediaPickerPermissionsNotice.enabled,
184+
guard FeatureFlag.mediaPickerPermissionsNotice.enabled,
187185
picker.dataSource is WPPHAssetDataSource else {
188186
return false
189187
}
@@ -192,19 +190,14 @@ class MediaPickerDelegate: NSObject, WPMediaPickerViewControllerDelegate {
192190
}
193191

194192
func mediaPickerControllerReferenceSize(forCustomHeaderView picker: WPMediaPickerViewController) -> CGSize {
195-
guard #available(iOS 14.0, *) else {
196-
return .zero
197-
}
198-
199193
let header = DeviceMediaPermissionsHeader()
200194
header.translatesAutoresizingMaskIntoConstraints = false
201195

202196
return header.referenceSizeInView(picker.view)
203197
}
204198

205199
func mediaPickerController(_ picker: WPMediaPickerViewController, configureCustomHeaderView headerView: UICollectionReusableView) {
206-
guard #available(iOS 14.0, *),
207-
let headerView = headerView as? DeviceMediaPermissionsHeader else {
200+
guard let headerView = headerView as? DeviceMediaPermissionsHeader else {
208201
return
209202
}
210203

WordPress/Classes/Stores/StatsWidgetsStore.swift

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -18,33 +18,24 @@ class StatsWidgetsStore {
1818
if let newTodayData = refreshStats(type: HomeWidgetTodayData.self) {
1919
HomeWidgetTodayData.write(items: newTodayData)
2020

21-
if #available(iOS 14.0, *) {
22-
WidgetCenter.shared.reloadTimelines(ofKind: WPHomeWidgetTodayKind)
23-
}
21+
WidgetCenter.shared.reloadTimelines(ofKind: WPHomeWidgetTodayKind)
2422
}
2523

2624
if let newAllTimeData = refreshStats(type: HomeWidgetAllTimeData.self) {
2725
HomeWidgetAllTimeData.write(items: newAllTimeData)
2826

29-
if #available(iOS 14.0, *) {
30-
WidgetCenter.shared.reloadTimelines(ofKind: WPHomeWidgetAllTimeKind)
31-
}
27+
WidgetCenter.shared.reloadTimelines(ofKind: WPHomeWidgetAllTimeKind)
3228
}
3329

3430
if let newThisWeekData = refreshStats(type: HomeWidgetThisWeekData.self) {
3531
HomeWidgetThisWeekData.write(items: newThisWeekData)
3632

37-
if #available(iOS 14.0, *) {
38-
WidgetCenter.shared.reloadTimelines(ofKind: WPHomeWidgetThisWeekKind)
39-
}
33+
WidgetCenter.shared.reloadTimelines(ofKind: WPHomeWidgetThisWeekKind)
4034
}
4135
}
4236

4337
/// Initialize the local cache for widgets, if it does not exist
4438
func initializeStatsWidgetsIfNeeded() {
45-
guard #available(iOS 14.0, *) else {
46-
return
47-
}
4839
if HomeWidgetTodayData.read() == nil {
4940
DDLogInfo("StatsWidgets: Writing initialization data into HomeWidgetTodayData.plist")
5041
HomeWidgetTodayData.write(items: initializeHomeWidgetData(type: HomeWidgetTodayData.self))
@@ -69,8 +60,7 @@ class StatsWidgetsStore {
6960
/// - widgetType: concrete type of the widget
7061
/// - stats: stats to be stored
7162
func storeHomeWidgetData<T: HomeWidgetData>(widgetType: T.Type, stats: Codable) {
72-
guard #available(iOS 14.0, *),
73-
let siteID = SiteStatsInformation.sharedInstance.siteID else {
63+
guard let siteID = SiteStatsInformation.sharedInstance.siteID else {
7464
return
7565
}
7666

@@ -242,9 +232,6 @@ private extension StatsWidgetsStore {
242232
// MARK: - Extract this week data
243233
extension StatsWidgetsStore {
244234
func updateThisWeekHomeWidget(summary: StatsSummaryTimeIntervalData?) {
245-
guard #available(iOS 14.0, *) else {
246-
return
247-
}
248235
switch summary?.period {
249236
case .day:
250237
guard summary?.periodEndDate == StatsDataHelper.currentDateForSite().normalizedDate() else {
@@ -268,10 +255,6 @@ private extension StatsWidgetsStore {
268255
/// Observes WPAccountDefaultWordPressComAccountChanged notification and reloads widget data based on the state of account.
269256
/// The site data is not yet loaded after this notification and widget data cannot be cached for newly signed in account.
270257
func observeAccountChangesForWidgets() {
271-
guard #available(iOS 14.0, *) else {
272-
return
273-
}
274-
275258
NotificationCenter.default.addObserver(forName: .WPAccountDefaultWordPressComAccountChanged,
276259
object: nil,
277260
queue: nil) { notification in
@@ -293,10 +276,6 @@ private extension StatsWidgetsStore {
293276
/// Observes WPSigninDidFinishNotification notification and initializes the widget.
294277
/// The site data is loaded after this notification and widget data can be cached.
295278
func observeAccountSignInForWidgets() {
296-
guard #available(iOS 14.0, *) else {
297-
return
298-
}
299-
300279
NotificationCenter.default.addObserver(forName: NSNotification.Name(rawValue: WordPressAuthenticator.WPSigninDidFinishNotification),
301280
object: nil,
302281
queue: nil) { [weak self] _ in

WordPress/Classes/Utility/InteractiveNotificationsManager.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -618,11 +618,7 @@ extension InteractiveNotificationsManager: UNUserNotificationCenterDelegate {
618618
if notification.request.content.categoryIdentifier == NoteCategoryDefinition.bloggingReminderWeekly.rawValue
619619
|| notification.request.content.categoryIdentifier == NoteCategoryDefinition.weeklyRoundup.rawValue {
620620

621-
if #available(iOS 14.0, *) {
622-
completionHandler([.banner, .list, .sound])
623-
} else {
624-
completionHandler([.alert, .sound])
625-
}
621+
completionHandler([.banner, .list, .sound])
626622
return
627623
}
628624

WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -636,8 +636,7 @@ class AztecPostViewController: UIViewController, PostEditor {
636636

637637
// Required to work around an issue present in iOS 14 beta 2
638638
// https://github.com/wordpress-mobile/WordPress-iOS/issues/14460
639-
if #available(iOS 14.0, *),
640-
presentedViewController?.view.accessibilityIdentifier == MoreSheetAlert.accessibilityIdentifier {
639+
if presentedViewController?.view.accessibilityIdentifier == MoreSheetAlert.accessibilityIdentifier {
641640
dismiss(animated: true)
642641
}
643642
}
@@ -1326,8 +1325,7 @@ private extension AztecPostViewController {
13261325

13271326
alert.addCancelActionWithTitle(MoreSheetAlert.keepEditingTitle)
13281327

1329-
if #available(iOS 14.0, *),
1330-
let button = navigationBarManager.moreBarButtonItem.customView {
1328+
if let button = navigationBarManager.moreBarButtonItem.customView {
13311329
// Required to work around an issue present in iOS 14 beta 2
13321330
// https://github.com/wordpress-mobile/WordPress-iOS/issues/14460
13331331
alert.popoverPresentationController?.sourceRect = button.convert(button.bounds, to: navigationController?.navigationBar)

WordPress/Classes/ViewRelated/Blog/Site Picker/SitePickerViewController+SiteIcon.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,6 @@ extension SitePickerViewController {
9292
}
9393

9494
func showEmojiPicker() {
95-
guard #available(iOS 14.0, *) else {
96-
return
97-
}
98-
9995
var pickerView = SiteIconPickerView()
10096

10197
pickerView.onCompletion = { [weak self] image in

WordPress/Classes/ViewRelated/Blog/Site Picker/SitePickerViewController.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,7 @@ extension SitePickerViewController: BlogDetailHeaderViewDelegate {
8888
showUpdateSiteIconAlert()
8989
}
9090

91-
if #available(iOS 14.0, *) {
92-
showSiteIconSelectionAlert()
93-
} else {
94-
showUpdateSiteIconAlert()
95-
}
91+
showSiteIconSelectionAlert()
9692
}
9793

9894
func siteIconReceivedDroppedImage(_ image: UIImage?) {

WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaPickerHelper.swift

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ class GutenbergMediaPickerHelper: NSObject {
6868
picker.delegate = self
6969
picker.mediaPicker.registerClass(forReusableCellOverlayViews: DisabledVideoOverlay.self)
7070

71-
if #available(iOS 14.0, *),
72-
FeatureFlag.mediaPickerPermissionsNotice.enabled {
71+
if FeatureFlag.mediaPickerPermissionsNotice.enabled {
7372
picker.mediaPicker.registerClass(forCustomHeaderView: DeviceMediaPermissionsHeader.self)
7473
}
7574

@@ -137,8 +136,7 @@ extension GutenbergMediaPickerHelper: WPMediaPickerViewControllerDelegate {
137136
}
138137

139138
func mediaPickerControllerShouldShowCustomHeaderView(_ picker: WPMediaPickerViewController) -> Bool {
140-
guard #available(iOS 14.0, *),
141-
FeatureFlag.mediaPickerPermissionsNotice.enabled,
139+
guard FeatureFlag.mediaPickerPermissionsNotice.enabled,
142140
picker !== cameraPicker else {
143141
return false
144142
}
@@ -147,19 +145,14 @@ extension GutenbergMediaPickerHelper: WPMediaPickerViewControllerDelegate {
147145
}
148146

149147
func mediaPickerControllerReferenceSize(forCustomHeaderView picker: WPMediaPickerViewController) -> CGSize {
150-
guard #available(iOS 14.0, *) else {
151-
return .zero
152-
}
153-
154148
let header = DeviceMediaPermissionsHeader()
155149
header.translatesAutoresizingMaskIntoConstraints = false
156150

157151
return header.referenceSizeInView(picker.view)
158152
}
159153

160154
func mediaPickerController(_ picker: WPMediaPickerViewController, configureCustomHeaderView headerView: UICollectionReusableView) {
161-
guard #available(iOS 14.0, *),
162-
let headerView = headerView as? DeviceMediaPermissionsHeader else {
155+
guard let headerView = headerView as? DeviceMediaPermissionsHeader else {
163156
return
164157
}
165158

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController+MoreActions.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ extension GutenbergViewController {
7373
ActionDispatcher.dispatch(NoticeAction.unlock)
7474
}
7575

76-
if #available(iOS 14.0, *),
77-
let button = navigationBarManager.moreBarButtonItem.customView {
76+
if let button = navigationBarManager.moreBarButtonItem.customView {
7877
// Required to work around an issue present in iOS 14 beta 2
7978
// https://github.com/wordpress-mobile/WordPress-iOS/issues/14460
8079
alert.popoverPresentationController?.sourceRect = button.convert(button.bounds, to: navigationController?.navigationBar)

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -402,8 +402,7 @@ class GutenbergViewController: UIViewController, PostEditor, FeaturedImageDelega
402402

403403
// Required to work around an issue present in iOS 14 beta 2
404404
// https://github.com/wordpress-mobile/WordPress-iOS/issues/14460
405-
if #available(iOS 14.0, *),
406-
presentedViewController?.view.accessibilityIdentifier == MoreSheetAlert.accessibilityIdentifier {
405+
if presentedViewController?.view.accessibilityIdentifier == MoreSheetAlert.accessibilityIdentifier {
407406
dismiss(animated: true)
408407
}
409408
}

0 commit comments

Comments
 (0)