Skip to content

Commit 3319f60

Browse files
authored
Reader: Disable recommended tags in Discover (#25018)
* Disable recommended tags in Discover * Update unit tests
1 parent a0a3211 commit 3319f60

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

Sources/WordPressData/Swift/ReaderCard+CoreDataClass.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,7 @@ public class ReaderCard: NSManagedObject {
5454
case .post:
5555
post = ReaderPost.createOrReplace(fromRemotePost: remoteCard.post, for: nil, context: context)
5656
case .interests:
57-
topics = NSOrderedSet(array: remoteCard.interests?.prefix(5).map {
58-
ReaderTagTopic.createOrUpdateIfNeeded(from: $0, context: context)
59-
} ?? [])
57+
return nil // Disabled in v26.6
6058
case .sites:
6159
sites = NSOrderedSet(array: remoteCard.sites?.prefix(3).map {
6260
ReaderSiteTopic.createIfNeeded(from: $0, context: context)

Tests/KeystoneTests/Tests/Models/ReaderCardTests.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,8 @@ class ReaderCardTests: CoreDataTestCase {
3131
let card = ReaderCard(context: self.mainContext, from: remoteCard)
3232
let topics = card?.topicsArray
3333

34-
expect(topics?.count).to(equal(2))
35-
expect(topics?.filter { $0.title == "Activism" }).toNot(beNil())
36-
expect(topics?.filter { $0.slug == "activism" }).toNot(beNil())
34+
// THEN return 0 as these were disabled in 26.5
35+
expect(topics).to(beNil())
3736
expectation.fulfill()
3837
}
3938

WordPress/Classes/ViewRelated/Reader/Cards/ReaderRecommendedTagsCell.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import UIKit
33
import WordPressData
44
import WordPressUI
55

6+
/// - warning: The tags no longer gets shown since v26.6.
67
final class ReaderRecommendedTagsCell: UITableViewCell {
78
private let scrollView = UIScrollView()
89
private let tagsStackView = UIStackView(axis: .horizontal, spacing: 8, insets: UIEdgeInsets(.vertical, 16), [])

0 commit comments

Comments
 (0)