Merge pull request #19740 from wordpress-mobile/fix/site-icon-alert-logic

momo-ozawa · web-flow · commit 37aa9bccb559 · 2022-12-07T11:36:06.000Z
Fix site icon alert logic
diff --git a/WordPress/Classes/ViewRelated/Blog/Site Picker/SitePickerViewController.swift b/WordPress/Classes/ViewRelated/Blog/Site Picker/SitePickerViewController.swift
@@ -84,8 +84,9 @@ extension SitePickerViewController: BlogDetailHeaderViewDelegate {
 
         NoticesDispatch.lock()
 
-        if !FeatureFlag.siteIconCreator.enabled {
+        guard FeatureFlag.siteIconCreator.enabled else {
             showUpdateSiteIconAlert()
+            return
         }
 
         showSiteIconSelectionAlert()

Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,9 @@ extension SitePickerViewController: BlogDetailHeaderViewDelegate {`
`84`	`84`
`85`	`85`	`NoticesDispatch.lock()`
`86`	`86`
`87`		`- if !FeatureFlag.siteIconCreator.enabled {`
	`87`	`+ guard FeatureFlag.siteIconCreator.enabled else {`
`88`	`88`	`showUpdateSiteIconAlert()`
	`89`	`+ return`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`showSiteIconSelectionAlert()`