Add loading indicator when opening deeplinks for reader

Author: kean

WordPress/Classes/System/Root View/ReaderPresenter.swift

@@ -301,6 +301,11 @@ public final class ReaderPresenter: NSObject, SplitViewDisplayable {
         case let .tag(slug):
             viewModel.selection = nil
             show(ReaderStreamViewController.controllerWithTagSlug(slug))
+        case let .siteID(siteID, isFeed):
+            viewModel.selection = nil
+            // Show the stream view controller immediately
+            // It will fetch the topic and show loading/error states as needed
+            show(ReaderStreamViewController.controllerWithSiteID(NSNumber(value: siteID), isFeed: isFeed))
         }
     }
 

WordPress/Classes/Utility/Universal Links/Routes+Reader.swift

@@ -168,28 +168,12 @@ private extension RootViewPresenter {
         }
     }
 
-    /// - warning: This method performs the navigation asyncronously after
-    /// fetching the information about the stream from the backend.
+    /// Shows a Reader stream for the given site/feed ID.
+    ///
+    /// The stream view controller is displayed immediately with a loading state.
+    /// Topic information is fetched asynchronously in the background, and the UI
+    /// updates when the fetch completes or fails.
     func showReaderStream(with siteID: Int, isFeed: Bool) {
-        getSiteTopic(siteID: NSNumber(value: siteID), isFeed: isFeed) { [weak self] topic in
-            guard let topic else { return }
-            self?.showReader(path: .topic(topic))
-        }
-    }
-
-    private func getSiteTopic(siteID: NSNumber, isFeed: Bool, completion: @escaping (ReaderSiteTopic?) -> Void) {
-        let service = ReaderTopicService(coreDataStack: ContextManager.shared)
-        service.siteTopicForSite(withID: siteID, isFeed: isFeed, success: { objectID, isFollowing in
-            guard let objectID,
-                  let topic = try? ContextManager.shared.mainContext.existingObject(with: objectID) as? ReaderSiteTopic else {
-                DDLogError("Reader: Error retriving site topic - invalid Site Id")
-                completion(nil)
-                return
-            }
-            completion(topic)
-        }, failure: { error in
-            DDLogError("Reader: Error retriving site topic - \(error?.localizedDescription ?? "unknown failure reason")")
-            completion(nil)
-        })
+        showReader(path: .siteID(siteID, isFeed: isFeed))
     }
 }

WordPress/Classes/ViewRelated/Reader/Navigation/ReaderNavigationPath.swift

@@ -13,6 +13,7 @@ enum ReaderNavigationPath: Hashable {
     case postURL(URL)
     case topic(ReaderAbstractTopic)
     case tag(String)
+    case siteID(Int, isFeed: Bool)
 }
 
 extension ReaderNavigationPath {