Load Reader lazily

Author: kean

WordPress/Classes/System/ReaderPresenter.swift

@@ -14,7 +14,7 @@ final class ReaderPresenter: NSObject, SplitViewDisplayable {
     var secondary: UINavigationController
 
     /// The navigation controller for the main content when shown using tabs.
-    private let mainNavigationController = UINavigationController()
+    private var mainNavigationController = UINavigationController()
     private var latestContentVC: UIViewController?
 
     private var viewContext: NSManagedObjectContext {
@@ -37,12 +37,14 @@ final class ReaderPresenter: NSObject, SplitViewDisplayable {
 
     // TODO: (reader) update to allow seamless transitions between split view and tabs
     @objc func prepareForTabBarPresentation() -> UINavigationController {
+        sidebar.onViewDidLoad = { [weak self] in
+            self?.showInitialSelection()
+        }
         sidebarViewModel.isCompact = true
         sidebarViewModel.restoreSelection(defaultValue: nil)
         mainNavigationController.navigationBar.prefersLargeTitles = true
-        mainNavigationController.viewControllers = [sidebar]
+        mainNavigationController = UINavigationController(rootViewController: sidebar) // Loads sidebar lazily
         sidebar.navigationItem.backButtonDisplayMode = .minimal
-        showInitialSelection()
         return mainNavigationController
     }
 

WordPress/Classes/ViewRelated/Reader/ReaderSidebarViewController.swift

@@ -9,6 +9,8 @@ final class ReaderSidebarViewController: UIHostingController<AnyView> {
     private var viewContext: NSManagedObjectContext { ContextManager.shared.mainContext }
     var didAppear = false
 
+    var onViewDidLoad: (() -> Void)?
+
     init(viewModel: ReaderSidebarViewModel) {
         self.viewModel = viewModel
         // - warning: The `managedObjectContext` has to be set here in order for
@@ -25,6 +27,12 @@ final class ReaderSidebarViewController: UIHostingController<AnyView> {
         fatalError("init(coder:) has not been implemented")
     }
 
+    override func viewDidLoad() {
+        super.viewDidLoad()
+
+        onViewDidLoad?()
+    }
+
     override func viewWillAppear(_ animated: Bool) {
         super.viewWillAppear(animated)