Fix link tap crash in Reader (#23845)

kean · web-flow · commit 529a886492aa · 2024-12-09T22:13:49.000Z
diff --git a/WordPress/Classes/ViewRelated/Views/WPRichText/WPRichContentView.swift b/WordPress/Classes/ViewRelated/Views/WPRichText/WPRichContentView.swift
@@ -558,7 +558,7 @@ extension WPRichContentView: UIGestureRecognizerDelegate {
         let point = touch.location(in: self)
         let characterIndex = self.layoutManager.characterIndex(for: point, in: self.textContainer, fractionOfDistanceBetweenInsertionPoints: nil)
         // handle tap on link
-        if let linkAttribute = self.attributedText?.attribute(.link, at: characterIndex, effectiveRange: nil) {
+        if let attributedText, characterIndex >= 0 && characterIndex < attributedText.length, let linkAttribute = attributedText.attribute(.link, at: characterIndex, effectiveRange: nil) {
             return linkAttribute is URL
         }
 

Original file line number	Diff line number	Diff line change
`@@ -558,7 +558,7 @@ extension WPRichContentView: UIGestureRecognizerDelegate {`
`558`	`558`	`let point = touch.location(in: self)`
`559`	`559`	`let characterIndex = self.layoutManager.characterIndex(for: point, in: self.textContainer, fractionOfDistanceBetweenInsertionPoints: nil)`
`560`	`560`	`// handle tap on link`
`561`		`- if let linkAttribute = self.attributedText?.attribute(.link, at: characterIndex, effectiveRange: nil) {`
	`561`	`+ if let attributedText, characterIndex >= 0 && characterIndex < attributedText.length, let linkAttribute = attributedText.attribute(.link, at: characterIndex, effectiveRange: nil) {`
`562`	`562`	`return linkAttribute is URL`
`563`	`563`	`}`
`564`	`564`