Remove long-unused Iterable deep links handling (#24487)

* Remove long-unused Iterable deep links handling

See pbMoDN-fd-p2#comment-7311

* Address main-thread sanitizer issue: change tab bar index on main thread

* Push main queue dispatch from show notifications to deep link handler

See comment here
https://github.com/wordpress-mobile/WordPress-iOS/pull/24487/files#r2053393420

* Add assertion failure for deep link without URL

Author: mokagio

Sources/Reader/Reader.entitlements

@@ -6,7 +6,6 @@
 	<array>
 		<string>webcredentials:wordpress.com</string>
 		<string>webcredentials:*.wordpress.com</string>
-		<string>applinks:links.wp.a8cmail.com</string>
 	</array>
 	<key>aps-environment</key>
 	<string>development</string>

WordPress/Classes/System/Root View/WPTabBarController+RootViewPresenter.swift

@@ -1,4 +1,5 @@
 import UIKit
+import WordPressShared
 
 /// `WPTabBarController` is used as the root presenter when Jetpack features are enabled
 /// and the app's UI is normal.
@@ -22,8 +23,11 @@ extension WPTabBarController: RootViewPresenter {
     }
 
     func showNotificationsTab(completion: ((NotificationsViewController) -> Void)?) {
-        self.selectedIndex = WPTab.notifications.rawValue
-        completion?(self.notificationsViewController!)
+        // UITabBarController.selectedIndex must be used from main thread only.
+        wpAssert(Thread.isMainThread)
+
+        selectedIndex = WPTab.notifications.rawValue
+        completion?(notificationsViewController!)
     }
 
     // MARK: Me

WordPress/Classes/System/WordPressAppDelegate.swift

@@ -457,7 +457,9 @@ extension WordPressAppDelegate {
         }
 
         trackDeepLink(for: url) { url in
-            UniversalLinkRouter.shared.handle(url: url)
+            DispatchQueue.main.async {
+                UniversalLinkRouter.shared.handle(url: url)
+            }
         }
     }
 
@@ -473,24 +475,19 @@ extension WordPressAppDelegate {
 extension WordPressAppDelegate {
 
     private func trackDeepLink(for url: URL, completion: @escaping ((URL) -> Void)) {
-        guard isIterableDeepLink(url) else {
-            completion(url)
-            return
-        }
-
-        let task = URLSession.shared.dataTask(with: url) {(_, response, error) in
-            if let url = response?.url {
-                completion(url)
+        let task = URLSession.shared.dataTask(with: url) { _, response, error in
+            guard let url = response?.url else {
+                wpAssertionFailure(
+                    "Received a deep link response without URL attached.",
+                    userInfo: ["response": response ?? "no response"]
+                )
+                return
             }
+
+            completion(url)
         }
         task.resume()
     }
-
-    private func isIterableDeepLink(_ url: URL) -> Bool {
-        return url.absoluteString.contains(WordPressAppDelegate.iterableDomain)
-    }
-
-    private static let iterableDomain = "links.wp.a8cmail.com"
 }
 
 // MARK: - Helpers

WordPress/Jetpack/JetpackDebug.entitlements

@@ -17,7 +17,6 @@
 		<string>applinks:wordpress.com</string>
 		<string>applinks:*.wordpress.com</string>
 		<string>applinks:public-api.wordpress.com</string>
-		<string>applinks:links.wp.a8cmail.com</string>
 	</array>
 	<key>com.apple.security.application-groups</key>
 	<array>

WordPress/Jetpack/JetpackRelease-Alpha.entitlements

@@ -13,7 +13,6 @@
 		<string>applinks:wordpress.com</string>
 		<string>applinks:*.wordpress.com</string>
 		<string>applinks:public-api.wordpress.com</string>
-		<string>applinks:links.wp.a8cmail.com</string>
 	</array>
 	<key>com.apple.security.application-groups</key>
 	<array>

WordPress/Jetpack/JetpackRelease.entitlements

@@ -17,7 +17,6 @@
 		<string>applinks:wordpress.com</string>
 		<string>applinks:*.wordpress.com</string>
 		<string>applinks:public-api.wordpress.com</string>
-		<string>applinks:links.wp.a8cmail.com</string>
 	</array>
 	<key>com.apple.security.application-groups</key>
 	<array>

WordPress/WordPress-Alpha.entitlements

@@ -6,7 +6,6 @@
 	<array>
 		<string>webcredentials:wordpress.com</string>
 		<string>webcredentials:*.wordpress.com</string>
-		<string>applinks:links.wp.a8cmail.com</string>
 	</array>
 	<key>com.apple.security.application-groups</key>
 	<array>

WordPress/WordPress.entitlements

@@ -12,7 +12,6 @@
 	<array>
 		<string>webcredentials:wordpress.com</string>
 		<string>webcredentials:*.wordpress.com</string>
-		<string>applinks:links.wp.a8cmail.com</string>
 	</array>
 	<key>com.apple.developer.icloud-container-identifiers</key>
 	<array>