Skip to content

Commit 74809b5

Browse files
committed
Use PostRepository to fetch all pages in homepage settings
1 parent 8b376bd commit 74809b5

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

WordPress/Classes/ViewRelated/Blog/Site Settings/HomepageSettingsViewController.swift

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -68,25 +68,23 @@ import WordPressShared
6868
ImmuTable.registerRows([CheckmarkRow.self, NavigationItemRow.self, ActivityIndicatorRow.self], tableView: tableView)
6969
reloadViewModel()
7070

71-
fetchAllPages()
72-
}
73-
74-
private func fetchAllPages() {
75-
let options = PostServiceSyncOptions()
76-
options.number = 20
77-
78-
postService.syncPosts(ofType: .page, with: options, for: blog, success: { [weak self] posts in
79-
self?.reloadViewModel()
80-
}, failure: { _ in
81-
82-
})
71+
fetchAllPagesTask = postRepository.fetchAllPages(statuses: [], in: TaggedManagedObjectID(blog))
8372
}
8473

8574
open override func viewWillAppear(_ animated: Bool) {
8675
super.viewWillAppear(animated)
8776
animateDeselectionInteractively()
8877
}
8978

79+
open override func viewDidDisappear(_ animated: Bool) {
80+
super.viewDidDisappear(animated)
81+
82+
if self.navigationController == nil {
83+
fetchAllPagesTask?.cancel()
84+
fetchAllPagesTask = nil
85+
}
86+
}
87+
9088
// MARK: - Model
9189

9290
fileprivate func reloadViewModel() {

0 commit comments

Comments
 (0)