Skip to content

Commit 7876b10

Browse files
committed
Add Jetpack banner to Jetpack Backups view.
1 parent a37dd79 commit 7876b10

File tree

4 files changed

+29
-1
lines changed

4 files changed

+29
-1
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import Foundation
2+
3+
@objc
4+
extension BackupListViewController {
5+
static func withJPBannerForBlog(_ blog: Blog) -> UIViewController? {
6+
guard let backupListVC = BackupListViewController(blog: blog) else {
7+
return nil
8+
}
9+
return JetpackBannerWrapperViewController(childVC: backupListVC)
10+
}
11+
}
12+
13+
extension BackupListViewController: JPScrollViewDelegate {
14+
override func scrollViewDidScroll(_ scrollView: UIScrollView) {
15+
super.scrollViewDidScroll(scrollView)
16+
processJetpackBannerVisibility(scrollView)
17+
}
18+
}

WordPress/Classes/ViewRelated/Activity/Backup/BackupListViewController.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import Foundation
2+
import Combine
23

34
class BackupListViewController: BaseActivityListViewController {
5+
/// Needed for JPScrollViewDelegate conformance.
6+
let scrollViewTranslationPublisher = PassthroughSubject<Bool, Never>()
7+
48
override init(site: JetpackSiteRef, store: ActivityStore, isFreeWPCom: Bool = false) {
59
store.onlyRestorableItems = true
610

WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1585,7 +1585,7 @@ - (void)showScan
15851585

15861586
- (void)showBackup
15871587
{
1588-
BackupListViewController *controller = [[BackupListViewController alloc] initWithBlog:self.blog];
1588+
UIViewController *controller = [BackupListViewController withJPBannerForBlog:self.blog];
15891589
controller.navigationItem.largeTitleDisplayMode = UINavigationItemLargeTitleDisplayModeNever;
15901590
[self.presentationDelegate presentBlogDetailsViewController:controller];
15911591
}

WordPress/WordPress.xcodeproj/project.pbxproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2608,6 +2608,8 @@
26082608
C395FB262821FE7B00AE7C11 /* RemoteSiteDesign+Thumbnail.swift in Sources */ = {isa = PBXBuildFile; fileRef = C395FB252821FE7B00AE7C11 /* RemoteSiteDesign+Thumbnail.swift */; };
26092609
C395FB272822148400AE7C11 /* RemoteSiteDesign+Thumbnail.swift in Sources */ = {isa = PBXBuildFile; fileRef = C395FB252821FE7B00AE7C11 /* RemoteSiteDesign+Thumbnail.swift */; };
26102610
C396C80B280F2401006FE7AC /* SiteDesignTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = C396C80A280F2401006FE7AC /* SiteDesignTests.swift */; };
2611+
C39ABBAE294BE84000F6F278 /* BackupListViewController+JetpackBannerViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = C39ABBAD294BE84000F6F278 /* BackupListViewController+JetpackBannerViewController.swift */; };
2612+
C39ABBAF294BE84000F6F278 /* BackupListViewController+JetpackBannerViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = C39ABBAD294BE84000F6F278 /* BackupListViewController+JetpackBannerViewController.swift */; };
26112613
C3AB4879292F114A001F7AF8 /* UIApplication+AppAvailability.swift in Sources */ = {isa = PBXBuildFile; fileRef = C3AB4878292F114A001F7AF8 /* UIApplication+AppAvailability.swift */; };
26122614
C3C21EB928385EC8002296E2 /* RemoteSiteDesigns.swift in Sources */ = {isa = PBXBuildFile; fileRef = C3C21EB828385EC8002296E2 /* RemoteSiteDesigns.swift */; };
26132615
C3C21EBA28385EC8002296E2 /* RemoteSiteDesigns.swift in Sources */ = {isa = PBXBuildFile; fileRef = C3C21EB828385EC8002296E2 /* RemoteSiteDesigns.swift */; };
@@ -7734,6 +7736,7 @@
77347736
C395FB222821FE4400AE7C11 /* SiteDesignSection.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SiteDesignSection.swift; sourceTree = "<group>"; };
77357737
C395FB252821FE7B00AE7C11 /* RemoteSiteDesign+Thumbnail.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "RemoteSiteDesign+Thumbnail.swift"; sourceTree = "<group>"; };
77367738
C396C80A280F2401006FE7AC /* SiteDesignTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SiteDesignTests.swift; sourceTree = "<group>"; };
7739+
C39ABBAD294BE84000F6F278 /* BackupListViewController+JetpackBannerViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "BackupListViewController+JetpackBannerViewController.swift"; sourceTree = "<group>"; };
77377740
C3AB4878292F114A001F7AF8 /* UIApplication+AppAvailability.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIApplication+AppAvailability.swift"; sourceTree = "<group>"; };
77387741
C3ABE791263099F7009BD402 /* WordPress 121.xcdatamodel */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcdatamodel; path = "WordPress 121.xcdatamodel"; sourceTree = "<group>"; };
77397742
C3C21EB828385EC8002296E2 /* RemoteSiteDesigns.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RemoteSiteDesigns.swift; sourceTree = "<group>"; };
@@ -12930,6 +12933,7 @@
1293012933
isa = PBXGroup;
1293112934
children = (
1293212935
8B36256525A60CCA00D7CCE3 /* BackupListViewController.swift */,
12936+
C39ABBAD294BE84000F6F278 /* BackupListViewController+JetpackBannerViewController.swift */,
1293312937
);
1293412938
path = Backup;
1293512939
sourceTree = "<group>";
@@ -21578,6 +21582,7 @@
2157821582
08A4E129289D202F001D9EC7 /* UserPersistentStore.swift in Sources */,
2157921583
E1D95EB817A28F5E00A3E9F3 /* WPActivityDefaults.m in Sources */,
2158021584
436D56302117410C00CEAA33 /* RegisterDomainDetailsViewModel+CellIndex.swift in Sources */,
21585+
C39ABBAE294BE84000F6F278 /* BackupListViewController+JetpackBannerViewController.swift in Sources */,
2158121586
1714F8D020E6DA8900226DCB /* RouteMatcher.swift in Sources */,
2158221587
591A428F1A6DC6F2003807A6 /* WPGUIConstants.m in Sources */,
2158321588
3FD272E024CF8F270021F0C8 /* UIColor+Notice.swift in Sources */,
@@ -24059,6 +24064,7 @@
2405924064
FABB253A2602FC2C00C8785C /* WordPressAppDelegate.swift in Sources */,
2406024065
098B8577275E9765004D299F /* AppLocalizedString.swift in Sources */,
2406124066
FABB253B2602FC2C00C8785C /* MediaService.m in Sources */,
24067+
C39ABBAF294BE84000F6F278 /* BackupListViewController+JetpackBannerViewController.swift in Sources */,
2406224068
FEA6517C281C491C002EA086 /* BloggingPromptsService.swift in Sources */,
2406324069
FABB253C2602FC2C00C8785C /* FormattableContentAction.swift in Sources */,
2406424070
3F3DD0B326FD176800F5F121 /* PresentationCard.swift in Sources */,

0 commit comments

Comments
 (0)