Use loadObject instead of existingObject(with:)

crazytonyli · crazytonyli · commit 7c2957088091 · 2023-05-30T14:49:35.000+12:00
So that we can catch an `NSInvalidArgumentException` Objective-C exception. See #20630
diff --git a/WordPress/Classes/ViewRelated/Gutenberg/EditorMediaUtility.swift b/WordPress/Classes/ViewRelated/Gutenberg/EditorMediaUtility.swift
@@ -31,7 +31,7 @@ final class AuthenticatedImageDownload: AsyncOperation {
                     throw DownloadError.blogNotFound
                 }
 
-                let blog = try context.existingObject(with: self.blogObjectID) as! Blog
+                let blog = try context.loadObject(ofType: Blog.self, with: self.blogObjectID)
                 return MediaHost(with: blog) { error in
                     // We'll log the error, so we know it's there, but we won't halt execution.
                     WordPressAppDelegate.crashLogging?.logError(error)

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ final class AuthenticatedImageDownload: AsyncOperation {`
`31`	`31`	`throw DownloadError.blogNotFound`
`32`	`32`	`}`
`33`	`33`
`34`		`- let blog = try context.existingObject(with: self.blogObjectID) as! Blog`
	`34`	`+ let blog = try context.loadObject(ofType: Blog.self, with: self.blogObjectID)`
`35`	`35`	`return MediaHost(with: blog) { error in`
`36`	`36`	`// We'll log the error, so we know it's there, but we won't halt execution.`
`37`	`37`	`WordPressAppDelegate.crashLogging?.logError(error)`