Remove .newPublishingSheet FF (#24912)

* Remove .newPublishingSheet FF

* Remove PrepublishingHeaderView

* Move Blog+title extension

* Remove more stuff

* Remove publish_v2

Author: kean

Sources/WordPressData/Blog+Extensions.swift

@@ -4,6 +4,14 @@ import WordPressShared
 
 extension Blog {
 
+    /// The title of the blog
+    public var title: String? {
+        guard let blogName = settings?.name, !blogName.isEmpty else {
+            return displayURL as String?
+        }
+        return blogName
+    }
+
     // MARK: - Post Formats
 
     /// Returns an array of post format keys sorted with "standard" first, then alphabetically

Tests/KeystoneTests/Tests/Services/PostCoordinatorTests.swift

@@ -407,7 +407,7 @@ class PostCoordinatorTests: CoreDataTestCase {
         await fulfillment(of: [expectation], timeout: 2)
 
         // WHEN
-        try await coordinator.publish(post, options: .init(visibility: .public, password: nil, publishDate: nil))
+        try await coordinator.publish(post)
 
         // THEN the coordinator wait for the sync to complete and the post to
         // be created and only then sends a parial update to get it published
@@ -462,7 +462,7 @@ class PostCoordinatorTests: CoreDataTestCase {
         }
 
         // WHEN
-        try await coordinator.publish(post, options: .init(visibility: .public, password: nil, publishDate: nil))
+        try await coordinator.publish(post)
 
         // THEN
         XCTAssertEqual(post.publicizeMessage, "message-a")

WordPress/Classes/Services/PostCoordinator.swift

@@ -73,61 +73,6 @@ class PostCoordinator: NSObject {
         NotificationCenter.default.addObserver(self, selector: #selector(didUpdateReachability), name: .reachabilityUpdated, object: nil)
     }
 
-    struct PublishingOptions {
-        var visibility: PostVisibility
-        var password: String?
-        var publishDate: Date?
-
-        init(visibility: PostVisibility, password: String?, publishDate: Date?) {
-            self.visibility = visibility
-            self.password = password
-            self.publishDate = publishDate
-        }
-    }
-
-    /// Publishes the post according to the current settings and user capabilities.
-    ///
-    /// - warning: Before publishing, ensure that the media for the post got
-    /// uploaded. Managing media is not the responsibility of `PostRepository.`
-    @MainActor
-    func publish(_ post: AbstractPost, options: PublishingOptions) async throws {
-        wpAssert(post.isOriginal())
-        wpAssert(post.isStatus(in: [.draft, .pending]))
-
-        await pauseSyncing(for: post)
-        defer { resumeSyncing(for: post) }
-
-        var parameters = RemotePostUpdateParameters()
-        switch options.visibility {
-        case .public, .protected:
-            parameters.status = Post.Status.publish.rawValue
-        case .private:
-            parameters.status = Post.Status.publishPrivate.rawValue
-        }
-        let latest = post.latest()
-        if (latest.password ?? "") != (options.password ?? "") {
-            parameters.password = options.password
-        }
-        if let publishDate = options.publishDate {
-            parameters.date = publishDate
-        } else {
-            // If the post was previously scheduled for a different date,
-            // the app has to send a new value to override it.
-            parameters.date = post.shouldPublishImmediately() ? nil : Date()
-        }
-
-        do {
-            let repository = PostRepository(coreDataStack: coreDataStack)
-            try await repository.save(post, changes: parameters)
-            didPublish(post)
-            show(PostCoordinator.makeUploadSuccessNotice(for: post))
-        } catch {
-            trackError(error, operation: "post-publish", post: post)
-            handleError(error, for: post)
-            throw error
-        }
-    }
-
     /// Publishes the post according to the current settings and user capabilities.
     ///
     /// - warning: Before publishing, ensure that the media for the post got
@@ -136,7 +81,7 @@ class PostCoordinator: NSObject {
     /// - parameter changes: The set of changes apply to the post together
     /// with the publishing options.
     @MainActor
-    func publish_v2(_ post: AbstractPost, parameters: RemotePostUpdateParameters) async throws {
+    func publish(_ post: AbstractPost, parameters: RemotePostUpdateParameters = .init()) async throws {
         wpAssert(post.isOriginal())
         wpAssert(post.isStatus(in: [.draft, .pending]))
 

WordPress/Classes/Utility/BuildInformation/FeatureFlag.swift

@@ -25,7 +25,6 @@ public enum FeatureFlag: Int, CaseIterable {
     case readerGutenbergCommentComposer
     case pluginManagementOverhaul
     case newStats
-    case newPublishingSheet
     case mediaQuotaView
     case intelligence
 
@@ -82,8 +81,6 @@ public enum FeatureFlag: Int, CaseIterable {
             return false
         case .newStats:
             return false
-        case .newPublishingSheet:
-            return true
         case .mediaQuotaView:
             return false
         case .intelligence:
@@ -131,7 +128,6 @@ extension FeatureFlag {
         case .pluginManagementOverhaul: "Plugin Management Overhaul"
         case .readerGutenbergCommentComposer: "Gutenberg Comment Composer"
         case .newStats: "New Stats"
-        case .newPublishingSheet: "New Publishing Sheet"
         case .mediaQuotaView: "Media Quota"
         case .intelligence: "Intelligence"
         }

WordPress/Classes/Utility/SiteDateFormatters.swift

@@ -654,7 +654,7 @@ class AbstractPostListViewController: UIViewController,
 
     func publish(_ post: AbstractPost) {
         WPAnalytics.track(.postListPublishAction, withProperties: propertiesForAnalytics())
-        PrepublishingViewController.show(for: post, isStandalone: true, from: self) { [weak self] result in
+        PublishPostViewController.show(for: post, isStandalone: true, from: self) { [weak self] result in
             switch result {
             case .published:
                 self?.dismiss(animated: true)

WordPress/Classes/ViewRelated/Post/Controllers/AbstractPostListViewController.swift

@@ -108,7 +108,7 @@ extension PublishingEditor {
 
     private func showPublishingConfirmation(for action: PostEditorAction, analyticsStat: WPAnalyticsStat?) {
         let originalFeaturedImageID = post.featuredImage?.mediaID
-        PrepublishingViewController.show(for: post, from: self) { [weak self] result in
+        PublishPostViewController.show(for: post, from: self) { [weak self] result in
             guard let self else { return }
             switch result {
             case .published:

WordPress/Classes/ViewRelated/Post/PostEditor+Publish.swift

@@ -307,7 +307,7 @@ final class PostSettingsViewModel: NSObject, ObservableObject {
             do {
                 let coordinator = PostCoordinator.shared
                 let changes = settings.makeUpdateParameters(from: post)
-                try await coordinator.publish_v2(post.original(), parameters: changes)
+                try await coordinator.publish(post.original(), parameters: changes)
                 onPostPublished?()
             } catch {
                 isSaving = false