Commit bcb3e07
authored
Feature: Jetpack Activity Logs (#24597)
* Add PaginatedResponse
* Refactor PaginatedResponse to DataViewPaginatedResponse
- Rename PaginatedResponse to DataViewPaginatedResponse for better naming consistency
- Move files from Pagination to DataView directory
- Update documentation to focus on UI usage with PaginatedForEach
- Add comprehensive unit tests for DataViewPaginatedResponse
* Fix deleteItem to update total count
- Update deleteItem method to properly decrement total when removing items
- Update tests to verify total count is correctly maintained after deletion
* Rename LoadMoreFooterView
* Add DataViewPaginatedForEach component
* Add DataViewPaginatedResponseProtocol
* Refactor subscribers to use DataViewPaginatedResponse
Replace custom SubscribersPaginatedResponse with generic DataViewPaginatedResponse system. Add notification-based subscriber deletion updates and improve pagination handling with DataViewPaginatedForEach component.
* Refactor subscribers service creation and move deleteSubscriber extension
- Rename getSubscribersService() to maketSubscribersService() to better reflect factory pattern
- Move deleteSubscriber extension from SubsriberDetailsViewModel to dedicated SubscribersServiceRemote+Extensions file
- Update all callers to use the renamed method
* Fix typo in Subscriber
* Fix formatting
* Fix typos and address comments
* Implement new Jetpack Activity Logs screen
* Fix SwiftLint warnings
* Add Miniature app
* Add XcodeTarget_App as a dependency
* Configure xcconfig (just use Reader)
* Add initial ActivityLogDetailsView
* Add ActivityLogDetailsView to Miniature target
- Implement modern SwiftUI version of Activity Detail screen
- Use card-based design system matching SubscriberDetailsView
- Add proper localization with NSLocalizedString and reverse-DNS keys
- Use WPStyleGuide for consistent icon and color handling
- Include activity stats visualization for backup events
- Add restore and download backup actions with confirmation dialogs
- Integrate with existing Activity model and RewindStatus
- Update ContentView with navigation links for testing
- Configure MiniatureApp with proper navigation and theming
* Extract Activity icon methods from WPStyleGuide to Activity extension
- Create Activity+Icon.swift with gridiconType, icon, and statusColor properties
- Update all references to use new Activity extension methods
- Deprecate old WPStyleGuide methods with proper deprecation messages
- Remove stringToGridiconTypeMapping from WPStyleGuide
- Fix linter warnings for trailing whitespace and shorthand optional binding
* Remove rewindStatus parameter from ActivityLogDetailsView
- Remove rewindStatus parameter from ActivityLogDetailsView initializer
- Remove rewindStatus checks in ActivityActionsCard
- Update preview providers to not pass rewindStatus
- Update ContentView to not create mock RewindStatus instances
- Remove warning card for multisite installations
- Simplify restore button enable/disable logic
* Dev
* Add formattedContent
* Move the code to the main target
* Extract reusable ActivityActorAvatarView
* Remove unused code and integrate ActivityLogDetailsView
* Fix SwiftLint warnings
* Add initial restore/download backup code
* Remove JetpackSiteRef usages
* Add multisite handling
* Remove the new screens and use the existing flows
* Add analytics
* Cleanup
* Add missing analytics
* Cleanup
* Fix an issue with not all restorable acitivies shown in backups
* Fix an issue with restore/download flow layout
* Show restore checkpoint in section
* Extract reusable CardView and InfoRow components from SubscribersDetailsVIew
* Cleanup
* Add rewindable
* Move restore buttons higher
* Add date filtering back
* Add Backup tracking
* Fix clear background in restore flows
* Rework how we do polling
* Rework how we manage backup statuss
* Revert hasBackup change
* Update tests
* Update release notes
* Remove unused code
* Cleanup
* Remove Application from list
* Remove BackupListViewController and use ActivityLogsViewController instead
- Delete BackupListViewController.swift and its extension
- Update showBackup() to use ActivityLogsViewController with isBackupMode
- Remove BackupListViewController reference from ActivityDetailViewController
- Implement displayBackupWithSiteID using ActivityLogsViewController
- Add WPAnalytics tracking to ContentCoordinator backup display
* Remove JetpackActivityLogViewController and use ActivityLogsViewController
- Delete JetpackActivityLogViewController.swift
- Update showActivity() methods to use ActivityLogsViewController directly
- Update ActivityDetailViewController to check for ActivityLogsViewController
- Simplify DashboardActivityLogCardCell to use ActivityLogsViewController
* Remove dataViews feature flag
- Remove dataViews case from FeatureFlag enum
- Remove dataViews from enabled property switch statement
- Remove dataViews description
The feature flag was already removed from usage in previous commits
where we removed JetpackActivityLogViewController and BackupListViewController.
* Create separate BackupsViewController and remove isBackupMode from ActivityLogsViewController
- Create new BackupsViewController and BackupsView that reuses ActivityLogsView
- Remove isBackupMode parameter from ActivityLogsViewController
- Update all usages to use BackupsViewController for backups
- Update ActivityDetailViewController to recognize BackupsViewController presenter
- Keep ActivityLogsView and ActivityLogsViewModel unchanged as implementation details
* Remove ActivityListViewModelTests
* Remove ActivityTypeSelectorViewController
* Remove ActivityListViewModel
* Remove BaseActivityListViewController
* Fix compilation
* Remove RewindStatusRow
* Remove RewindStatusTableViewCell
* Remove ActivityListRow
* Remove ActivityTableViewCell
* Remove CalendarViewController
* Remove JTAppleCalendar dependency
* Remove FilterBarView
* Remove FilterChipButton
* Remove ActivityDetailViewController
* Remove ActivityStore usages
* Remove ActivityStoreTests
* Fix how isAwaitingCredentials works
* Remove ActivityStore
* Integrate ActivityContentRouter and FormattableActivity
* Update filter icon
* Update filters icon
* Remove WPStyleGuide+Activity and fix an issue with ActivityFormattableContentView layout
* Fix layout of ActivityFormattableContentView
* Add placeholders for empty fields
* Remove build instructions from CLAUDE.md
* Add more instructions for CLAUDE
* Handle a scenario where logs are from existing user
* Remove obsolete tests
* Update UI tests
* Fix release build
* Use Duration
* Simplify CardView
* Add TODO for iOS 17
* Move state change to onAppear1 parent 906aa9b commit bcb3e07
File tree
91 files changed
+3673
-4980
lines changed- .claude
- Modules
- Sources
- BuildSettingsKit
- UITestsFoundation/Screens
- WordPressUI/Views
- DataView
- Tests/WordPressUIUnitTests
- DataView
- Extensions
- Sources/Miniature
- Assets.xcassets
- AccentColor.colorset
- AppIcon.appiconset
- Tests
- KeystoneTests/Tests
- Features
- Activity
- Dashboard
- Posts
- Stores
- Utility
- MiniatureTests
- WordPress
- Classes
- Extensions
- Stores
- Utility
- BuildInformation
- ViewRelated
- Activity
- Backup
- Details
- Extensions
- Filter
- FormattableContent
- List
- Blog
- Blog Dashboard/Cards/Activity Log
- Blog Details
- Subscribers
- Details
- Helpers
- Invite
- List
- Jetpack/Jetpack Restore
- Restore Complete
- Restore Status
- Restore Warning
- Post/Scheduling
- WordPress.xcodeproj
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
91 files changed
+3673
-4980
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | 11 | | |
24 | 12 | | |
25 | 13 | | |
| |||
54 | 42 | | |
55 | 43 | | |
56 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
57 | 48 | | |
58 | | - | |
| 49 | + | |
59 | 50 | | |
60 | 51 | | |
61 | 52 | | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | 40 | | |
42 | 41 | | |
43 | 42 | | |
| |||
50 | 49 | | |
51 | 50 | | |
52 | 51 | | |
53 | | - | |
| 52 | + | |
54 | 53 | | |
55 | 54 | | |
56 | 55 | | |
| |||
300 | 299 | | |
301 | 300 | | |
302 | 301 | | |
303 | | - | |
304 | 302 | | |
305 | 303 | | |
306 | 304 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
Lines changed: 4 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | 5 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
28 | 9 | | |
29 | 10 | | |
30 | 11 | | |
31 | 12 | | |
32 | 13 | | |
33 | | - | |
| 14 | + | |
34 | 15 | | |
35 | 16 | | |
36 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
Lines changed: 35 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
Lines changed: 122 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
0 commit comments