Skip to content

Commit c0e9670

Browse files
committed
Update GBK
1 parent 338a68c commit c0e9670

File tree

9 files changed

+15
-152
lines changed

9 files changed

+15
-152
lines changed

Modules/Package.resolved

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Modules/Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ let package = Package(
5454
.package(url: "https://github.com/wordpress-mobile/wpxmlrpc", from: "0.9.0"),
5555
.package(url: "https://github.com/wordpress-mobile/NSURL-IDN", revision: "b34794c9a3f32312e1593d4a3d120572afa0d010"),
5656
.package(url: "https://github.com/zendesk/support_sdk_ios", from: "8.0.3"),
57-
.package(url: "https://github.com/wordpress-mobile/GutenbergKit", from: "0.10.1"),
57+
.package(url: "https://github.com/wordpress-mobile/GutenbergKit", revision: "b92735b3647e039e01f06dfe84afdc4074902861"),
5858
// We can't use wordpress-rs branches nor commits here. Only tags work.
5959
.package(url: "https://github.com/Automattic/wordpress-rs", revision: "alpha-20251101"),
6060
.package(

WordPress/Classes/Services/BlockEditorCache.swift

Lines changed: 0 additions & 50 deletions
This file was deleted.

WordPress/Classes/Services/RawBlockEditorSettingsService.swift

Lines changed: 0 additions & 58 deletions
This file was deleted.

WordPress/Classes/Utility/AccountHelper.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,6 @@ import WordPressData
111111
// This is best-effort for now – eventually all of this should be async
112112
Task {
113113
do {
114-
// Delete all cached block editor settings
115-
try await BlockEditorCache.shared.deleteAll()
116-
117114
// Delete everything in the disk cache
118115
try await DiskCache().removeAll()
119116
} catch {

WordPress/Classes/Utility/Editor/EditorConfiguration+Blog.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ extension EditorConfiguration {
6161
}
6262

6363
editorAssetsEndpoint.appendPathComponent("editor-assets")
64-
builder = builder.setEditorAssetsEndpoint(editorAssetsEndpoint)
64+
builder = builder.setEditorAssetsEndpoint(editorAssetsEndpoint.appending(queryItems: [
65+
URLQueryItem(name: "exclude", value: "core,gutenberg")
66+
]))
6567
}
6668
}
6769

WordPress/Classes/ViewRelated/Blog/My Site/MySiteViewController.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,6 @@ final class MySiteViewController: UIViewController, UIScrollViewDelegate, NoSite
357357

358358
let configuration = EditorConfiguration(blog: blog)
359359
GutenbergKit.EditorViewController.warmup(configuration: configuration)
360-
361-
RawBlockEditorSettingsService(blog: blog).prefetchSettings()
362360
}
363361

364362
// MARK: - Main Blog

WordPress/Classes/ViewRelated/Comments/Controllers/Editor/CommentGutenbergEditorViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ extension CommentGutenbergEditorViewController: GutenbergKit.EditorViewControlle
8989
// Do nothing
9090
}
9191

92-
func editor(_ viewController: GutenbergKit.EditorViewController, didLogMessage message: String, level: GutenbergKit.LogLevel) {
92+
func editor(_ viewController: GutenbergKit.EditorViewController, didLogMessage message: String, level: GutenbergKit.EditorLogLevel) {
9393
// Do nothing
9494
}
9595

WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift

Lines changed: 8 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
5353
}
5454

5555
struct EditorDependencies {
56-
let settings: String?
5756
let didLoadCookies: Bool
5857
}
5958

@@ -100,14 +99,6 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
10099

101100
let navigationBarManager: PostEditorNavigationBarManager
102101

103-
// MARK: - Private variables
104-
105-
// TODO: reimplemet
106-
// internal private(set) var contentInfo: ContentInfo?
107-
lazy var editorSettingsService: BlockEditorSettingsService? = {
108-
BlockEditorSettingsService(blog: post.blog, coreDataStack: ContextManager.shared)
109-
}()
110-
111102
// MARK: - GutenbergKit
112103

113104
private var editorViewController: GutenbergKit.EditorViewController
@@ -147,8 +138,6 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
147138
func setHTML(_ html: String) {}
148139
func getHTML() -> String { post.content ?? "" }
149140

150-
private let blockEditorSettingsService: RawBlockEditorSettingsService
151-
152141
// MARK: - Initializers
153142
required convenience init(
154143
post: AbstractPost,
@@ -190,8 +179,6 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
190179
mediaPicker: MediaPickerController(blog: post.blog)
191180
)
192181

193-
self.blockEditorSettingsService = RawBlockEditorSettingsService(blog: post.blog)
194-
195182
super.init(nibName: nil, bundle: nil)
196183

197184
self.editorViewController.delegate = self
@@ -269,7 +256,7 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
269256
case .loadingDependencies: preconditionFailure("Dependencies should not still be loading")
270257
case .loadingCancelled: preconditionFailure("Dependency loading should not be cancelled")
271258
case .dependencyError(let error): self.showEditorError(error)
272-
case .dependenciesReady(let dependencies): try await self.startEditor(settings: dependencies.settings)
259+
case .dependenciesReady(let dependencies): try await self.startEditor()
273260
case .started: preconditionFailure("The editor should not already be started")
274261
}
275262
} catch {
@@ -385,23 +372,18 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
385372
}
386373

387374
self.editorState = .loadingDependencies(Task {
388-
do {
389-
let dependencies = try await fetchEditorDependencies()
390-
self.editorState = .dependenciesReady(dependencies)
391-
} catch {
392-
self.editorState = .dependencyError(error)
393-
}
375+
let dependencies = await fetchEditorDependencies()
376+
self.editorState = .dependenciesReady(dependencies)
394377
})
395378
}
396379

397380
@MainActor
398-
func startEditor(settings: String?) async throws {
381+
func startEditor() async throws {
399382
guard case .dependenciesReady = self.editorState else {
400383
preconditionFailure("`startEditor` should only be called when the editor is in the `.dependenciesReady` state.")
401384
}
402385

403386
let updatedConfiguration = self.editorViewController.configuration.toBuilder()
404-
.apply(settings) { $0.setEditorSettings($1) }
405387
.setTitle(post.postTitle ?? "")
406388
.setContent(post.content ?? "")
407389
.setNativeInserterEnabled(FeatureFlag.nativeBlockInserter.enabled)
@@ -481,18 +463,11 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
481463
}
482464

483465
// MARK: - Editor Setup
484-
private func fetchEditorDependencies() async throws -> EditorDependencies {
485-
let settings: String?
486-
do {
487-
settings = try await blockEditorSettingsService.getSettingsString(allowingCachedResponse: true)
488-
} catch {
489-
DDLogError("Failed to fetch editor settings: \(error)")
490-
settings = nil
491-
}
492466

467+
// TODO: refactor
468+
private func fetchEditorDependencies() async -> EditorDependencies {
493469
let loaded = await loadAuthenticationCookiesAsync()
494-
495-
return EditorDependencies(settings: settings, didLoadCookies: loaded)
470+
return EditorDependencies(didLoadCookies: loaded)
496471
}
497472

498473
private func loadAuthenticationCookiesAsync() async -> Bool {
@@ -573,7 +548,7 @@ extension NewGutenbergViewController: GutenbergKit.EditorViewControllerDelegate
573548
}
574549
}
575550

576-
func editor(_ viewController: GutenbergKit.EditorViewController, didLogMessage message: String, level: GutenbergKit.LogLevel) {
551+
func editor(_ viewController: GutenbergKit.EditorViewController, didLogMessage message: String, level: GutenbergKit.EditorLogLevel) {
577552
// Do nothing
578553
}
579554

0 commit comments

Comments
 (0)