Merge pull request #21034 from wordpress-mobile/ui-tests-fix-save-password-prompt

[UI Tests] Disable Auto Fill Passwords for UI Tests

Author: jostnes

WordPress/UITests/Utils/XCTest+Extensions.swift

@@ -8,6 +8,9 @@ extension XCTestCase {
         removeBeforeLaunching: Bool = false,
         crashOnCoreDataConcurrencyIssues: Bool = true
     ) {
+        // To avoid handling 'Save Password' prompts after login.
+        disableAutoFillPasswords()
+
         // To ensure that the test starts with a new simulator launch each time
         app.terminate()
         super.setUp()
@@ -32,6 +35,24 @@ extension XCTestCase {
         systemAlertHandler(alertTitle: "“WordPress” Would Like to Access Your Photos", alertButton: alertButtonTitle)
     }
 
+    public func disableAutoFillPasswords() {
+        let settings = XCUIApplication(bundleIdentifier: "com.apple.Preferences")
+        settings.activate()
+        settings.staticTexts["Passwords"].tap()
+
+        let enterPasscodeScreen = XCUIApplication(bundleIdentifier: "com.apple.springboard")
+        enterPasscodeScreen.secureTextFields["Passcode field"].typeText(" ")
+        enterPasscodeScreen.buttons["done"].tap()
+
+        settings.staticTexts["Password Options"].tap()
+
+        let autoFillPasswordsSwitch = settings.switches["AutoFill Passwords"]
+        if autoFillPasswordsSwitch.value as? String == "1" {
+            autoFillPasswordsSwitch.tap()
+        }
+        settings.terminate()
+    }
+
     public func takeScreenshotOfFailedTest() {
         guard let failuresCount = testRun?.failureCount, failuresCount > 0 else { return }
 

WordPress/UITestsFoundation/Screens/Login/LoginUsernamePasswordScreen.swift

@@ -82,8 +82,6 @@ public class LoginUsernamePasswordScreen: ScreenObject {
             passwordTextField.typeText(password)
         }
         nextButton.tap()
-
-        app.dismissSavePasswordPrompt()
     }
 
     private func dismissQuickStartPromptIfNeeded() throws {

WordPress/UITestsFoundation/Screens/Login/Unified/PasswordScreen.swift

@@ -58,7 +58,6 @@ public class PasswordScreen: ScreenObject {
 
         passwordTextField.typeText(password)
         continueButton.tap()
-        app.dismissSavePasswordPrompt()
     }
 
     @discardableResult

WordPress/UITestsFoundation/Screens/Login/Unified/PrologueScreen.swift

@@ -24,8 +24,6 @@ public class PrologueScreen: ScreenObject {
     public func selectContinue() throws -> GetStartedScreen {
         continueButton.tap()
 
-        app.dismissSavePasswordPrompt()
-
         return try GetStartedScreen()
     }