Merge pull request #19698 from wordpress-mobile/release/21.3

Merge 21.3 changes between first & second beta to trunk

Author: oguzkocer

Podfile

@@ -179,7 +179,7 @@ abstract_target 'Apps' do
   ## Gutenberg (React Native)
   ## =====================
   ##
-  gutenberg tag: 'v1.85.0'
+  gutenberg tag: 'v1.85.1'
 
   ## Third party libraries
   ## =====================

Podfile.lock

@@ -0,0 +1,15 @@
+import Foundation
+
+enum AppScheme: String {
+    case wordpress = "wordpress://"
+    case wordpressMigrationV1 = "wordpressmigration+v1://"
+}
+
+extension UIApplication {
+    func canOpen(app: AppScheme) -> Bool {
+        guard let url = URL(string: app.rawValue) else {
+            return false
+        }
+        return canOpenURL(url)
+    }
+}

WordPress/Classes/Extensions/UIApplication+AppAvailability.swift

@@ -11,12 +11,14 @@ protocol JetpackNotificationMigrationServiceProtocol {
 final class JetpackNotificationMigrationService: JetpackNotificationMigrationServiceProtocol {
     private let remoteNotificationRegister: RemoteNotificationRegister
     private let featureFlagStore: RemoteFeatureFlagStore
+    private let userDefaults: UserDefaults
     private let isWordPress: Bool
 
     static let shared = JetpackNotificationMigrationService()
 
     static let wordPressScheme = "wordpressnotificationmigration"
     static let jetpackScheme = "jetpacknotificationmigration"
+    private let wordPressNotificationsToggledDefaultsKey = "wordPressNotificationsToggledDefaultsKey"
     private let jetpackNotificationMigrationDefaultsKey = "jetpackNotificationMigrationDefaultsKey"
 
     private var jetpackMigrationPreventDuplicateNotifications: Bool {
@@ -38,6 +40,8 @@ final class JetpackNotificationMigrationService: JetpackNotificationMigrationSer
         }
 
         set {
+            userDefaults.set(true, forKey: wordPressNotificationsToggledDefaultsKey)
+
             if newValue, isWordPress {
                 remoteNotificationRegister.registerForRemoteNotifications()
                 rescheduleLocalNotifications()
@@ -63,18 +67,20 @@ final class JetpackNotificationMigrationService: JetpackNotificationMigrationSer
     /// disableWordPressNotificationsFromJetpack may get triggered multiple times from Jetpack app but it only needs to be executed the first time
     private var isMigrationDone: Bool {
         get {
-            return UserDefaults.standard.bool(forKey: jetpackNotificationMigrationDefaultsKey)
+            return userDefaults.bool(forKey: jetpackNotificationMigrationDefaultsKey)
         }
         set {
-            UserDefaults.standard.setValue(newValue, forKey: jetpackNotificationMigrationDefaultsKey)
+            userDefaults.setValue(newValue, forKey: jetpackNotificationMigrationDefaultsKey)
         }
     }
 
     init(remoteNotificationRegister: RemoteNotificationRegister = UIApplication.shared,
          featureFlagStore: RemoteFeatureFlagStore = RemoteFeatureFlagStore(),
+         userDefaults: UserDefaults = .standard,
          isWordPress: Bool = AppConfiguration.isWordPress) {
         self.remoteNotificationRegister = remoteNotificationRegister
         self.featureFlagStore = featureFlagStore
+        self.userDefaults = userDefaults
         self.isWordPress = isWordPress
     }
 
@@ -85,6 +91,7 @@ final class JetpackNotificationMigrationService: JetpackNotificationMigrationSer
     func shouldPresentNotifications() -> Bool {
         let disableNotifications = jetpackMigrationPreventDuplicateNotifications
             && isWordPress
+            && userDefaults.bool(forKey: wordPressNotificationsToggledDefaultsKey)
             && !wordPressNotificationsEnabled
 
         if disableNotifications {

WordPress/Classes/Services/JetpackNotificationMigrationService.swift

@@ -15,6 +15,7 @@ private enum UPRUConstants {
     static let currentAnnouncementsKey = "currentAnnouncements"
     static let currentAnnouncementsDateKey = "currentAnnouncementsDate"
     static let announcementsVersionDisplayedKey = "announcementsVersionDisplayed"
+    static let isJPContentImportCompleteKey = "jetpackContentImportComplete"
 }
 
 protocol UserPersistentRepositoryUtility: AnyObject {
@@ -164,4 +165,13 @@ extension UserPersistentRepositoryUtility {
             UserPersistentStoreFactory.instance().set(newValue, forKey: UPRUConstants.announcementsVersionDisplayedKey)
         }
     }
+
+    var isJPContentImportComplete: Bool {
+        get {
+            return UserPersistentStoreFactory.instance().bool(forKey: UPRUConstants.isJPContentImportCompleteKey)
+        }
+        set {
+            UserPersistentStoreFactory.instance().set(newValue, forKey: UPRUConstants.isJPContentImportCompleteKey)
+        }
+    }
 }

WordPress/Classes/Stores/UserPersistentRepositoryUtility.swift

@@ -197,6 +197,13 @@ class WordPressAppDelegate: UIResponder, UIApplicationDelegate {
         uploadsManager.resume()
         updateFeatureFlags()
         updateRemoteConfig()
+
+        #if JETPACK
+        if let windowManager = windowManager as? JetpackWindowManager,
+           windowManager.shouldImportMigrationData {
+            windowManager.importAndShowMigrationContent(nil, failureCompletion: nil)
+        }
+        #endif
     }
 
     func applicationWillResignActive(_ application: UIApplication) {

WordPress/Classes/System/WordPressAppDelegate.swift

@@ -415,6 +415,11 @@ import Foundation
     case jetpackSiteCreationOverlayButtonTapped
     case jetpackSiteCreationOverlayDismissed
 
+    // WordPress to Jetpack Migration
+    case migrationEmailTriggered
+    case migrationEmailSent
+    case migrationEmailFailed
+
     /// A String that represents the event
     var value: String {
         switch self {
@@ -1123,6 +1128,15 @@ import Foundation
             return "remove_site_creation_overlay_button_tapped"
         case .jetpackSiteCreationOverlayDismissed:
             return "remove_site_creation_overlay_dismissed"
+
+        // WordPress to Jetpack Migration
+        case .migrationEmailTriggered:
+            return "migration_email_triggered"
+        case .migrationEmailSent:
+            return "migration_email_sent"
+        case .migrationEmailFailed:
+            return "migration_email_failed"
+
         } // END OF SWITCH
     }
 

WordPress/Classes/Utility/Analytics/WPAnalyticsEvent.swift

@@ -8,13 +8,16 @@ class ContentMigrationCoordinator {
 
     // MARK: Dependencies
 
+    private let coreDataStack: CoreDataStack
     private let dataMigrator: ContentDataMigrating
     private let userPersistentRepository: UserPersistentRepository
     private let eligibilityProvider: ContentMigrationEligibilityProvider
 
-    init(dataMigrator: ContentDataMigrating = DataMigrator(),
+    init(coreDataStack: CoreDataStack = ContextManager.shared,
+         dataMigrator: ContentDataMigrating = DataMigrator(),
          userPersistentRepository: UserPersistentRepository = UserDefaults.standard,
          eligibilityProvider: ContentMigrationEligibilityProvider = AppConfiguration()) {
+        self.coreDataStack = coreDataStack
         self.dataMigrator = dataMigrator
         self.userPersistentRepository = userPersistentRepository
         self.eligibilityProvider = eligibilityProvider
@@ -23,6 +26,7 @@ class ContentMigrationCoordinator {
     enum ContentMigrationCoordinatorError: Error {
         case ineligible
         case exportFailure
+        case localDraftsNotSynced
     }
 
     // MARK: Methods
@@ -41,7 +45,10 @@ class ContentMigrationCoordinator {
             return
         }
 
-        // TODO: Sync local post drafts here.
+        guard isLocalPostsSynced() else {
+            completion?(.failure(.localDraftsNotSynced))
+            return
+        }
 
         dataMigrator.exportData { result in
             switch result {
@@ -78,6 +85,26 @@ class ContentMigrationCoordinator {
     }
 }
 
+// MARK: - Preflights Local Draft Check
+
+private extension ContentMigrationCoordinator {
+
+    func isLocalPostsSynced() -> Bool {
+        let fetchRequest = NSFetchRequest<Post>(entityName: String(describing: Post.self))
+        fetchRequest.predicate = NSPredicate(format: "remoteStatusNumber = %@ || remoteStatusNumber = %@ || remoteStatusNumber = %@ || remoteStatusNumber = %@",
+                                             NSNumber(value: AbstractPostRemoteStatus.pushing.rawValue),
+                                             NSNumber(value: AbstractPostRemoteStatus.failed.rawValue),
+                                             NSNumber(value: AbstractPostRemoteStatus.local.rawValue),
+                                             NSNumber(value: AbstractPostRemoteStatus.pushingMedia.rawValue))
+        guard let count = try? coreDataStack.mainContext.count(for: fetchRequest) else {
+            return false
+        }
+
+        return count == 0
+    }
+
+}
+
 // MARK: - Content Migration Eligibility Provider
 
 protocol ContentMigrationEligibilityProvider {

WordPress/Classes/Utility/Migration/ContentMigrationCoordinator.swift

@@ -2,12 +2,19 @@ import UIKit
 
 struct LogOutActionHandler {
 
+    private weak var windowManager: WindowManager?
+
+    init(windowManager: WindowManager? = WordPressAppDelegate.shared?.windowManager) {
+        self.windowManager = windowManager
+    }
+
     func logOut(with viewController: UIViewController) {
         let alert  = UIAlertController(title: logOutAlertTitle, message: nil, preferredStyle: .alert)
         alert.addActionWithTitle(Strings.alertCancelAction, style: .cancel)
         alert.addActionWithTitle(Strings.alertLogoutAction, style: .destructive) { [weak viewController] _ in
             viewController?.dismiss(animated: true) {
                 AccountHelper.logOutDefaultWordPressComAccount()
+                windowManager?.showSignInUI()
             }
         }
         viewController.present(alert, animated: true)

WordPress/Classes/ViewRelated/Support/LogOutActionHandler.swift

@@ -477,6 +477,7 @@
 			<array>
 				<string>wordpress-oauth-v2</string>
 				<string>${WPCOM_SCHEME}</string>
+				<string>wordpressmigration+v1</string>
 				<string>wordpressnotificationmigration</string>
 			</array>
 		</dict>