Show stats insights changes prompt in alert and not actionSheet on iPad (#20013)

staskus · web-flow · commit f0df96a4cb7e · 2023-01-30T09:05:22.000+02:00
When showing UIAlertViewController as actionSheet on iPad sourceView and sourceRect is required to be set to avoid a crash.
diff --git a/WordPress/Classes/ViewRelated/Stats/Insights/Insights Management/InsightsManagementViewController.swift b/WordPress/Classes/ViewRelated/Stats/Insights/Insights Management/InsightsManagementViewController.swift
@@ -192,7 +192,8 @@ class InsightsManagementViewController: UITableViewController {
     }
 
     private func promptToSave(from viewController: UIViewController?) {
-        let alert = UIAlertController(title: nil, message: TextContent.savePromptMessage, preferredStyle: .actionSheet)
+        let alertStyle: UIAlertController.Style = UIDevice.current.userInterfaceIdiom == .pad ? .alert : .actionSheet
+        let alert = UIAlertController(title: nil, message: TextContent.savePromptMessage, preferredStyle: alertStyle)
         alert.addAction(UIAlertAction(title: TextContent.savePromptSaveButton, style: .default, handler: { _ in
             self.saveTapped()
         }))

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,8 @@ class InsightsManagementViewController: UITableViewController {`
`192`	`192`	`}`
`193`	`193`
`194`	`194`	`private func promptToSave(from viewController: UIViewController?) {`
`195`		`- let alert = UIAlertController(title: nil, message: TextContent.savePromptMessage, preferredStyle: .actionSheet)`
	`195`	`+ let alertStyle: UIAlertController.Style = UIDevice.current.userInterfaceIdiom == .pad ? .alert : .actionSheet`
	`196`	`+ let alert = UIAlertController(title: nil, message: TextContent.savePromptMessage, preferredStyle: alertStyle)`
`196`	`197`	`alert.addAction(UIAlertAction(title: TextContent.savePromptSaveButton, style: .default, handler: { _ in`
`197`	`198`	`self.saveTapped()`
`198`	`199`	`}))`