Skip to content

Commit f276571

Browse files
authored
Fix an issue with a missing "Reply" button in Notifications / Comments (#23710)
2 parents 4f10b8f + 2a8f46a commit f276571

File tree

4 files changed

+7
-28
lines changed

4 files changed

+7
-28
lines changed

WordPress/Classes/ViewRelated/Notifications/ReplyTextView/ReplyTextView.swift

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -271,13 +271,13 @@ import Gridicons
271271
textView.contentInset = .zero
272272
textView.textContainerInset = .zero
273273
textView.autocorrectionType = .yes
274-
textView.textColor = Style.textColor
274+
textView.textColor = .label
275275
textView.textContainer.lineFragmentPadding = 0
276276
textView.layoutManager.allowsNonContiguousLayout = false
277277
textView.accessibilityIdentifier = "reply-text-view"
278278

279279
// Placeholder
280-
placeholderLabel.textColor = Style.placeholderColor
280+
placeholderLabel.textColor = .tertiaryLabel
281281

282282
// Fullscreen toggle button
283283
fullscreenToggleButton.setImage(.gridicon(.chevronUp), for: .normal)
@@ -286,17 +286,17 @@ import Gridicons
286286
comment: "Accessibility Label for the enter full screen button on the comment reply text view")
287287

288288
// Reply button
289-
replyButton.setTitleColor(Style.replyButtonColor, for: .normal)
289+
replyButton.setTitleColor(UIAppColor.brand, for: .normal)
290290
replyButton.titleLabel?.text = NSLocalizedString("Reply", comment: "Reply to a comment.")
291291
replyButton.accessibilityIdentifier = "reply-button"
292292
replyButton.accessibilityLabel = NSLocalizedString("Reply", comment: "Accessibility label for the reply button")
293293
refreshReplyButton()
294294

295295
// Background
296-
contentView.backgroundColor = Style.backgroundColor
296+
contentView.backgroundColor = .systemBackground
297297

298298
// Top Separator
299-
topSeparator.backgroundColor = Style.separatorColor
299+
topSeparator.backgroundColor = .separator
300300
topSeparatorHeightConstraint.constant = .hairlineBorderWidth
301301

302302
// Recognizers
@@ -344,7 +344,6 @@ import Gridicons
344344

345345
// MARK: - Private Properties
346346
fileprivate var bundle: NSArray?
347-
private typealias Style = WPStyleGuide.Reply
348347

349348
// MARK: - IBOutlets
350349
@IBOutlet private weak var contentView: UIView!

WordPress/Classes/ViewRelated/Notifications/Style/WPStyleGuide+Reply.swift

Lines changed: 0 additions & 14 deletions
This file was deleted.

WordPress/Classes/ViewRelated/Reader/Comments/ReaderCommentsViewController.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -362,8 +362,8 @@ - (void)configureViewConstraints
362362
views:views]];
363363

364364
[NSLayoutConstraint activateConstraints:@[
365-
[self.replyTextView.leadingAnchor constraintEqualToAnchor:self.replyTextView.leadingAnchor],
366-
[self.replyTextView.trailingAnchor constraintEqualToAnchor:self.replyTextView.trailingAnchor],
365+
[self.replyTextView.leadingAnchor constraintEqualToAnchor:self.view.leadingAnchor],
366+
[self.replyTextView.trailingAnchor constraintEqualToAnchor:self.view.trailingAnchor],
367367
[self.view.keyboardLayoutGuide.topAnchor constraintEqualToAnchor:self.replyTextView.bottomAnchor]
368368
]];
369369

WordPress/WordPress.xcodeproj/project.pbxproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3108,7 +3108,6 @@
31083108
B5AEEC7C1ACACFDA008BF2A4 /* notifications-new-follower.json in Resources */ = {isa = PBXBuildFile; fileRef = B5AEEC771ACACFDA008BF2A4 /* notifications-new-follower.json */; };
31093109
B5AEEC7D1ACACFDA008BF2A4 /* notifications-replied-comment.json in Resources */ = {isa = PBXBuildFile; fileRef = B5AEEC781ACACFDA008BF2A4 /* notifications-replied-comment.json */; };
31103110
B5B410B61B1772B000CFCF8D /* NavigationTitleView.swift in Sources */ = {isa = PBXBuildFile; fileRef = B5B410B51B1772B000CFCF8D /* NavigationTitleView.swift */; };
3111-
B5B56D3219AFB68800B4E29B /* WPStyleGuide+Reply.swift in Sources */ = {isa = PBXBuildFile; fileRef = B5B56D3019AFB68800B4E29B /* WPStyleGuide+Reply.swift */; };
31123111
B5B56D3319AFB68800B4E29B /* WPStyleGuide+Notifications.swift in Sources */ = {isa = PBXBuildFile; fileRef = B5B56D3119AFB68800B4E29B /* WPStyleGuide+Notifications.swift */; };
31133112
B5B68BD41C19AAED00EB59E0 /* InteractiveNotificationsManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = B5B68BD31C19AAED00EB59E0 /* InteractiveNotificationsManager.swift */; };
31143113
B5BEA55F1C7CE6D100C8035B /* Constants.m in Sources */ = {isa = PBXBuildFile; fileRef = B5CC05F51962150600975CAC /* Constants.m */; };
@@ -4462,7 +4461,6 @@
44624461
FABB21112602FC2C00C8785C /* BaseRestoreOptionsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAB8F74F25AD72CE00D5D54A /* BaseRestoreOptionsViewController.swift */; };
44634462
FABB21132602FC2C00C8785C /* AuthenticationService.swift in Sources */ = {isa = PBXBuildFile; fileRef = F12FA5D82428FA8F0054DA21 /* AuthenticationService.swift */; };
44644463
FABB21142602FC2C00C8785C /* JetpackSiteRef.swift in Sources */ = {isa = PBXBuildFile; fileRef = E16A76F01FC4758300A661E3 /* JetpackSiteRef.swift */; };
4465-
FABB21152602FC2C00C8785C /* WPStyleGuide+Reply.swift in Sources */ = {isa = PBXBuildFile; fileRef = B5B56D3019AFB68800B4E29B /* WPStyleGuide+Reply.swift */; };
44664464
FABB21172602FC2C00C8785C /* JetpackBackupOptionsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAB8F76D25AD73C000D5D54A /* JetpackBackupOptionsViewController.swift */; };
44674465
FABB21192602FC2C00C8785C /* NotificationContentRangeFactory.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7E4123B120F4097A00DF8486 /* NotificationContentRangeFactory.swift */; };
44684466
FABB211A2602FC2C00C8785C /* SiteInfo.swift in Sources */ = {isa = PBXBuildFile; fileRef = E6D170361EF9D8D10046D433 /* SiteInfo.swift */; };
@@ -8641,7 +8639,6 @@
86418639
B5AEEC771ACACFDA008BF2A4 /* notifications-new-follower.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "notifications-new-follower.json"; sourceTree = "<group>"; };
86428640
B5AEEC781ACACFDA008BF2A4 /* notifications-replied-comment.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "notifications-replied-comment.json"; sourceTree = "<group>"; };
86438641
B5B410B51B1772B000CFCF8D /* NavigationTitleView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = NavigationTitleView.swift; sourceTree = "<group>"; };
8644-
B5B56D3019AFB68800B4E29B /* WPStyleGuide+Reply.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "WPStyleGuide+Reply.swift"; sourceTree = "<group>"; };
86458642
B5B56D3119AFB68800B4E29B /* WPStyleGuide+Notifications.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; lineEnding = 0; path = "WPStyleGuide+Notifications.swift"; sourceTree = "<group>"; xcLanguageSpecificationIdentifier = xcode.lang.swift; };
86468643
B5B63F3F19621A9F001601C3 /* WordPress 19.xcdatamodel */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcdatamodel; path = "WordPress 19.xcdatamodel"; sourceTree = "<group>"; };
86478644
B5B68BD31C19AAED00EB59E0 /* InteractiveNotificationsManager.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = InteractiveNotificationsManager.swift; sourceTree = "<group>"; };
@@ -12357,7 +12354,6 @@
1235712354
402FFB1D218C2B8D00FF4A0B /* Style */ = {
1235812355
isa = PBXGroup;
1235912356
children = (
12360-
B5B56D3019AFB68800B4E29B /* WPStyleGuide+Reply.swift */,
1236112357
B5B56D3119AFB68800B4E29B /* WPStyleGuide+Notifications.swift */,
1236212358
);
1236312359
path = Style;
@@ -21559,7 +21555,6 @@
2155921555
FA85F5F52A9DFDCC001D8425 /* NoSitesViewModel.swift in Sources */,
2156021556
F12FA5D92428FA8F0054DA21 /* AuthenticationService.swift in Sources */,
2156121557
E16A76F11FC4758300A661E3 /* JetpackSiteRef.swift in Sources */,
21562-
B5B56D3219AFB68800B4E29B /* WPStyleGuide+Reply.swift in Sources */,
2156321558
FA6C32B92BF1FFEF00BBDDB4 /* AppStoreSearchService.swift in Sources */,
2156421559
4A358DE629B5EB8D00BFCEBE /* PublicizeService+Lookup.swift in Sources */,
2156521560
C7234A422832C2BA0045C63F /* QRLoginScanningViewController.swift in Sources */,
@@ -24502,7 +24497,6 @@
2450224497
FABB21132602FC2C00C8785C /* AuthenticationService.swift in Sources */,
2450324498
FABB21142602FC2C00C8785C /* JetpackSiteRef.swift in Sources */,
2450424499
835771362A7C2755006B2A3E /* JetpackSocialNoSharesView.swift in Sources */,
24505-
FABB21152602FC2C00C8785C /* WPStyleGuide+Reply.swift in Sources */,
2450624500
836498CF281735CC00A2C170 /* BloggingPromptsHeaderView.swift in Sources */,
2450724501
01E258032ACC36FA00F09666 /* PlanStep.swift in Sources */,
2450824502
FABB21172602FC2C00C8785C /* JetpackBackupOptionsViewController.swift in Sources */,

0 commit comments

Comments
 (0)