NSInvalidArgumentException: nil is not a valid object ID

[sentry]

Sentry Issue: JETPACK-IOS-1B8

NSInvalidArgumentException: nil is not a valid object ID
  File "EditorMediaUtility.swift", line 23, in AuthenticatedImageDownload.main
  File "EditorMediaUtility.swift", line 22, in AuthenticatedImageDownload.main
  File "CoreDataHelper.swift", line 189, in CoreDataStack.performQuery<T>
  File "<compiler-generated>", in CoreDataStack.performQuery<T>
  File "<compiler-generated>", in thunk for closure
...
(18 additional frame(s) were not displayed)

[develric]

The navigation breadcrumbs mention WordPress.AztecNavigationController, also numbers are currently not high (40 users affected overall). The trace also seems to involve core data (CoreDataHelper). Makes sense to monitor evolution. Assigning a Medium priority for now until further investigation.

Note: even though sentry does not report it as a new issue, by sentry grouping it seems to affect only 22.2.*

[crazytonyli]

This is a strange crash. Based on the message "nil is not a valid object ID", the crash happens at the existingObject(with:) call. However, the self.blogObjectID is a non-optional property, how could it be nil?

[twstokes]

@crazytonyli do you think it'd be worth for us to add the check proposed by @jkmassel in this issue? At a minimum we could try to prevent the crash / send extra logging info.

[crazytonyli]

@twstokes Definitely worth trying. I've opened a PR. If this "id check" indeed stops this crash, then we potentially need to extract it to a pattern to be applied to other places in the app.

[sentry]

Sentry issue: JETPACK-IOS-1KE

[hassaanelgarem]

@crazytonyli FYI: this crash is still happening in version 22.3 😢