Reader Bugfixes #25016

jkmassel · 2025-11-24T23:35:48Z

Description

Fixes a few reported reader issues:

Accessing links from the WP.com Calypso Banner works again (try the following):

Opening a Reader link multiple times doesn't cause the view to reload on top of the old one. Try the above links, then go back to the browser and try them again. None should be replaced inline.
Fixes an issue where where going to https://wordpress.com/read after https://wordpress.com/reader/feeds/138734090 wouldn't load the reader root. It is added to the top of the nav stack instead of popping the stack down to the root to more closely imitate how a browser works.
Removes a bunch of code causing problems – there is no good way to load a post into the reader by its URL. Thus, we'll use WP.com to resolve all reader URLs to a site ID and post ID and load them that way.

Testing instructions

See above

Consider testing the following yourself before requesting a review:

Compatibility with WordPress.com sites and self-hosted Jetpack sites
Both portrait and landscape orientations
Light and dark modes
Dynamic font sizes: larger, smaller and bold text
High contrast mode
Screen reader experience (e.g., VoiceOver)
Languages with large words or with letters/accents not frequently used in English
Right-to-left languages layout
Multi-tasking: split view and slide over

-->

wpmobilebot · 2025-11-24T23:47:45Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`29968`
	Version	`PR #25016`
	Bundle ID	`org.wordpress.alpha`
	Commit	`dbecfbe`
	Installation URL	50bfpp4v498q8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2025-11-24T23:47:55Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`29968`
	Version	`PR #25016`
	Bundle ID	`com.jetpack.alpha`
	Commit	`dbecfbe`
	Installation URL	12bg6i2f1efg0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

kean · 2025-11-25T22:05:02Z

WordPress/Classes/Utility/Universal Links/Routes+Reader.swift

        case .blogsPost:
            return "/read/blogs/:blog_id/posts/:post_id"
-        case .wpcomPost:
-            return "/:post_year/:post_month/:post_day/:post_name"


This can't be removed without more consideration as it's the top universal link in the app.

I've reworked this to unconditionally resolve the URL against WP.com without making any local assumptions.

crazytonyli · 2025-11-26T21:18:12Z

Modules/Sources/WordPressKit/ReaderPostServiceRemote+V2.swift

+            success(ResolvedReaderPost(postId: postId, siteId: siteId))
+        } failure: { error, response in
+            failure(error)
+        }


Nit: you can use the async API, which supports Decodable, in wordPressComRestApi.perform(...) (which is different from wordPressComRESTAPI)

crazytonyli · 2025-11-26T21:22:48Z

Does this PR fix the issue where the app can't handle the post link from the web reader?

Simulator.Screen.Recording.-.iPhone.17.-.2025-11-27.at.10.23.23.mov

crazytonyli · 2025-11-26T21:24:43Z

I probably pressed some unknown key combination that accidentally closed the PR. 🤦‍♂️

crazytonyli · 2025-11-26T21:25:50Z

BTW, do you want to target the 26.5 release branch?

jkmassel · 2025-11-26T21:39:27Z

BTW, do you want to target the 26.5 release branch?

Rebased, thanks!

crazytonyli · 2025-11-26T21:59:39Z

The base branch is set to release_notes/26.5, but it should be release/26.5 😅

jkmassel · 2025-11-26T23:42:23Z

The base branch is set to release_notes/26.5, but it should be release/26.5 😅

Oh man, one day I'll learn to read 🤦

dangermattic · 2025-11-26T23:42:46Z

	1 Warning
⚠️	This PR is assigned to the milestone 26.5 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

	1 Message
📖	This PR contains changes to `RELEASE-NOTES.txt`. Note that these changes won't affect the final version of the release notes as this version is in code freeze. Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 Danger

crazytonyli · 2025-11-27T00:44:22Z

@jkmassel You may need to rebase this PR to remove some commits that were merged into trunk after the RC was cut.

- Remove unused `Decodable` conformance from `ResolvedReaderPost` - Add `[weak self]` to closures in `fetch(_ url:)` to prevent retain cycles - Simplify nested conditionals in `contentIsAlreadyDisplayed` - Add debug logging when skipping duplicate content presentation - Make `self.` usage consistent 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

- Simplify nested conditionals in `contentIsAlreadyDisplayed(_:in nav:)` to use guard-let pattern - Add clarifying comment for UInt64 type requirement in resolveUrl 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

jkmassel · 2025-11-27T01:25:51Z

Does this PR fix the issue where the app can't handle the post link from the web reader?

Simulator.Screen.Recording.-.iPhone.17.-.2025-11-27.at.10.23.23.mov

523028f addresses this :)

crazytonyli · 2025-11-27T08:43:00Z

@jkmassel The WordPress.com News link in the Reader can't be opened in the app. I have fixed that in the commit above. Feel free to make additional changes if needed.

sonarqubecloud · 2025-11-27T08:44:38Z

Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kean

It looks good. I tested the banner and some other scenarios as well. I found one issue and will send it separately.

Left one small comment about release notes.

kean · 2025-11-27T16:28:02Z

RELEASE-NOTES.txt

+* [*] Add support for editing custom taxonomy terms from "Post Settings" [#24964]
+* [*] Fix overly long related post titles in Reader [#25011]
+* [*] Increase number of lines for post tiles in Reader to three [#25019]
+* [*] Fix horizontal insets in Reader article view [#25010]


These entries are now duplicated.

jkmassel force-pushed the fix/reader-issues branch from cd46b6b to 1709330 Compare November 24, 2025 23:49

kean reviewed Nov 25, 2025

View reviewed changes

jkmassel force-pushed the fix/reader-issues branch from 1709330 to 4d56923 Compare November 26, 2025 20:49

jkmassel added [Type] Bug Reader labels Nov 26, 2025

jkmassel added this to the 26.5 ❄️ milestone Nov 26, 2025

jkmassel requested a review from kean November 26, 2025 20:51

jkmassel marked this pull request as ready for review November 26, 2025 20:51

crazytonyli reviewed Nov 26, 2025

View reviewed changes

crazytonyli closed this Nov 26, 2025

crazytonyli reopened this Nov 26, 2025

jkmassel changed the base branch from trunk to release_notes/26.5 November 26, 2025 21:31

jkmassel changed the base branch from release_notes/26.5 to release/26.5 November 26, 2025 23:40

jkmassel force-pushed the fix/reader-issues branch 4 times, most recently from fa08f72 to bcbf5dc Compare November 27, 2025 01:07

jkmassel added 3 commits November 26, 2025 18:07

Fix apps.wordpress.com URLs not being handled

ea90e4f

Don’t reload Reader views from deep links if they’re already displayed

52bec8c

Properly handle links to the reader root

c6a3e76

jkmassel and others added 6 commits November 26, 2025 18:07

Rework opening a post by URL

d1ea8c9

fix broken test

3502ea5

release note

df7a0b5

Use wordPressComRestApi.perform

3040de4

jkmassel force-pushed the fix/reader-issues branch from bcbf5dc to 3040de4 Compare November 27, 2025 01:08

Handle /read and /reader URLs

523028f

jkmassel force-pushed the fix/reader-issues branch from ca3e5c9 to 523028f Compare November 27, 2025 01:27

jkmassel and others added 2 commits November 26, 2025 19:14

Remove tests

f7746ec

Fix opening WordPress.com News links in the app

dbecfbe

crazytonyli approved these changes Nov 27, 2025

View reviewed changes

kean approved these changes Nov 27, 2025

View reviewed changes

jkmassel merged commit 97338c8 into release/26.5 Nov 27, 2025
26 of 32 checks passed

jkmassel deleted the fix/reader-issues branch November 27, 2025 16:58

Reader Bugfixes #25016

Reader Bugfixes #25016

Uh oh!

Conversation

jkmassel commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

wpmobilebot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kean Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

jkmassel Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

crazytonyli Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

crazytonyli commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazytonyli commented Nov 26, 2025

Uh oh!

crazytonyli commented Nov 26, 2025

Uh oh!

jkmassel commented Nov 26, 2025

Uh oh!

crazytonyli commented Nov 26, 2025

Uh oh!

jkmassel commented Nov 26, 2025

Uh oh!

dangermattic commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazytonyli commented Nov 27, 2025

Uh oh!

jkmassel commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazytonyli commented Nov 27, 2025

Uh oh!

sonarqubecloud bot commented Nov 27, 2025

Quality Gate passed

Uh oh!

kean left a comment

Choose a reason for hiding this comment

Uh oh!

kean Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jkmassel commented Nov 24, 2025 •

edited

Loading

wpmobilebot commented Nov 24, 2025 •

edited

Loading

wpmobilebot commented Nov 24, 2025 •

edited

Loading

crazytonyli commented Nov 26, 2025 •

edited

Loading

dangermattic commented Nov 26, 2025 •

edited

Loading

jkmassel commented Nov 27, 2025 •

edited

Loading