Enable SwiftLint rule: modifier_order by mokagio · Pull Request #25568 · wordpress-mobile/WordPress-iOS

mokagio · 2026-05-20T10:58:13Z

Rationale

Adds modifier_order to only_rules in .swiftlint.yml.

The rule enforces a canonical order for declaration modifiers (e.g. public final lazy var), making declarations easier to scan and removing a class of arbitrary stylistic divergence across the codebase.

How to test

CI handles lint and build verification.
Locally: rake lint from the worktree should report zero violations.

Notes

auto_fixed: 161
manual_fixes: 0
suppressions: 0
No violations left for human review.
Build deferred to CI per the established whitespace-only / pure-syntactic-reorder precedent (see also wcios sibling PR Enable SwiftLint rule: modifier_order woocommerce/woocommerce-ios#17200).
Part of the Orchard SwiftLint rollout campaign.

Enforces a canonical order for declaration modifiers (e.g. `final public` -> `public final`, `open override` -> `override open`). `rake lintfix` auto-corrected 160 files; no manual fixes, no suppressions. The diff is pure modifier reordering with no semantic changes. Local WordPress-scheme build deferred to CI: modifier reordering cannot affect compilation, matching the precedent set by the woocommerce-ios sibling PR (woocommerce/woocommerce-ios#17200, 195 files). Part of the Orchard SwiftLint rollout campaign.

dangermattic · 2026-05-20T10:58:55Z

	3 Warnings
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	This PR is assigned to the milestone 26.9. This milestone is due in less than 4 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copilot

Pull request overview

Enables SwiftLint’s modifier_order rule (opt-in via only_rules) and applies mechanical modifier reordering across the codebase so existing declarations conform to the newly enforced canonical modifier ordering.

Changes:

Add modifier_order to .swiftlint.yml only_rules.
Reorder Swift declaration modifiers (e.g., open override → override open, lazy private → private lazy) across app, modules, and tests to eliminate violations.

Reviewed changes

Copilot reviewed 161 out of 161 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
WordPress/Classes/ViewRelated/Views/SeparatorsView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Views/RichTextView/RichTextView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Views/NavigationTitleView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Views/List/ListTableViewCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Views/List/ListTableHeaderView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Tools/SettingsPickerViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Tools/SettingsListEditorViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Themes/ThemeBrowserViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Themes/ThemeBrowserSectionHeaderView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Tags/SiteTagsView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/System/WPTabBarController+Swift.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/System/Sidebar/SidebarViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/System/FilterTabBar.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/System/Action Sheet/ActionSheetViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Stats/SiteStatsDashboardViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Stats/Insights/StatsTotalInsightsCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Stats/Insights/StatsMostPopularTimeInsightsCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Stats/Insights/StatsLatestPostSummaryInsightsCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Stats/Helpers/SiteStatsInformation.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Stats/Charts/StatsLineChartView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Reader/Views/ReaderPostCardContentLabel.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Reader/Sidebar/ReaderSidebarViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Reader/Headers/ReaderTagStreamHeader.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Reader/Controllers/ReaderSearchViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Reader/Cards/ReaderGapMarkerCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Reader/Cards/ReaderCardDiscoverAttributionView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Reader/Cards/ReaderBlockedSiteCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Post/Views/ResolveConflictView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Post/Views/PostMediaUploadsView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Post/Publishing/PublishPostViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Post/PostSettings/PostSettingsView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Post/Categories/PostCategoriesViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/NUX/Controllers/UnifiedPrologue/UnifiedProloguePages.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Notifications/Tools/IntrinsicTableView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationSettingsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/NewSupport/RootSupportView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Me/Me Main/MeViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Me/App Settings/DebugMenuViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Me/App Settings/App Icons/AppIconViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Jetpack/Login/JetpackLoginViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackSpeedUpSiteSettingsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackSettingsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackConnectionViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Jetpack/Branding/Moved To Jetpack/MovedToJetpackViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Jetpack/Branding/Menu Card/JetpackBrandingMenuCardCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Gutenberg/Views/GutenGhostView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Gutenberg/Layout Picker/GutenbergLayoutPickerViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Feature Introduction/Blogging Prompts/BloggingPromptsFeatureDescriptionView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/EEUUSCompliance/CompliancePopoverViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Domains/Views/SiteDomainsView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Domains/Domain registration/SiteCreationPurchasingWebFlowController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Domains/Domain registration/RegisterDomainDetails/ViewController/RegisterDomainDetailsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Comments/Controllers/CommentDetailViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Cells/TextWithAccessoryButtonCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Cells/SwitchTableViewCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Cells/PickerTableViewCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Cells/MediaQuotaCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Cells/ExpandableCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Cells/CheckmarkTableViewCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Subscribers/List/SubscribersView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Site Settings/LanguageViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Site Settings/HomepageSettingsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Site Settings/DiscussionSettingsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Site Settings/DateAndTimeFormatSettingsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Site Monitoring/SiteMonitoringView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Site Management/TableViewHeaderDetailView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Site Management/DeleteSiteViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Sharing/TwitterDeprecationTableFooterView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Sharing/SharingAccountViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Sharing/PublicizeServiceCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsSectionFooterView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Aztec/Media/MediaProgressCoordinator.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/AppUpdate/BlockingUpdateView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Activity/List/BackupsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/ViewRelated/Activity/List/ActivityLogsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Utility/WebViewController/WebNavigationDelegate.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Utility/Spotlight/SearchManager.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Utility/Media/MediaVideoExporter.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Utility/KeychainTools.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Utility/ImmuTable/ImmuTable.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Utility/BackgroundTasks/WeeklyRoundupBackgroundTask.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Utility/AppIcon.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Utility/Analytics/AnalyticsTrackerAutomatticTracks.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/System/Root View/ReaderPresenter.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/System/3D Touch/WP3DTouchShortcutCreator.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Services/RecentSitesService.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Services/MediaSettings.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Services/JetpackCapabilitiesService.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Plugins/Views/PluginDetailsView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Jetpack/JetpackMigration/SuccessCard/TableView/MigrationSuccessCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
WordPress/Classes/Extensions/StoreKit+Debug.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Tests/WordPressDataTests/Helpers/ContextManager+Testing.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Tests/KeystoneTests/Tests/Utility/RemoteFeatureFlagTests.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Tests/KeystoneTests/Tests/Services/PluginJetpackProxyServiceTests.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Tests/KeystoneTests/Tests/Services/BlogJetpackTests.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Tests/KeystoneTests/Tests/Features/Domains/AllDomainsListItemViewModelTests.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Tests/KeystoneTests/Tests/Features/Dashboard/DashboardPostsSyncManagerTests.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Tests/KeystoneTests/Helpers/ContextManager+Helpers.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/WPAccount.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/SiteSuggestion+CoreDataClass.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/ReaderTagTopic.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/ReaderPost.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/PostCategory+CoreDataClass.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/Post.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/Notification.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/Media.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/ManagedAccountSettings.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/JetpackState.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/Domain.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/ContextManager.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/BloggingPrompt+CoreDataClass.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/Blog+Swift.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/Blog.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressData/Swift/AppEnvironment.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressAuthenticator/Views/LoginTextField.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressAuthenticator/Helpers/WordPressComOAuthClientFacade.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressAuthenticator/Helpers/UnifiedAuth/ViewRelated/ReusableViews/TextLabelTableViewCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressAuthenticator/Helpers/Analytics/AuthenticatorAnalyticsTracker.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressAuthenticator/Features/SignIn/LoginViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressAuthenticator/Features/SignIn/LoginSocialErrorCell.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressAuthenticator/Features/SignIn/LoginNavigationController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Sources/WordPressAuthenticator/Features/NUX/Button/NUXButton.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Tests/WordPressSharedTests/KeychainUtilsTests.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/Views/WPReusableTableViewCells.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/Views/SpacerView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/Views/SiteIconView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/Views/SeparatorView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/Views/InfiniteScrollerView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/Views/AdaptiveTabBarController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/Views/AdaptiveTabBar.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/Tools/GradientView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/FancyAlert/FancyButton.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressUI/Deprecated/NoResultsViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressShared/Utility/ManagedObjectsObserver.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressShared/AsyncOperation/AsyncOperation.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressShared/AsyncOperation/AsyncBlockOperation.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressReader/Comments/Views/WebCommentContentRenderer.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressKitModels/RemoteReaderSiteInfoSubscription.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressKit/WordPressOrgXMLRPCApi.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressKit/WordPressComRestApi.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressKit/RemoteBlockEditorSettings.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressKit/NSMutableParagraphStyle+extensions.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressKit/HTTPAuthenticationAlertController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressKit/AccountServiceRemoteREST+SocialService.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressIntelligence/IntelligenceService.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/WordPressCore/Types/LockingHashMap.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/ShareExtensionCore/Data/SharedCoreDataStack.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/JetpackSocial/Views/SocialOAuthWebViewController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/JetpackSocial/Views/ManageConnectionsHostingController.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/FormattableContentKit/NotificationTextContent.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/FormattableContentKit/FormattableContent/FormattableUserContent.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/FormattableContentKit/FormattableContent/FooterTextContent.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/FormattableContentKit/Actions/FormattableCommentContent.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/FormattableContentKit/Actions/DefaultFormattableContentAction.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/AsyncImageKit/Views/AsyncImageView.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/AsyncImageKit/ImagePrefetcher.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/AsyncImageKit/ImageDownloader.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/AsyncImageKit/Helpers/ImageSaliencyService.swift	Reorders declaration modifiers to satisfy `modifier_order`.
Modules/Sources/AsyncImageKit/Helpers/FaviconService.swift	Reorders declaration modifiers to satisfy `modifier_order`.
.swiftlint.yml	Enables `modifier_order` in `only_rules`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wpmobilebot · 2026-05-20T11:12:25Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`32263`
	Version	`PR #25568`
	Bundle ID	`org.wordpress.alpha`
	Commit	`361b097`
	Installation URL	5nhmob3hqsk98

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-05-20T11:12:39Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`32263`
	Version	`PR #25568`
	Bundle ID	`com.jetpack.alpha`
	Commit	`361b097`
	Installation URL	36utpqkl5bol8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

crazytonyli · 2026-05-20T21:41:47Z

I'm inclined not to include this rule. The main reason is that the violations do not feel incorrect to me. I don't think I'll even notice the difference between public nonisolated static let and nonisolated public static let.

mokagio · 2026-05-21T06:49:20Z

Sounds good @crazytonyli . Closing.

(FWIW, I like this rule, most things that removes a decision in favor of a convention are a plus for me.)

Copilot AI review requested due to automatic review settings May 20, 2026 10:58

mokagio self-assigned this May 20, 2026

mokagio added the [Type] Tooling label May 20, 2026

mokagio added this to the 26.9 milestone May 20, 2026

Copilot started reviewing on behalf of mokagio May 20, 2026 10:58 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

mokagio closed this May 21, 2026

mokagio deleted the mokagio/swiftlint-modifier-order branch May 21, 2026 06:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable SwiftLint rule: modifier_order#25568

Enable SwiftLint rule: modifier_order#25568
mokagio wants to merge 1 commit into
trunkfrom
mokagio/swiftlint-modifier-order

mokagio commented May 20, 2026

Uh oh!

dangermattic commented May 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

wpmobilebot commented May 20, 2026

Uh oh!

wpmobilebot commented May 20, 2026

Uh oh!

crazytonyli commented May 20, 2026

Uh oh!

mokagio commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mokagio commented May 20, 2026

Rationale

How to test

Notes

Uh oh!

dangermattic commented May 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

wpmobilebot commented May 20, 2026

Uh oh!

wpmobilebot commented May 20, 2026

Uh oh!

crazytonyli commented May 20, 2026

Uh oh!

mokagio commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants