Skip to content

[Tooling] Update App Center Distribution Group used by Installable Builds #19778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2022
Merged

[Tooling] Update App Center Distribution Group used by Installable Builds #19778

merged 1 commit into from
Dec 15, 2022

Conversation

@AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Dec 14, 2022 •
edited
Loading

Note: This is a replication of a similar PR done on WooCommerce-iOS a while ago

Note: See internal request pdnsEh-Of-p2

Description

This PR should resolve access issues by distributing prototype builds to the Collaborators group on App Center, which is the group associated with our internal automation.

  • WPiOS-One-Offs app (line 274): this PR updates the destinations parameter of the appcenter_upload call to "Collaborators"
  • jetpack-installable-builds app (line 327): No change. The appcenter_upload call already specified "Collaborators" for its destinations parameter
  • WP-Internal app (line 225): No change. The appcenter_upload call didn't specify a destinations parameter at all, hence defaulting to "Collaborators" already.

Testing instructions

Note that the build associated with this PR is distributed to the Collaborators group.

@AliSoftware
Update the Distribution Group used by Installable Builds to the defau…
6770abb 
…lt 'Collaborators' group

Simplifies user management, and this is the group people gets added to by default by our MC tool anyway

See pdnsEh-Of-p2
@AliSoftware AliSoftware added the Tooling Build, Release, and Validation Tools label Dec 14, 2022
@AliSoftware AliSoftware added this to the 21.5 milestone Dec 14, 2022
@AliSoftware AliSoftware requested a review from a team December 14, 2022 20:11
@AliSoftware AliSoftware self-assigned this Dec 14, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 14, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19778-6770abb on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 14, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19778-6770abb on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Dec 14, 2022 •
edited
Loading

Proof it worked as expected:

WPiOS-One-Offs releases on AppCenter were released to All-users-of-WPiOS-One-Offs before, but will now be distributed to Collaborators:
image

jetpack-installable-builds releases on AppCenter were always released to Collaborators already:
image

@AliSoftware AliSoftware merged commit f1d52cc into trunk Dec 15, 2022
@AliSoftware AliSoftware deleted the tooling/appcenter-distribution-group branch December 15, 2022 04:07
@twstokes
Copy link
Contributor

twstokes commented Dec 15, 2022

👋 @AliSoftware - should this target the 21.4 milestone? Currently the 21.4 release branch hasn't been cut from trunk.

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Dec 16, 2022

Hey @twstokes, very good question!
Tbh I was quite lost when I had to choose a milestone for that PR, because the dates associated with the GitHub milestones were incorrect and hadn't been fixed to account for our modified schedule due to holiday break, so I was a bit confused as to which one to pick. (see p1671048679087929-slack-C02KLTL3MKM)

I just checked the current versioning and it seems that at the time of speaking, 21.3 is the one in code freeze while 21.4 is the one in trunk, so indeed targetting 21.4 is likely what I meant instead 👍 Thanks for the correction!

@AliSoftware AliSoftware modified the milestones: 21.5, 21.4 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkmassel jkmassel jkmassel approved these changes

Assignees

@AliSoftware AliSoftware

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Milestone

21.4

Development

Successfully merging this pull request may close these issues.

5 participants

@AliSoftware @wpmobilebot @twstokes @jkmassel