Merge pull request #669 from wordpress-mobile/wcios/site-discovery-bypass-app-transport-security

Site discovery: bypass app transport security when checking site existence

Author: itsmeichigo

WordPressAuthenticator.podspec

@@ -2,7 +2,7 @@
 
 Pod::Spec.new do |s|
   s.name          = 'WordPressAuthenticator'
-  s.version       = '2.2.1-beta.4'
+  s.version       = '2.2.1-beta.5'
 
   s.summary       = 'WordPressAuthenticator implements an easy and elegant way to authenticate your WordPress Apps.'
   s.description   = <<-DESC

WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteAddressViewController.swift

@@ -440,14 +440,22 @@ private extension SiteAddressViewController {
         }
 
         // Checks that the site exists
+        checkSiteExistence(url: url) { [weak self] in
+            guard let self = self else { return }
+            // Proceeds to check for the site's WordPress
+            self.guessXMLRPCURL(for: self.loginFields.siteAddress)
+        }
+    }
+
+    func checkSiteExistence(url: URL, onCompletion: @escaping () -> Void) {
         var request = URLRequest(url: url)
         request.httpMethod = "HEAD"
         request.timeoutInterval = 10.0 // waits for 10 seconds
         let task = URLSession.shared.dataTask(with: request) { [weak self] _, _, error in
             DispatchQueue.main.async { [weak self] in
                 guard let self = self else { return }
 
-                if let error = error {
+                if let error = error, (error as NSError).code != NSURLErrorAppTransportSecurityRequiresSecureConnection {
                     self.configureViewLoading(false)
 
                     if self.authenticationDelegate.shouldHandleError(error) {
@@ -460,8 +468,7 @@ private extension SiteAddressViewController {
                     return self.displayError(message: Localization.nonExistentSiteError, moveVoiceOverFocus: true)
                 }
 
-                // Proceeds to check for the site's WordPress
-                self.guessXMLRPCURL(for: self.loginFields.siteAddress)
+                onCompletion()
             }
         }
         task.resume()