Make pages property private in LoginProloguePageViewController

The rationale is to prevent usages outside of the file to facilitate
getting rid of it in the future.

Author: mokagio

WordPressAuthenticator/Signin/LoginProloguePageViewController.swift

@@ -2,7 +2,11 @@ import UIKit
 import WordPressShared
 
 class LoginProloguePageViewController: UIPageViewController {
-    @objc var pages: [UIViewController] = []
+    // This property is a legacy of the previous UX iteration. It ought to be removed, but that's
+    // out of scope at the time of writing. It's now `private` to prevent using it within the
+    // library in the meantime
+    @objc private var pages: [UIViewController] = []
+
     fileprivate var pageControl: UIPageControl?
     fileprivate var bgAnimation: UIViewPropertyAnimator?
     fileprivate struct Constants {
@@ -15,17 +19,6 @@ class LoginProloguePageViewController: UIPageViewController {
         dataSource = self
         delegate = self
 
-        // During the Lottie and related view controllers and portions of view controllers, removal,
-        // the previous version of this code, without the array length check, crashed in the
-        // WooCommerce UI tests.
-        //
-        // I believe the reason is that the views and flows in this library haven't properly been
-        // updated to reflect the simplification in the UX and there are still elements that
-        // require this class to exist and be instantiated, even though it might not be used
-        // directly.
-        if pages.isEmpty == false {
-            setViewControllers([pages[0]], direction: .forward, animated: false)
-        }
         view.backgroundColor = WordPressAuthenticator.shared.style.prologueBackgroundColor
 
         addPageControl()