Add custom error type for ServiceError

itsmeichigo · itsmeichigo · commit 958e0c81a718 · 2024-03-08T15:59:02.000+07:00
diff --git a/WordPressAuthenticator/Services/WordPressComBlogService.swift b/WordPressAuthenticator/Services/WordPressComBlogService.swift
@@ -43,7 +43,7 @@ class WordPressComBlogService {
 
             let site = WordPressComSiteInfo(remote: response)
             guard site.url != Constants.wordPressBlogURL else {
-                failure(WordPressOrgXMLRPCValidatorError.invalid)
+                failure(ServiceError.invalidWordPressAddress)
                 return
             }
             success(site)
@@ -63,5 +63,6 @@ extension WordPressComBlogService {
 
     enum ServiceError: Error {
         case unknown
+        case invalidWordPressAddress
     }
 }
diff --git a/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteAddressViewController.swift b/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteAddressViewController.swift
@@ -552,7 +552,7 @@ private extension SiteAddressViewController {
                     self?.navigationController?.pushViewController(customUI, animated: true)
                 }
             } else {
-                self.displayError(error, sourceTag: self.sourceTag)
+                self.displayError(message: Localization.invalidURL)
             }
         })
     }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ class WordPressComBlogService {`
`43`	`43`
`44`	`44`	`let site = WordPressComSiteInfo(remote: response)`
`45`	`45`	`guard site.url != Constants.wordPressBlogURL else {`
`46`		`- failure(WordPressOrgXMLRPCValidatorError.invalid)`
	`46`	`+ failure(ServiceError.invalidWordPressAddress)`
`47`	`47`	`return`
`48`	`48`	`}`
`49`	`49`	`success(site)`
`@@ -63,5 +63,6 @@ extension WordPressComBlogService {`
`63`	`63`
`64`	`64`	`enum ServiceError: Error {`
`65`	`65`	`case unknown`
	`66`	`+ case invalidWordPressAddress`
`66`	`67`	`}`
`67`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -552,7 +552,7 @@ private extension SiteAddressViewController {`
`552`	`552`	`self?.navigationController?.pushViewController(customUI, animated: true)`
`553`	`553`	`}`
`554`	`554`	`} else {`
`555`		`- self.displayError(error, sourceTag: self.sourceTag)`
	`555`	`+ self.displayError(message: Localization.invalidURL)`
`556`	`556`	`}`
`557`	`557`	`})`
`558`	`558`	`}`