Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Commit b0078cc

Browse files
Merge pull request #103 from wordpress-mobile/try/document-critical-path
Documents some critical stats we're tracking.
2 parents 93c64ac + 60bc958 commit b0078cc

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ class NUXLinkAuthViewController: LoginViewController {
3333
if let linkSource = loginFields.meta.emailMagicLinkSource {
3434
switch linkSource {
3535
case .signup:
36+
// This stat is part of a funnel that provides critical information. Before
37+
// making ANY modification to this stat please refer to: p4qSXL-35X-p2
3638
WordPressAuthenticator.track(.createdAccount, properties: ["source": "email"])
3739
WordPressAuthenticator.track(.signupMagicLinkSucceeded)
3840
case .login:

WordPressAuthenticator/Signin/LoginPrologueViewController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ class LoginPrologueViewController: LoginViewController {
8585
}
8686

8787
private func signupTapped() {
88+
// This stat is part of a funnel that provides critical information. Before
89+
// making ANY modification to this stat please refer to: p4qSXL-35X-p2
8890
WordPressAuthenticator.track(.signupButtonTapped)
8991
performSegue(withIdentifier: NUXViewController.SegueIdentifier.showSignupMethod.rawValue, sender: self)
9092
}

WordPressAuthenticator/Signup/SignupGoogleViewController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ private extension SignupGoogleViewController {
130130
/// Social Signup Successful: Analytics + Pushing the Signup Epilogue.
131131
///
132132
func socialSignupWasSuccessful(with credentials: AuthenticatorCredentials) {
133+
// This stat is part of a funnel that provides critical information. Before
134+
// making ANY modification to this stat please refer to: p4qSXL-35X-p2
133135
WordPressAuthenticator.track(.createdAccount, properties: ["source": "google"])
134136
WordPressAuthenticator.track(.signupSocialSuccess)
135137

0 commit comments

Comments
 (0)