Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Commit c7a8c39

Browse files
committed
Rename from displayText to displayStrings
1 parent 89c7c87 commit c7a8c39

File tree

6 files changed

+19
-19
lines changed

6 files changed

+19
-19
lines changed

WordPressAuthenticator.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
B5ED791D207E993E00A8FD8C /* WPAuthenticatorLogging.h in Headers */ = {isa = PBXBuildFile; fileRef = B5ED7918207E993E00A8FD8C /* WPAuthenticatorLogging.h */; settings = {ATTRIBUTES = (Public, ); }; };
9797
B5ED791F207E993E00A8FD8C /* CocoaLumberjack.swift in Sources */ = {isa = PBXBuildFile; fileRef = B5ED791A207E993E00A8FD8C /* CocoaLumberjack.swift */; };
9898
B5ED7920207E993E00A8FD8C /* WPAuthenticatorLogging.m in Sources */ = {isa = PBXBuildFile; fileRef = B5ED791B207E993E00A8FD8C /* WPAuthenticatorLogging.m */; };
99-
CE16177521B6D82200B82A47 /* WordPressAuthenticatorDisplayText.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE16177421B6D82200B82A47 /* WordPressAuthenticatorDisplayText.swift */; };
99+
CE16177521B6D82200B82A47 /* WordPressAuthenticatorDisplayStrings.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE16177421B6D82200B82A47 /* WordPressAuthenticatorDisplayStrings.swift */; };
100100
CE16177821B70C1A00B82A47 /* WordPressAuthenticatorDisplayTextTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE16177721B70C1A00B82A47 /* WordPressAuthenticatorDisplayTextTests.swift */; };
101101
CE1B18C920EEC2C200BECC3F /* SocialService.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE1B18C820EEC2C200BECC3F /* SocialService.swift */; };
102102
CE1B18CC20EEC32400BECC3F /* WordPressCredentials.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE1B18CB20EEC32400BECC3F /* WordPressCredentials.swift */; };
@@ -236,7 +236,7 @@
236236
B5ED791A207E993E00A8FD8C /* CocoaLumberjack.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CocoaLumberjack.swift; sourceTree = "<group>"; };
237237
B5ED791B207E993E00A8FD8C /* WPAuthenticatorLogging.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = WPAuthenticatorLogging.m; sourceTree = "<group>"; };
238238
C736FF243DE333FCAB1C2614 /* Pods_WordPressAuthenticator.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_WordPressAuthenticator.framework; sourceTree = BUILT_PRODUCTS_DIR; };
239-
CE16177421B6D82200B82A47 /* WordPressAuthenticatorDisplayText.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WordPressAuthenticatorDisplayText.swift; sourceTree = "<group>"; };
239+
CE16177421B6D82200B82A47 /* WordPressAuthenticatorDisplayStrings.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WordPressAuthenticatorDisplayStrings.swift; sourceTree = "<group>"; };
240240
CE16177721B70C1A00B82A47 /* WordPressAuthenticatorDisplayTextTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WordPressAuthenticatorDisplayTextTests.swift; sourceTree = "<group>"; };
241241
CE1B18C820EEC2C200BECC3F /* SocialService.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SocialService.swift; sourceTree = "<group>"; };
242242
CE1B18CB20EEC32400BECC3F /* WordPressCredentials.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WordPressCredentials.swift; sourceTree = "<group>"; };
@@ -406,7 +406,7 @@
406406
B56090F6208A533200399AE4 /* WordPressSupportSourceTag.swift */,
407407
CE1B18CF20EEC41600BECC3F /* WordPressAuthenticatorConfiguration.swift */,
408408
CE1B18D120EEC44400BECC3F /* WordPressAuthenticatorStyles.swift */,
409-
CE16177421B6D82200B82A47 /* WordPressAuthenticatorDisplayText.swift */,
409+
CE16177421B6D82200B82A47 /* WordPressAuthenticatorDisplayStrings.swift */,
410410
);
411411
path = Authenticator;
412412
sourceTree = "<group>";
@@ -847,7 +847,7 @@
847847
CE1B18D020EEC41600BECC3F /* WordPressAuthenticatorConfiguration.swift in Sources */,
848848
CE1B18D220EEC44400BECC3F /* WordPressAuthenticatorStyles.swift in Sources */,
849849
B56090F0208A527000399AE4 /* FancyAlertViewController+LoginError.swift in Sources */,
850-
CE16177521B6D82200B82A47 /* WordPressAuthenticatorDisplayText.swift in Sources */,
850+
CE16177521B6D82200B82A47 /* WordPressAuthenticatorDisplayStrings.swift in Sources */,
851851
CE1B18CE20EEC3CB00BECC3F /* WordPressAuthenticatorDelegateProtocol.swift in Sources */,
852852
B5609110208A54F800399AE4 /* OnePasswordFacade.swift in Sources */,
853853
B5609109208A54F800399AE4 /* SignupService.swift in Sources */,

WordPressAuthenticator/Authenticator/WordPressAuthenticator.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ import WordPressUI
3838

3939
/// Authenticator's Display Texts.
4040
///
41-
public let text: WordPressAuthenticatorDisplayText
41+
public let displayStrings: WordPressAuthenticatorDisplayStrings
4242

4343
/// Notification to be posted whenever the signing flow completes.
4444
///
@@ -61,22 +61,22 @@ import WordPressUI
6161
///
6262
private init(configuration: WordPressAuthenticatorConfiguration,
6363
style: WordPressAuthenticatorStyle,
64-
text: WordPressAuthenticatorDisplayText) {
64+
displayStrings: WordPressAuthenticatorDisplayStrings) {
6565
self.configuration = configuration
6666
self.style = style
67-
self.text = text
67+
self.displayStrings = displayStrings
6868
}
6969

7070
/// Initializes the WordPressAuthenticator with the specified Configuration.
7171
///
7272
public static func initialize(configuration: WordPressAuthenticatorConfiguration,
7373
style: WordPressAuthenticatorStyle = .defaultStyle,
74-
text: WordPressAuthenticatorDisplayText = .defaultText) {
74+
displayStrings: WordPressAuthenticatorDisplayStrings = .defaultStrings) {
7575
guard privateInstance == nil else {
7676
fatalError("WordPressAuthenticator is already initialized")
7777
}
7878

79-
privateInstance = WordPressAuthenticator(configuration: configuration, style: style, text: text)
79+
privateInstance = WordPressAuthenticator(configuration: configuration, style: style, displayStrings: displayStrings)
8080
}
8181

8282
// MARK: - Public Methods

WordPressAuthenticator/Authenticator/WordPressAuthenticatorDisplayText.swift renamed to WordPressAuthenticator/Authenticator/WordPressAuthenticatorDisplayStrings.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import Foundation
22

33

4-
// MARK: - WordPress Authenticator Display Text
4+
// MARK: - WordPress Authenticator Display Strings
55
//
6-
public struct WordPressAuthenticatorDisplayText {
7-
/// Text: Login instructions.
6+
public struct WordPressAuthenticatorDisplayStrings {
7+
/// Strings: Login instructions.
88
///
99
public let emailLoginInstructions: String
1010

@@ -21,9 +21,9 @@ public struct WordPressAuthenticatorDisplayText {
2121
}
2222
}
2323

24-
public extension WordPressAuthenticatorDisplayText {
25-
public static var defaultText: WordPressAuthenticatorDisplayText {
26-
return WordPressAuthenticatorDisplayText(emailLoginInstructions: NSLocalizedString("Log in to WordPress.com using an email address to manage all your WordPress sites.", comment: "Instruction text on the login's email address screen."),
24+
public extension WordPressAuthenticatorDisplayStrings {
25+
public static var defaultStrings: WordPressAuthenticatorDisplayStrings {
26+
return WordPressAuthenticatorDisplayStrings(emailLoginInstructions: NSLocalizedString("Log in to WordPress.com using an email address to manage all your WordPress sites.", comment: "Instruction text on the login's email address screen."),
2727
jetpackLoginInstructions: NSLocalizedString("Log in to the WordPress.com account you used to connect Jetpack.", comment: "Instruction text on the login's email address screen."),
2828
siteLoginInstructions: NSLocalizedString("Enter the address of your WordPress site you'd like to connect.", comment: "Instruction text on the login's site addresss screen."))
2929
}

WordPressAuthenticator/Signin/LoginEmailViewController.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@ open class LoginEmailViewController: LoginViewController, NUXKeyboardResponder {
101101
///
102102
func localizeControls() {
103103
if loginFields.meta.jetpackLogin {
104-
instructionLabel?.text = WordPressAuthenticator.shared.text.jetpackLoginInstructions
104+
instructionLabel?.text = WordPressAuthenticator.shared.displayStrings.jetpackLoginInstructions
105105
} else {
106-
instructionLabel?.text = WordPressAuthenticator.shared.text.emailLoginInstructions
106+
instructionLabel?.text = WordPressAuthenticator.shared.displayStrings.emailLoginInstructions
107107
}
108108
emailTextField.placeholder = NSLocalizedString("Email address", comment: "Placeholder for a textfield. The user may enter their email address.")
109109
emailTextField.accessibilityIdentifier = "Email address"

WordPressAuthenticator/Signin/LoginSiteAddressViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class LoginSiteAddressViewController: LoginViewController, NUXKeyboardResponder
6767
/// Assigns localized strings to various UIControl defined in the storyboard.
6868
///
6969
@objc func localizeControls() {
70-
instructionLabel?.text = WordPressAuthenticator.shared.text.siteLoginInstructions
70+
instructionLabel?.text = WordPressAuthenticator.shared.displayStrings.siteLoginInstructions
7171

7272
siteURLField.placeholder = NSLocalizedString("example.wordpress.com", comment: "Site Address placeholder")
7373

WordPressAuthenticatorTests/Authenticator/WordPressAuthenticatorDisplayTextTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import XCTest
66
class WordPressAuthenticatorDisplayTextTests: XCTestCase {
77
/// Default display text instance
88
///
9-
let displayTextDefaults = WordPressAuthenticatorDisplayText.defaultText
9+
let displayTextDefaults = WordPressAuthenticatorDisplayStrings.defaultText
1010

1111
/// Verifies that values in defaultText are not nil
1212
///

0 commit comments

Comments
 (0)