Merge pull request #620 from wordpress-mobile/fix-wrong-parameter-in-site-media-api

crazytonyli · web-flow · commit 275b80b7352b · 2023-07-26T16:23:35.000+12:00
Fix incorrect parameter names used in the media library count API
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -42,7 +42,7 @@ _None._
 
 ### Bug Fixes
 
-_None._
+- Correctly set `mime_type` in media library count API calls [#620]
 
 ### Internal Changes
 
diff --git a/WordPressKit/MediaServiceRemoteREST.m b/WordPressKit/MediaServiceRemoteREST.m
@@ -101,7 +101,7 @@ - (void)getMediaLibraryCountForType:(NSString *)mediaType
     
     NSMutableDictionary *parameters = [NSMutableDictionary dictionaryWithDictionary:@{ @"number" : @1 }];
     if (mediaType) {
-        parameters[@"media_type"] = mediaType;
+        parameters[@"mime_type"] = mediaType;
     }
     
     [self.wordPressComRestApi GET:requestUrl
diff --git a/WordPressKit/MediaServiceRemoteXMLRPC.m b/WordPressKit/MediaServiceRemoteXMLRPC.m
@@ -80,7 +80,7 @@ - (void)getMediaLibraryCountForType:(NSString *)mediaType
 {
     NSDictionary *data = @{};
     if (mediaType) {
-        data = @{@"filter":@{ @"media_type": mediaType }};
+        data = @{@"filter":@{ @"mime_type": mediaType }};
     }
     NSArray *parameters = [self XMLRPCArgumentsWithExtra:data];
     [self.api callMethod:@"wp.getMediaLibrary"

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ - (void)getMediaLibraryCountForType:(NSString *)mediaType`
`101`	`101`
`102`	`102`	`NSMutableDictionary *parameters = [NSMutableDictionary dictionaryWithDictionary:@{ @"number" : @1 }];`
`103`	`103`	`if (mediaType) {`
`104`		`- parameters[@"media_type"] = mediaType;`
	`104`	`+ parameters[@"mime_type"] = mediaType;`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`[self.wordPressComRestApi GET:requestUrl`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ - (void)getMediaLibraryCountForType:(NSString *)mediaType`
`80`	`80`	`{`
`81`	`81`	`NSDictionary *data = @{};`
`82`	`82`	`if (mediaType) {`
`83`		`- data = @{@"filter":@{ @"media_type": mediaType }};`
	`83`	`+ data = @{@"filter":@{ @"mime_type": mediaType }};`
`84`	`84`	`}`
`85`	`85`	`NSArray *parameters = [self XMLRPCArgumentsWithExtra:data];`
`86`	`86`	`[self.api callMethod:@"wp.getMediaLibrary"`