Simplified unit tests as suggested via PR feedback

Author: sabaranski

WordPressKitTests/SiteVerticalsRequestEncodingTests.swift

@@ -19,10 +19,10 @@ final class SiteVerticalsRequestEncodingTests: XCTestCase {
         XCTAssertNoThrow(try JSONSerialization.jsonObject(with: encodedJSON, options: []))
         let serializedJSON = try! JSONSerialization.jsonObject(with: encodedJSON, options: [])
 
-        if let _ = serializedJSON as? [String : AnyObject] {} else {
+        guard let jsonDictionary = serializedJSON as? [String : AnyObject] else {
             XCTFail("Failed to encode a proper JSON dictionary!")
+            return
         }
-        let jsonDictionary = serializedJSON as! [String : AnyObject]
 
         // Then
         let actualSearch = jsonDictionary["search"] as? String
@@ -50,10 +50,10 @@ final class SiteVerticalsRequestEncodingTests: XCTestCase {
         XCTAssertNoThrow(try JSONSerialization.jsonObject(with: encodedJSON, options: []))
         let serializedJSON = try! JSONSerialization.jsonObject(with: encodedJSON, options: [])
 
-        if let _ = serializedJSON as? [String : AnyObject] {} else {
+        guard let jsonDictionary = serializedJSON as? [String : AnyObject] else {
             XCTFail("Failed to encode a proper JSON dictionary!")
+            return
         }
-        let jsonDictionary = serializedJSON as! [String : AnyObject]
 
         // Then
         let actualSearch = jsonDictionary["search"] as? String
@@ -81,10 +81,10 @@ final class SiteVerticalsRequestEncodingTests: XCTestCase {
         XCTAssertNoThrow(try JSONSerialization.jsonObject(with: encodedJSON, options: []))
         let serializedJSON = try! JSONSerialization.jsonObject(with: encodedJSON, options: [])
 
-        if let _ = serializedJSON as? [String : AnyObject] {} else {
+        guard let jsonDictionary = serializedJSON as? [String : AnyObject] else {
             XCTFail("Failed to encode a proper JSON dictionary!")
+            return
         }
-        let jsonDictionary = serializedJSON as! [String : AnyObject]
 
         // Then
         let actualSearch = jsonDictionary["search"] as? String

WordPressKitTests/SiteVerticalsResponseDecodingTests.swift

@@ -120,7 +120,6 @@ final class SiteVerticalDecodingTests: XCTestCase {
     // MARK: Multiple Verticals
 
     func testSiteParsingOfMultipleVerticalsWorksAsExpected() {
-        XCTAssertTrue(!verticalsSUT.isEmpty)
         XCTAssertEqual(verticalsSUT.count, 5)
     }