Skip to content

Commit 23a7686

Browse files
committed
[fix] Allow additional properties in ModelConfigSchema and DocumentChunkSchema
- Updated ModelConfigSchema and DocumentChunkSchema to permit additional properties, enhancing flexibility in schema definitions. - Refactored getPortData method in Dataflow class to improve clarity and maintainability by using a result variable for return values.
1 parent 3a0fdca commit 23a7686

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

packages/ai/src/model/ModelSchema.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export const ModelConfigSchema = {
2626
},
2727
required: ["provider", "provider_config"],
2828
format: "model",
29-
additionalProperties: false,
29+
additionalProperties: true,
3030
} as const satisfies DataPortSchemaObject;
3131

3232
/**

packages/dataset/src/document-chunk/DocumentChunkSchema.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export const DocumentChunkSchema = {
1818
vector: TypedArraySchema(),
1919
metadata: { type: "object", format: "metadata", additionalProperties: true },
2020
},
21-
additionalProperties: false,
21+
additionalProperties: true,
2222
} as const satisfies DataPortSchemaObject;
2323
export type DocumentChunkSchema = typeof DocumentChunkSchema;
2424

packages/task-graph/src/task-graph/Dataflow.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,15 @@ export class Dataflow {
9696
}
9797

9898
getPortData(): TaskOutput {
99+
let result: TaskOutput;
99100
if (this.targetTaskPortId === DATAFLOW_ALL_PORTS) {
100-
return this.value;
101+
result = this.value;
101102
} else if (this.targetTaskPortId === DATAFLOW_ERROR_PORT) {
102-
return { [DATAFLOW_ERROR_PORT]: this.error };
103+
result = { [DATAFLOW_ERROR_PORT]: this.error };
103104
} else {
104-
return { [this.targetTaskPortId]: this.value };
105+
result = { [this.targetTaskPortId]: this.value };
105106
}
107+
return result;
106108
}
107109

108110
toJSON(): DataflowJson {

0 commit comments

Comments
 (0)