feat: Support Basic SSL plugin options#420
Merged
Patrick Lafrance (patricklafrance) merged 5 commits intoApr 10, 2026
Merged
Conversation
- Added `lastUpdated` section to `retype.yml` to disable date and author display. fix: update dev config interface for SSL plugin - Updated the dev config interface to accept options for the basic SSL plugin through the `https` option.
Copilot started reviewing on behalf of
Patrick Lafrance (patricklafrance)
April 10, 2026 18:18
View session
@workleap/browserslist-config
@workleap/eslint-configs
@workleap/postcss-configs
@workleap/rsbuild-configs
@workleap/rslib-configs
@workleap/stylelint-configs
@workleap/swc-configs
@workleap/tsup-configs
@workleap/typescript-configs
@workleap/webpack-configs
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation/build tooling configuration and expands @workleap/rsbuild-configs dev HTTPS configuration to support customizing @rsbuild/plugin-basic-ssl via a callback.
Changes:
- Add Retype
lastUpdatedconfiguration and bumpretypeapp(with corresponding lockfile updates). - Extend
defineDevConfig({ https })to accept a function that configuresplugin-basic-ssl, and add a test covering that case. - Update docs to document the new
httpscallback option and provide examples.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| retype.yml | Adds lastUpdated configuration. |
| .github/workflows/retype-action.yml | No functional change (formatting-only diff). |
| package.json | Bumps retypeapp to 4.5.3. |
| pnpm-lock.yaml | Lockfile changes from dependency bumps (incl. retypeapp). |
| packages/rsbuild-configs/src/assertions.ts | Adds isFunction helper. |
| packages/rsbuild-configs/src/dev.ts | Allows https to be a function for configuring plugin-basic-ssl. |
| packages/rsbuild-configs/tests/dev.test.ts | Adds a test for function-based https; introduces an unused import. |
| docs/rsbuild/configure-dev.md | Documents the https function option and adds examples. |
| .changeset/gold-words-heal.md | Declares a patch release for @workleap/rsbuild-configs describing the API change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…b.com/workleap/wl-web-configs into feat/support-basic-ssl-plugin-options
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpsoption.