Skip to content

Commit ca83e49

Browse files
authored
Migrate to Bzlmod. (#65)
This drops the dependency on common-jvm, instead depending on rules_kotlin_jvm directly.
1 parent 097d16b commit ca83e49

File tree

13 files changed

+163
-153
lines changed

13 files changed

+163
-153
lines changed

.bazelrc

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# Enable Bzlmod with WFA registry.
2+
common --enable_bzlmod
3+
common --registry=https://raw.githubusercontent.com/world-federation-of-advertisers/bazel-registry/main
4+
common --registry=https://bcr.bazel.build
5+
16
# Use clang as C++ compiler.
27
build --repo_env='CC=clang'
38

@@ -7,5 +12,8 @@ build --cxxopt='-std=c++17'
712
# Use JDK 11. See https://github.com/bazelbuild/bazel/issues/6245.
813
build --java_runtime_version=remotejdk_11
914

10-
# Target Java 8.
11-
build --java_language_version=8
15+
# Target Java 9.
16+
build --java_language_version=9
17+
18+
# TODO(world-federation-of-advertisers/virtual-people-common#64): Remove when fixed.
19+
test --compilation_mode=fastbuild

.bazelversion

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
5.4.0
1+
6.4.0

MODULE.bazel

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
module(
2+
name = "virtual-people-common",
3+
repo_name = "wfa_virtual_people_common",
4+
)
5+
6+
TRUTH_VERSION = "1.1.2"
7+
8+
MAVEN_REPO_NAME = "vpc_maven"
9+
10+
# Bazel Central Registry modules.
11+
bazel_dep(
12+
name = "rules_proto",
13+
version = "5.3.0-21.7",
14+
)
15+
bazel_dep(
16+
name = "protobuf",
17+
version = "21.7",
18+
repo_name = "com_google_protobuf",
19+
)
20+
bazel_dep(
21+
name = "rules_cc",
22+
version = "0.0.9",
23+
)
24+
bazel_dep(
25+
name = "abseil-cpp",
26+
version = "20230802.0.bcr.1",
27+
repo_name = "com_google_absl",
28+
)
29+
bazel_dep(
30+
name = "googletest",
31+
version = "1.14.0.bcr.1",
32+
repo_name = "com_google_googletest",
33+
)
34+
bazel_dep(
35+
name = "rules_java",
36+
version = "7.2.0",
37+
)
38+
bazel_dep(
39+
name = "rules_jvm_external",
40+
version = "5.3",
41+
)
42+
43+
# WFA registry modules.
44+
bazel_dep(
45+
name = "common-cpp",
46+
version = "0.11.0",
47+
repo_name = "wfa_common_cpp",
48+
)
49+
bazel_dep(
50+
name = "rules_kotlin_jvm",
51+
version = "0.1.1",
52+
repo_name = "wfa_rules_kotlin_jvm",
53+
)
54+
55+
maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
56+
maven.install(
57+
name = MAVEN_REPO_NAME,
58+
artifacts = [
59+
"junit:junit:4.13.2",
60+
"com.google.truth:truth:" + TRUTH_VERSION,
61+
"com.google.truth.extensions:truth-java8-extension:" + TRUTH_VERSION,
62+
"com.google.truth.extensions:truth-proto-extension:" + TRUTH_VERSION,
63+
"com.google.truth.extensions:truth-liteproto-extension:" + TRUTH_VERSION,
64+
],
65+
fetch_sources = True, # For IDE integration.
66+
strict_visibility = True,
67+
)
68+
use_repo(maven, MAVEN_REPO_NAME)

WORKSPACE

Lines changed: 1 addition & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1 @@
1-
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
2-
3-
load("//build:repositories.bzl", "virtual_people_common_repositories")
4-
5-
virtual_people_common_repositories()
6-
7-
load("@wfa_common_jvm//build:common_jvm_repositories.bzl", "common_jvm_repositories")
8-
9-
common_jvm_repositories()
10-
11-
load("@wfa_common_jvm//build:common_jvm_deps.bzl", "common_jvm_deps")
12-
13-
common_jvm_deps()
14-
15-
load("@wfa_common_jvm//build:common_jvm_maven.bzl", "COMMON_JVM_MAVEN_OVERRIDE_TARGETS", "common_jvm_maven_artifacts")
16-
load("@rules_jvm_external//:defs.bzl", "maven_install")
17-
18-
maven_install(
19-
artifacts = common_jvm_maven_artifacts(),
20-
fetch_sources = True,
21-
generate_compat_repositories = True,
22-
override_targets = COMMON_JVM_MAVEN_OVERRIDE_TARGETS,
23-
repositories = [
24-
"https://repo.maven.apache.org/maven2/",
25-
],
26-
)
27-
28-
load("@wfa_common_jvm//build:common_jvm_extra_deps.bzl", "common_jvm_extra_deps")
29-
30-
common_jvm_extra_deps()
31-
32-
load("@wfa_common_cpp//build:common_cpp_repositories.bzl", "common_cpp_repositories")
33-
34-
common_cpp_repositories()
35-
36-
load("@wfa_common_cpp//build:common_cpp_deps.bzl", "common_cpp_deps")
37-
38-
common_cpp_deps()
1+
workspace(name = "wfa_virtual_people_common")
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
load("@rules_java//java:defs.bzl", "java_library")
2+
3+
package(default_visibility = ["//visibility:public"])
4+
5+
java_library(
6+
name = "truth",
7+
exports = [
8+
"@vpc_maven//:com_google_truth_extensions_truth_java8_extension",
9+
"@vpc_maven//:com_google_truth_truth",
10+
],
11+
)
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
load("@rules_java//java:defs.bzl", "java_library")
2+
3+
package(default_visibility = ["//visibility:public"])
4+
5+
java_library(
6+
name = "proto",
7+
exports = [
8+
"@vpc_maven//:com_google_truth_extensions_truth_liteproto_extension",
9+
"@vpc_maven//:com_google_truth_extensions_truth_proto_extension",
10+
],
11+
)

imports/org/junit/BUILD.bazel

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
package(default_visibility = ["//visibility:public"])
2+
3+
alias(
4+
name = "junit",
5+
actual = "@vpc_maven//:junit_junit",
6+
)
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@wfa_common_jvm//build/rules_kotlin:defs.bzl", "kt_jvm_library")
1+
load("@wfa_rules_kotlin_jvm//kotlin:defs.bzl", "kt_jvm_library")
22

33
package(default_visibility = ["//visibility:public"])
44

@@ -8,6 +8,6 @@ kt_jvm_library(
88
deps = [
99
"//src/main/kotlin/org/wfanet/virtualpeople/common/fieldfilter/utils",
1010
"//src/main/proto/wfa/virtual_people/common:field_filter_kt_jvm_proto",
11-
"@wfa_common_jvm//imports/java/com/google/protobuf",
11+
"@wfa_rules_kotlin_jvm//imports/com/google/protobuf",
1212
],
1313
)
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@wfa_common_jvm//build/rules_kotlin:defs.bzl", "kt_jvm_library")
1+
load("@wfa_rules_kotlin_jvm//kotlin:defs.bzl", "kt_jvm_library")
22

33
package(default_visibility = ["//visibility:public"])
44

@@ -7,6 +7,6 @@ kt_jvm_library(
77
srcs = glob(["*.kt"]),
88
deps = [
99
"//src/main/proto/wfa/virtual_people/common:field_filter_kt_jvm_proto",
10-
"@wfa_common_jvm//imports/java/com/google/protobuf",
10+
"@wfa_rules_kotlin_jvm//imports/com/google/protobuf",
1111
],
1212
)

src/main/proto/wfa/virtual_people/common/BUILD.bazel

Lines changed: 9 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
load("@rules_cc//cc:defs.bzl", "cc_proto_library")
22
load("@rules_proto//proto:defs.bzl", "proto_library")
3-
load("@rules_java//java:defs.bzl", "java_proto_library")
4-
load("@wfa_common_jvm//build/kt_jvm_proto:defs.bzl", "kt_jvm_proto_library")
3+
load("@wfa_rules_kotlin_jvm//kotlin:defs.bzl", "kt_jvm_proto_library")
54

65
package(default_visibility = ["//visibility:public"])
76

@@ -25,15 +24,9 @@ cc_proto_library(
2524
deps = [":model_proto"],
2625
)
2726

28-
java_proto_library(
29-
name = "model_java_proto",
30-
deps = [":model_proto"],
31-
)
32-
3327
kt_jvm_proto_library(
3428
name = "model_kt_jvm_proto",
35-
srcs = [":model_proto"],
36-
deps = [":model_java_proto"],
29+
deps = [":model_proto"],
3730
)
3831

3932
proto_library(
@@ -53,15 +46,9 @@ cc_proto_library(
5346
deps = [":event_proto"],
5447
)
5548

56-
java_proto_library(
57-
name = "event_java_proto",
58-
deps = [":event_proto"],
59-
)
60-
6149
kt_jvm_proto_library(
6250
name = "event_kt_jvm_proto",
63-
srcs = [":event_proto"],
64-
deps = [":event_java_proto"],
51+
deps = [":event_proto"],
6552
)
6653

6754
proto_library(
@@ -78,15 +65,9 @@ cc_proto_library(
7865
deps = [":label_proto"],
7966
)
8067

81-
java_proto_library(
82-
name = "label_java_proto",
83-
deps = [":label_proto"],
84-
)
85-
8668
kt_jvm_proto_library(
8769
name = "label_kt_jvm_proto",
88-
srcs = [":label_proto"],
89-
deps = [":label_java_proto"],
70+
deps = [":label_proto"],
9071
)
9172

9273
proto_library(
@@ -100,15 +81,9 @@ cc_proto_library(
10081
deps = [":demographic_proto"],
10182
)
10283

103-
java_proto_library(
104-
name = "demographic_java_proto",
105-
deps = [":demographic_proto"],
106-
)
107-
10884
kt_jvm_proto_library(
10985
name = "demographic_kt_jvm_proto",
110-
srcs = [":demographic_proto"],
111-
deps = [":demographic_java_proto"],
86+
deps = [":demographic_proto"],
11287
)
11388

11489
proto_library(
@@ -122,15 +97,9 @@ cc_proto_library(
12297
deps = [":geo_location_proto"],
12398
)
12499

125-
java_proto_library(
126-
name = "geo_location_java_proto",
127-
deps = [":geo_location_proto"],
128-
)
129-
130100
kt_jvm_proto_library(
131101
name = "geo_location_kt_jvm_proto",
132-
srcs = [":geo_location_proto"],
133-
deps = [":geo_location_java_proto"],
102+
deps = [":geo_location_proto"],
134103
)
135104

136105
proto_library(
@@ -147,15 +116,9 @@ cc_proto_library(
147116
deps = [":panel_data_proto"],
148117
)
149118

150-
java_proto_library(
151-
name = "panel_data_java_proto",
152-
deps = [":panel_data_proto"],
153-
)
154-
155119
kt_jvm_proto_library(
156120
name = "panel_data_kt_jvm_proto",
157-
srcs = [":panel_data_proto"],
158-
deps = [":panel_data_java_proto"],
121+
deps = [":panel_data_proto"],
159122
)
160123

161124
proto_library(
@@ -169,15 +132,9 @@ cc_proto_library(
169132
deps = [":field_filter_proto"],
170133
)
171134

172-
java_proto_library(
173-
name = "field_filter_java_proto",
174-
deps = [":field_filter_proto"],
175-
)
176-
177135
kt_jvm_proto_library(
178136
name = "field_filter_kt_jvm_proto",
179-
srcs = [":field_filter_proto"],
180-
deps = [":field_filter_java_proto"],
137+
deps = [":field_filter_proto"],
181138
)
182139

183140
proto_library(
@@ -191,13 +148,7 @@ cc_proto_library(
191148
deps = [":config_proto"],
192149
)
193150

194-
java_proto_library(
195-
name = "config_java_proto",
196-
deps = [":config_proto"],
197-
)
198-
199151
kt_jvm_proto_library(
200152
name = "config_kt_jvm_proto",
201-
srcs = [":config_proto"],
202-
deps = [":config_java_proto"],
153+
deps = [":config_proto"],
203154
)

0 commit comments

Comments
 (0)