fix: fd limit parameter and documentation

Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>

Author: reneca

REFERENCE.md

@@ -19,6 +19,7 @@
 ### Defined types
 
 * [`prosa::proc`](#prosa--proc): Allows specialised configurations for ProSA processors
+Use the `prosa::processors` defined type if you want to create processors
 
 ### Data types
 
@@ -237,7 +238,7 @@ Default value: `$prosa::params::telemetry_level`
 Data type: `Optional[Hash[String, String]]`
 
 Configures the ProSA [Telemetry Attributes](https://docs.rs/prosa-utils/latest/prosa_utils/config/observability/struct.Observability.html) directive
-which allows to add custom attributes to telemetry messages.
+which allows to add custom attributes to telemetry messages.<br />
 Refer to the [ProSA book](https://worldline.github.io/ProSA/ch01-02-01-observability.html) for more details on how to configure this directive.
 
 Default value: `undef`
@@ -247,7 +248,7 @@ Default value: `undef`
 Data type: `Hash[String, Hash[String, Hash[String, String]]]`
 
 Configures the ProSA [Observability](https://docs.rs/prosa-utils/latest/prosa_utils/config/observability/struct.Observability.html) directive
-which configure metrics, traces and logs export.
+which configure metrics, traces and logs export.<br />
 Refer to the [ProSA book](https://worldline.github.io/ProSA/ch01-02-01-observability.html) for more details on how to configure this directive.
 
 Default value: `$prosa::params::observability`
@@ -295,17 +296,7 @@ Default value: `{}`
 ### <a name="prosa--proc"></a>`prosa::proc`
 
 Allows specialised configurations for ProSA processors
-
-#### Examples
-
-##### 
-
-```puppet
-class { 'prosa':
-  default_vhost     => false,
-  default_ssl_vhost => false,
-}
-```
+Use the `prosa::processors` defined type if you want to create processors
 
 #### Parameters
 

manifests/init.pp

@@ -70,7 +70,7 @@
 #
 # @param telemetry_attributes
 #   Configures the ProSA [Telemetry Attributes](https://docs.rs/prosa-utils/latest/prosa_utils/config/observability/struct.Observability.html) directive
-#   which allows to add custom attributes to telemetry messages.
+#   which allows to add custom attributes to telemetry messages.<br />
 #   Refer to the [ProSA book](https://worldline.github.io/ProSA/ch01-02-01-observability.html) for more details on how to configure this directive.
 #
 # @example Setting custom telemetry attributes
@@ -83,7 +83,7 @@
 #
 # @param observability
 #   Configures the ProSA [Observability](https://docs.rs/prosa-utils/latest/prosa_utils/config/observability/struct.Observability.html) directive
-#   which configure metrics, traces and logs export.
+#   which configure metrics, traces and logs export.<br />
 #   Refer to the [ProSA book](https://worldline.github.io/ProSA/ch01-02-01-observability.html) for more details on how to configure this directive.
 #
 # @example Setting custom observability configuration
@@ -178,14 +178,15 @@
 
   # Declare ProSA service
   class { 'prosa::service':
-    prosa_name     => $prosa_name,
-    service_name   => $service_name,
-    service_binary => $bin_path,
-    app_conf       => $conf_dir,
-    user           => $user,
-    group          => $group,
-    service_enable => $service_enable,
-    service_ensure => $service_ensure,
-    service_manage => $service_manage,
+    prosa_name           => $prosa_name,
+    service_name         => $service_name,
+    service_binary       => $bin_path,
+    app_conf             => $conf_dir,
+    user                 => $user,
+    group                => $group,
+    service_enable       => $service_enable,
+    service_ensure       => $service_ensure,
+    service_manage       => $service_manage,
+    service_limit_nofile => $service_limit_nofile,
   }
 }

manifests/proc.pp

@@ -1,11 +1,6 @@
 # @summary
 #   Allows specialised configurations for ProSA processors
-#
-# @example
-#   class { 'prosa':
-#     default_vhost     => false,
-#     default_ssl_vhost => false,
-#   }
+#   Use the `prosa::processors` defined type if you want to create processors
 #
 # @param adaptor_config_path
 #   For some ProSA adaptor, they need to have a configuration in addition to processor.

manifests/service.pp

@@ -11,7 +11,8 @@
   String $group                            = $prosa::params::group,
   Boolean $service_enable                  = true,
   Variant[Boolean, String] $service_ensure = 'running',
-  Boolean $service_manage                  = true
+  Boolean $service_manage                  = true,
+  Optional[Integer] $service_limit_nofile  = undef
 ) {
   # The base class must be included first because parameter defaults depend on it
   if ! defined(Class['prosa::params']) {
@@ -36,11 +37,12 @@
         group   => $prosa::params::root_group,
         mode    => '0644',
         content => epp('prosa/service.epp', {
-            'prosa_name' => $prosa_name,
-            'user'       => $user,
-            'group'      => $group,
-            'bin_path'   => $service_binary,
-            'conf_path'  => $app_conf,
+            'prosa_name'   => $prosa_name,
+            'user'         => $user,
+            'group'        => $group,
+            'bin_path'     => $service_binary,
+            'conf_path'    => $app_conf,
+            'limit_nofile' => $service_limit_nofile,
         }),
         replace => true,
       }

spec/acceptance/processors_spec.rb

@@ -16,14 +16,14 @@
 
     pp = <<-MANIFEST
         class { 'prosa':
-          prosa_name      => #{prosa_hash['prosa_name']},
-          service_manage  => false,
-          telemetry_level => 'warn',
+          prosa_name           => #{prosa_hash['prosa_name']},
+          service_manage       => false,
+          telemetry_level      => 'warn',
           telemetry_attributes => {
             'service.name' => 'prosa-service',
             'host.id'      => 'fdbf79e8af94cb7f9e8df36789187052',
           },
-          observability   => {
+          observability        => {
             'metrics' => {
               'prometheus' => {
                 'endpoint' => '0.0.0.0:9090',