sui: pause create_transceiver_message

Author: kcsongor

sui/packages/ntt/sources/ntt.move

@@ -24,10 +24,6 @@ module ntt::ntt {
     const EWrongDestinationChain: vector<u8>
         = b"Wrong destination chain";
 
-    #[error]
-    const EPaused: vector<u8>
-        = b"Contract is paused";
-
     #[allow(lint(coin_field))]
     public struct TransferTicket<phantom CoinType> {
         coins: Coin<CoinType>,
@@ -130,7 +126,7 @@ module ntt::ntt {
     ): OutboxKey {
         version_gated.check_version(state);
 
-        assert!(!state.is_paused(), EPaused);
+        state.assert_not_paused();
 
         let TransferTicket {
             coins,
@@ -198,7 +194,7 @@ module ntt::ntt {
     ) {
         version_gated.check_version(state);
 
-        assert!(!state.is_paused(), EPaused);
+        state.assert_not_paused();
 
         let (chain_id, source_ntt_manager, ntt_manager_message) =
             validated_message.destruct_recipient_only(&ntt::auth::new_auth(), state);
@@ -281,7 +277,7 @@ module ntt::ntt {
 
         version_gated.check_version(state);
 
-        assert!(!state.is_paused(), EPaused);
+        state.assert_not_paused();
 
         // NOTE: this validates that the message has enough votes etc
         let released = state.try_release_in(chain_id, message, clock);

sui/packages/ntt/sources/state.move

@@ -22,6 +22,10 @@ module ntt::state {
     const EThresholdTooHigh: vector<u8> =
         b"Threshold too high";
 
+    #[error]
+    const EPaused: vector<u8>
+        = b"Contract is paused";
+
     /// NOTE: this is a shared object, so anyone can grab a mutable reference to
     /// it. Thus, functions are access-controlled by (package) visibility.
     public struct State<phantom T> has key, store {
@@ -184,6 +188,8 @@ module ntt::state {
         message_id: Bytes32,
         clock: &Clock
     ): ntt_common::outbound_message::OutboundMessage<ntt::auth::ManagerAuth, TransceiverAuth> {
+        self.assert_not_paused();
+
         let transceiver_index = self.transceivers.transceiver_id<TransceiverAuth>();
         let outbox_key = outbox::new_outbox_key(message_id);
         let released = self.outbox.try_release(outbox_key, transceiver_index, clock);
@@ -333,6 +339,10 @@ module ntt::state {
         state.paused
     }
 
+    public fun assert_not_paused<T>(state: &State<T>) {
+        assert!(!state.paused, EPaused);
+    }
+
     /// Get the current threshold value
     public fun threshold<T>(state: &State<T>): u8 {
         state.threshold

sui/packages/ntt/tests/ntt_tests.move

@@ -642,7 +642,7 @@ module ntt::ntt_tests {
         scenario.end();
     }
 
-    #[test, expected_failure(abort_code = ::ntt::ntt::EPaused)]
+    #[test, expected_failure(abort_code = ::ntt::state::EPaused)]
     fun test_transfer_when_paused() {
         let (admin, user_a, _, _) = ntt_scenario::test_addresses();
         let mut scenario = test_scenario::begin(admin);
@@ -695,7 +695,7 @@ module ntt::ntt_tests {
         scenario.end();
     }
 
-    #[test, expected_failure(abort_code = ::ntt::ntt::EPaused)]
+    #[test, expected_failure(abort_code = ::ntt::state::EPaused)]
     fun test_redeem_when_paused() {
         let (admin, user_a, user_b, _) = ntt_scenario::test_addresses();
         let mut scenario = test_scenario::begin(admin);