Remove redundant storage _setFeeRecipient (#9)

thelostone-mc · web-flow · commit 1d430ca52d66 · 2025-08-04T09:27:33.000-04:00
diff --git a/src/QueryTypeStakerFactory.sol b/src/QueryTypeStakerFactory.sol
@@ -79,8 +79,7 @@ contract QueryTypeStakerFactory is Ownable {
   /// @param _newRecipient The new address to receive fees.
   function _setFeeRecipient(address _newRecipient) internal {
     if (_newRecipient == address(0)) revert QueryTypeStakerFactory__InvalidRecipient();
-    address old = feeRecipient;
+    emit FeeRecipientUpdated(feeRecipient, _newRecipient);
     feeRecipient = _newRecipient;
-    emit FeeRecipientUpdated(old, _newRecipient);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -79,8 +79,7 @@ contract QueryTypeStakerFactory is Ownable {`
`79`	`79`	`/// @param _newRecipient The new address to receive fees.`
`80`	`80`	`function _setFeeRecipient(address _newRecipient) internal {`
`81`	`81`	`if (_newRecipient == address(0)) revert QueryTypeStakerFactory__InvalidRecipient();`
`82`		`- address old = feeRecipient;`
	`82`	`+ emit FeeRecipientUpdated(feeRecipient, _newRecipient);`
`83`	`83`	`feeRecipient = _newRecipient;`
`84`		`- emit FeeRecipientUpdated(old, _newRecipient);`
`85`	`84`	`}`
`86`	`85`	`}`