chore: prevent native and wrapped token swaps on same chain

Author: kyleleighton

src/hooks/useTokenListWithSearch.ts

@@ -6,13 +6,13 @@ import {
   useDeferredValue,
   startTransition,
 } from 'react';
-import { toNative } from '@wormhole-foundation/sdk';
+import { toNative, isNative } from '@wormhole-foundation/sdk';
 import type { Chain } from '@wormhole-foundation/sdk';
 import type { Token } from 'config/tokens';
 import config from 'config';
 import { useTokens } from 'contexts/TokensContext';
 import { getTokenSymbol } from 'utils';
-import type { Balances } from 'utils/wallet/types';
+import { getWrappedNativeToken } from 'utils/wrappedNativeTokens';
 import { unionBy } from 'es-toolkit';
 
 interface UseTokenListWithSearchParams {
@@ -22,8 +22,6 @@ interface UseTokenListWithSearchParams {
   isSource: boolean;
   isSameChainSwap: boolean;
   sourceToken?: Token;
-  balances: Balances;
-  walletAddress: string;
   tokenPastingEnabled?: boolean;
 }
 
@@ -46,8 +44,6 @@ export const useTokenListWithSearch = ({
   isSource,
   isSameChainSwap,
   sourceToken,
-  balances,
-  walletAddress,
   tokenPastingEnabled = true,
 }: UseTokenListWithSearchParams): UseTokenListWithSearchReturn => {
   const [searchedTokens, setSearchedTokens] = useState<Token[]>([]);
@@ -60,6 +56,15 @@ export const useTokenListWithSearch = ({
     setSearchedTokens((prev) => [...prev, token]);
   }, []);
 
+  // Get wrapped native address for same-chain swaps (only for destination selection)
+  const wrappedNativeAddr = useMemo(() => {
+    if (!isSameChainSwap || !chain || isSource) {
+      return undefined;
+    }
+    const wrapped = getWrappedNativeToken(config.network, chain);
+    return wrapped?.toLowerCase();
+  }, [isSameChainSwap, chain, isSource]);
+
   useEffect(() => {
     if (!chain || !tokenPastingEnabled || !deferredSearch) {
       setSearchedTokens([]);
@@ -103,6 +108,20 @@ export const useTokenListWithSearch = ({
     addTokenIfNotExists,
   ]);
 
+  const sourceTokenInfo = useMemo(() => {
+    if (!sourceToken || !isSameChainSwap || isSource) {
+      return null;
+    }
+
+    return {
+      addressString: sourceToken.addressString,
+      isNative: isNative(sourceToken.address),
+      isWrapped: wrappedNativeAddr
+        ? sourceToken.addressString.toLowerCase() === wrappedNativeAddr
+        : false,
+    };
+  }, [sourceToken, isSameChainSwap, isSource, wrappedNativeAddr]);
+
   const sortedTokens = useMemo(() => {
     // Merge base tokens with any fetched tokens only when searching
     let tokens = deferredSearch
@@ -139,11 +158,30 @@ export const useTokenListWithSearch = ({
       });
     }
 
-    // For destination token list in same-chain swaps, filter out the source token
-    if (!isSource && isSameChainSwap && sourceToken) {
-      tokens = tokens.filter(
-        (t) => t.addressString !== sourceToken.addressString,
-      );
+    // For destination token list in same-chain swaps, filter out invalid options
+    if (sourceTokenInfo) {
+      tokens = tokens.filter((t) => {
+        // Filter out exact same token
+        if (t.addressString === sourceTokenInfo.addressString) {
+          return false;
+        }
+
+        // Block native-wrapped token pairs if we have wrapped native address
+        if (wrappedNativeAddr) {
+          const destIsWrapped =
+            t.addressString.toLowerCase() === wrappedNativeAddr;
+          const destIsNative = isNative(t.address);
+
+          if (
+            (sourceTokenInfo.isNative && destIsWrapped) ||
+            (sourceTokenInfo.isWrapped && destIsNative)
+          ) {
+            return false;
+          }
+        }
+
+        return true;
+      });
     }
 
     return tokens;
@@ -152,9 +190,8 @@ export const useTokenListWithSearch = ({
     searchedTokens,
     deferredSearch,
     searchLower,
-    isSource,
-    isSameChainSwap,
-    sourceToken,
+    sourceTokenInfo,
+    wrappedNativeAddr,
   ]);
 
   const tokenPrices = useMemo(

src/routes/sdkv2/route.ts

@@ -22,6 +22,7 @@ import config, { getWormholeContextV2 } from 'config';
 import { sleep } from 'utils';
 import { isFrankensteinToken } from 'utils';
 import { isNttToken } from 'utils/ntt';
+import { getWrappedNativeToken } from 'utils/wrappedNativeTokens';
 
 type Amount = sdkAmount.Amount;
 
@@ -146,18 +147,10 @@ export class SDKv2Route {
       routeSupportedTokenFetcher,
     );
 
-    // Pre-compute wrapped native address when filtering same-chain swaps
-    let wrappedNativeAddr: string | undefined = undefined;
-    if (isSameChain) {
-      try {
-        const tb = await toContext.context.getTokenBridge();
-        wrappedNativeAddr = (await tb.getWrappedNative())
-          .toString()
-          .toLowerCase();
-      } catch {
-        // No-op
-      }
-    }
+    // Get wrapped native address for same-chain swaps
+    const wrappedNativeAddr = isSameChain
+      ? getWrappedNativeToken(config.network, toContext.chain)?.toLowerCase()
+      : undefined;
 
     const filteredTokens = destTokens.filter((t) => {
       const token = config.tokens.get(t);

src/utils/sdkv2.ts

@@ -21,6 +21,7 @@ import {
   TBTCBridge,
   chainToPlatform,
 } from '@wormhole-foundation/sdk';
+import { getWrappedNativeToken } from './wrappedNativeTokens';
 import type { NttRoute } from '@wormhole-foundation/sdk-route-ntt';
 import type { CCTPv2ExecutorRoute } from '@wormhole-labs/cctp-executor-route';
 import { Connection } from '@solana/web3.js';
@@ -559,10 +560,10 @@ const getTokenBridgeToken = async (
           address: token.address,
         });
 
-  const wrappedNative = await tb.getWrappedNative();
+  const wrappedNative = getWrappedNativeToken(config.network, chain);
 
   const tokenId =
-    wrappedNative.toString() === tokenAddress.toString()
+    wrappedNative && wrappedNative === tokenAddress.toString()
       ? nativeTokenId(chain)
       : Wormhole.tokenId(chain, tokenAddress.toString());
 

src/utils/wrappedNativeTokens.ts

@@ -0,0 +1,22 @@
+import type { Chain, Network } from '@wormhole-foundation/sdk';
+import { chainToPlatform } from '@wormhole-foundation/sdk';
+import { WETH_CONTRACTS } from '@wormhole-foundation/sdk-evm';
+
+const WSOL_ADDRESS = 'So11111111111111111111111111111111111111112';
+
+export function getWrappedNativeToken(
+  network: Network,
+  chain: Chain,
+): string | undefined {
+  const platform = chainToPlatform(chain);
+
+  if (platform === 'Evm') {
+    return WETH_CONTRACTS[network]?.[chain];
+  }
+
+  if (platform === 'Solana') {
+    return WSOL_ADDRESS;
+  }
+
+  return undefined;
+}

src/views/v2/Bridge/AssetPicker/TokenList.tsx

@@ -42,8 +42,6 @@ const TokenList = (props: Props) => {
     isSource: props.isSource,
     isSameChainSwap: props.isSameChainSwap,
     sourceToken: props.sourceToken,
-    balances: props.balances,
-    walletAddress: props.wallet.address,
     tokenPastingEnabled: tokenPastingIsEnabled,
   });
 

src/views/v3/Bridge/AssetPicker/TokenList.tsx

@@ -42,8 +42,6 @@ const TokenList = (props: Props) => {
     isSource: props.isSource,
     isSameChainSwap: props.isSameChainSwap,
     sourceToken: props.sourceToken,
-    balances: props.balances,
-    walletAddress: props.wallet.address,
     tokenPastingEnabled: tokenPastingIsEnabled,
   });